/[Apache-SVN]
ViewVC logotype

Revision 762957


Jump to revision: Previous Next
Author: dreiss
Date: Tue Apr 7 20:51:48 2009 UTC (15 years, 7 months ago)
Changed paths: 2
Log Message:
THRIFT-356. Improve CompactProtocolTestStruct

- Remove the default values from CompactProtocolTestStruct
- Add a const CompactProtocolTestStruct that contains those values

This has a short-term benefit and a long-term benefit.

The short-term benefit is that it removes the list-as-map-key
(etc.) values from the "types" generated file and puts it into
the "constants" generated file.  This gets them out of the way
of the Python tests, so they pass again.

The long term benefit is that is strengthens the Java TCompactProtocol
test.  Before, it was reading the "full" CompactProtocolTestStruct into
a CompactProtocolTestStruct that was just constructed, but the latter
was already almost equal to the former.  This change makes it much
easier to create an empty CompactProtocolTestStruct to read the serialized
data into.


Changed paths

Path Details
Directoryincubator/thrift/trunk/lib/java/test/org/apache/thrift/test/Fixtures.java modified , text changed
Directoryincubator/thrift/trunk/test/DebugProtoTest.thrift modified , text changed

infrastructure at apache.org
ViewVC Help
Powered by ViewVC 1.1.26