/[Apache-SVN]
ViewVC logotype

Revision 665647


Jump to revision: Previous Next
Author: dreiss
Date: Tue Apr 8 06:25:45 2008 UTC (16 years, 7 months ago)
Changed paths: 1
Log Message:
use poll instead of select in TSocket

Summary: fd_set, which we pass into select only supports  fds with values < 1024.
         fds can be >= 1024.
         this can cause memory corruption

         learning this stuff over 2 weeks of examining crazy core dumps is way more fun that reading it up somewhere.

         poll takes an array of fds insetad, so your fd can be any int

Reviewed By: dreiss

Test Plan: ran inside a test search cluster

Revert: OK

DiffCamp Revision: 10731


Changed paths

Path Details
Directoryincubator/thrift/trunk/lib/cpp/src/transport/TSocket.cpp modified , text changed

infrastructure at apache.org
ViewVC Help
Powered by ViewVC 1.1.26