/[Apache-SVN]
ViewVC logotype

Revision 665487


Jump to revision: Previous Next
Author: dreiss
Date: Tue Feb 19 22:47:29 2008 UTC (16 years, 8 months ago)
Changed paths: 9
Log Message:
Thrift: Add "#include <cstdlib>" in a few places and s/malloc/std::malloc/

Summary:
There were a few places where we were calling malloc/reallaoc/free without
including cstdlib (or stdlib.h).  This is broken, but it worked because
other headers that we were including included stdlib.h.  However, on a
platform where this wasn't true, it broke the Thrift build.  This change
adds the proper includes.  It also changes malloc to std::malloc (same
with realloc and free) in a few places, because that is the correct way
of doing it when you include cstdlib.

Reviewed By: mcslee

Test Plan: Compiled Thrift.

Revert Plan: ok

Other Notes:
This bug was noticed by a Thrudb user, and the patch was sent in by
Ross McFarland.


Changed paths

Path Details
Directoryincubator/thrift/trunk/configure.ac modified , text changed
Directoryincubator/thrift/trunk/lib/cpp/src/protocol/TBinaryProtocol.cpp modified , text changed
Directoryincubator/thrift/trunk/lib/cpp/src/protocol/TBinaryProtocol.h modified , text changed
Directoryincubator/thrift/trunk/lib/cpp/src/server/TNonblockingServer.cpp modified , text changed
Directoryincubator/thrift/trunk/lib/cpp/src/server/TNonblockingServer.h modified , text changed
Directoryincubator/thrift/trunk/lib/cpp/src/transport/TFileTransport.cpp modified , text changed
Directoryincubator/thrift/trunk/lib/cpp/src/transport/THttpClient.cpp modified , text changed
Directoryincubator/thrift/trunk/lib/cpp/src/transport/TTransportUtils.cpp modified , text changed
Directoryincubator/thrift/trunk/lib/cpp/src/transport/TTransportUtils.h modified , text changed

infrastructure at apache.org
ViewVC Help
Powered by ViewVC 1.1.26