/[Apache-SVN]
ViewVC logotype

Revision 665328


Jump to revision: Previous Next
Author: mcslee
Date: Tue Nov 13 04:00:29 2007 UTC (16 years, 11 months ago)
Changed paths: 8
Log Message:
Thrift PHP generation Redux

Summary: Chopping the amount of code generated by Thrift for PHP services by two orders of magnitude (approx 25% of the previous size). This is done via putting more logic in a dynamic base class and taking it out of the generated code. Hopefully this wins back the CPU cycles paid just to load code from APC at the cost of a marginal increase in dynamic execution runtime.

Reviewed By: sgrimm, dreiss

Test Plan: Ran all the tests in trunk/test/php, also tested the API generate code and Falcon, etc. in my sandbox


Changed paths

Path Details
Directoryincubator/thrift/trunk/compiler/cpp/src/generate/t_php_generator.cc modified , text changed
Directoryincubator/thrift/trunk/compiler/cpp/src/generate/t_php_generator.h modified , text changed
Directoryincubator/thrift/trunk/compiler/cpp/src/main.cc modified , text changed
Directoryincubator/thrift/trunk/compiler/cpp/src/parse/t_base_type.h modified , text changed
Directoryincubator/thrift/trunk/compiler/cpp/src/parse/t_type.h modified , text changed
Directoryincubator/thrift/trunk/lib/php/src/Thrift.php modified , text changed
Directoryincubator/thrift/trunk/test/php/Makefile modified , text changed
Directoryincubator/thrift/trunk/test/php/TestClient.php modified , text changed

infrastructure at apache.org
ViewVC Help
Powered by ViewVC 1.1.26