/[Apache-SVN]
ViewVC logotype

Revision 665218


Jump to revision: Previous Next
Author: dreiss
Date: Thu Aug 23 02:37:19 2007 UTC (17 years, 2 months ago)
Changed paths: 3
Log Message:
Thrift: No using namespace.

Summary:
using namespace XXX; is tricky because it imports a lot of crap into your namespace.
Also, if we ever decide to remove boost as a dependency, "using namespace boost"
makes it harder.

This patch removes all using namesapce XXX; with one or more using XXX::YYY;
There are some exceptions, such as test, tutorial, namespace std, and
facebook namespaces.

Reviewed By: mcslee

Test Plan:
Recompiled thrift.
grep --binary-files=without-match -r 'using namespace' . | \
  egrep -v '^[^:]*: *using namespace (std;$|facebook)' | \
  grep -v '<< endl' | \
  grep -v '[^:]*/tutorial/' | \
  grep -v '^./test/'

Revert Plan: ok

Notes: I wouldn't bother, but it is fixathon.


Changed paths

Path Details
Directoryincubator/thrift/trunk/lib/cpp/src/concurrency/PosixThreadFactory.cpp modified , text changed
Directoryincubator/thrift/trunk/lib/cpp/src/concurrency/ThreadManager.cpp modified , text changed
Directoryincubator/thrift/trunk/lib/cpp/src/transport/TServerSocket.cpp modified , text changed

infrastructure at apache.org
ViewVC Help
Powered by ViewVC 1.1.26