/[Apache-SVN]
ViewVC logotype

Revision 665201


Jump to revision: Previous Next
Author: dreiss
Date: Tue Aug 14 17:12:33 2007 UTC (17 years, 2 months ago)
Changed paths: 7
Log Message:
Thrift: docstring revamp step 2.

Summary:
It was a bad idea to let doxygen comments become a part of the parse tree.
We now get them a totally different way.  The lexer stashes the docsting
contents in a global, and the parser actions (not the rules) pull it out.
This should prevent doxygen comments from ever causing parse errors.

Blame Rev: 52678, 52732

Reviewed By: mcslee

Test Plan:
Recompiled thrift.
Thrifted a bunch of files and saw no parse errors (or C++ compile errors).
Thrifted DocTest.thrift with dump_docs on.

Revert Plan: ok


Changed paths

Path Details
Directoryincubator/thrift/trunk/compiler/cpp/Makefile.am modified , text changed
Directoryincubator/thrift/trunk/compiler/cpp/src/globals.h modified , text changed
Directoryincubator/thrift/trunk/compiler/cpp/src/main.cc modified , text changed
Directoryincubator/thrift/trunk/compiler/cpp/src/main.h modified , text changed
Directoryincubator/thrift/trunk/compiler/cpp/src/thriftl.ll modified , text changed
Directoryincubator/thrift/trunk/compiler/cpp/src/thrifty.yy modified , text changed
Directoryincubator/thrift/trunk/test/DocTest.thrift modified , text changed

infrastructure at apache.org
ViewVC Help
Powered by ViewVC 1.1.26