/[Apache-SVN]
ViewVC logotype

Revision 1285999


Jump to revision: Previous Next
Author: (unknown author)
Date: Wed Feb 1 16:28:00 2012 UTC (12 years, 2 months ago)
Changed paths: 1
Log Message:
Transferred from the Adobe Open Source Subversion Repository

Revision: 14963
Author:   jszeto@adobe.com
Date:     2010-03-23T21:34:04.235844Z

Log Message: 
-----------
Merging revisions 14946 and 14947 from 4.x to trunk

Mirroring code hinting fixes

http://bugs.adobe.com/jira/browse/SDK-25565 - Components should define [Style] metadata for  layoutDirection and direction styles

There is both a style and property called layoutDirection in UIComponent. For UIComponent, both Hans and I agree that we should promote the use of the style. I added an exclude for the layoutDirection property in UIComponent. This allows code hinting for the layoutDirection style in the CSS style declaration. It also removes the layoutDirection property from the ASDoc. Code hinting still works for the layoutDirection attribute on a UIComponent subclass MXML tag. This attribute gets set to the property, not the style. 

ProgressBar has both a direction property and style. However, in this situation, they control different behaviors. It is not possible to code hint for the direction style in the CSS style declaration without removing the direction property from ASDoc. We are just going to have to live with this limitation. 

http://bugs.adobe.com/jira/browse/SDK-25823 - The layoutDirection style/property doesnt code hint static enums

Added Inspectable metadata to BitmapAsset, SpriteAsset, SpriteVisualElement and GraphicElement.

QE notes: test code hinting for layoutDirection
Doc notes: none
Bugs: SDK-25565, SDK-25823
Reviewer: Carol, Hans
Tests run: checkintests, Mirroring
Is noteworthy for integration: no

ColorPicker and PopUpButton mirroring bug fix

http://bugs.adobe.com/jira/browse/SDK-25916 - color/label field in swatch panel isn't updated when layoutDirection is 
changed between rtl and ltr

Since the ColorPicker's SwatchPanel is parented by the SystemManager it wasn't inheriting the layoutDirection and it wasn't invalidating the layoutDirection. The fix is to pass the layoutDirection to the SwatchPanel and always call invalidateLayoutDirection in PopUpManager.addPopUp. 

http://bugs.adobe.com/jira/browse/SDK-25828 - initial popup starts with wrong position, not aligned with PopupButton when there is padding set on container

The popup is not guaranteed to know its size until it has been added as a popup. Moved the position logic to after the popup has been added. 


QE notes: test mirrored ColorPicker and PopUpButton
Doc notes: none
Bugs: SDK-25916
Reviewer: Carol
Tests run: checkintests, ColorPicker, PopUpButton
Is noteworthy for integration: no

Modified Paths:
--------------
<path kind="file" action="M">/flex/sdk/trunk/frameworks/projects/spark/src/spark/core/SpriteVisualElement.as</path>
<path kind="file" action="M">/flex/sdk/trunk/frameworks/projects/spark/src/spark/primitives/supportClasses/GraphicElement.as</path>
<path kind="dir" action="M">/flex/sdk/trunk</path>
<path kind="file" action="M">/flex/sdk/trunk/frameworks/projects/framework/src/mx/managers/PopUpManagerImpl.as</path>
<path kind="file" action="M">/flex/sdk/trunk/frameworks/projects/framework/src/mx/core/SpriteAsset.as</path>
<path kind="file" action="M">/flex/sdk/trunk/frameworks/projects/framework/src/mx/controls/ColorPicker.as</path>
<path kind="file" action="M">/flex/sdk/trunk/frameworks/projects/framework/src/mx/controls/PopUpButton.as</path>
<path kind="file" action="M">/flex/sdk/trunk/frameworks/projects/framework/src/mx/core/BitmapAsset.as</path>
<path kind="file" action="M">/flex/sdk/trunk/frameworks/projects/framework/src/mx/core/UIComponent.as</path>

Changed paths

Path Details
Directoryincubator/flex/trunk/frameworks/projects/spark/src/spark/primitives/supportClasses/GraphicElement.as modified , text changed

infrastructure at apache.org
ViewVC Help
Powered by ViewVC 1.1.26