/[Apache-SVN]
ViewVC logotype

Revision 1262341


Jump to revision: Previous Next
Author: (unknown author)
Date: Mon Jan 30 17:45:22 2012 UTC (12 years, 2 months ago)
Changed paths: 1
Log Message:
Transferred from the Adobe Open Source Subversion Repository

Revision: 17202
Author:   preilly@adobe.com
Date:     2010-08-05T16:37:47.464645Z

Log Message: 
-----------
* Fix for SDK-24948 and some general Vector fixes.

QE notes: We need some new tests to cover the new code in AddItems.as.
Doc notes: 
Bugs: SDK-24948
Reviewer: Corey
Tests run: full cyclone
Is noteworthy for integration: NO
Code-level description of changes:

  frameworks/projects/framework/src/mx/states/AddItems.as

    Added vectorClass variable and addItemsToVector() function.

    Modified apply() use addItemsToVector() for vectors.

    Modified remove() to handle vectors.

    Renamed assignArray() to assign() to reflect it's new additional
    usage for Vectors.

  modules/compiler/src/java/flex2/compiler/SymbolTable.java

    Modified getClass() to no longer handle vectors differently.  It's
    handling wasn't correct and the correct handling lives elsewhere.

  modules/compiler/src/java/flex2/compiler/mxml/lang/NodeTypeResolver.java

    Modified vectorNode() to lookup the actual vector type.

  modules/compiler/src/java/flex2/compiler/mxml/lang/TypeCompatibility.java

    Modified check() to handle vectors correctly.

  modules/compiler/src/java/flex2/compiler/mxml/reflect/TypeTable.java

    Modified getType() by improving and adding asserts.

    Modified getVectorType() by fixing a typo and adding an assert.

    Modified getElementType() by checking the base type for an element
    type first.

  modules/compiler/src/java/flex2/compiler/mxml/rep/MxmlDocument.java
  modules/compiler/src/java/flex2/compiler/mxml/builder/DocumentBuilder.java
  modules/compiler/src/java/flex2/compiler/mxml/gen/ClassDefLib.vm
  modules/compiler/src/java/flex2/compiler/mxml/ImplementationGenerator.java

    Updated to reflect changes to BindingExpression.getDestinationTypeName().

  modules/compiler/src/java/flex2/compiler/mxml/rep/StatesModel.java

    Added VECTORCLASS constant.

    Modified most checks for an Array based context to also check for
    a Vector by looking for a non-null element type.

    Modified AddItemsOverride() by adding a vectorClassName variable
    and adding it to the generated code when non-null.

  modules/compiler/src/java/flex2/compiler/mxml/rep/DocumentInfo.java

    Modified addImportName() to handle vectors, so BindingExpression
    no longer has to.

  modules/compiler/src/java/flex2/compiler/mxml/rep/BindingExpression.java

    Modified getDestinationTypeName() to no longer handle vectors.

  modules/compiler/src/java/flex2/compiler/mxml/builder/VectorBuilder.java

    Modified processTextInitializer() to use the correct vector type.

  modules/compiler/src/java/flex2/compiler/mxml/builder/AbstractBuilder.java
  modules/compiler/src/java/flex2/compiler/mxml/builder/ArrayBuilder.java

    Modified vectorNode() to correctly format vector element types in
    a package.

  modules/compiler/src/java/flex2/compiler/util/NameFormatter.java

    Modified toColon() and retrieveClassName() to correctly handle
    vector class names.

Modified Paths:
--------------
<path kind="file" action="M">/private/flex/sdk/branches/hero_private/modules/compiler/src/java/flex2/compiler/mxml/rep/StatesModel.java</path>
<path kind="file" action="M">/private/flex/sdk/branches/hero_private/modules/compiler/src/java/flex2/compiler/mxml/builder/DocumentBuilder.java</path>
<path kind="file" action="M">/private/flex/sdk/branches/hero_private/modules/compiler/src/java/flex2/compiler/mxml/builder/ArrayBuilder.java</path>
<path kind="file" action="M">/private/flex/sdk/branches/hero_private/modules/compiler/src/java/flex2/compiler/mxml/reflect/TypeTable.java</path>
<path kind="file" action="M">/private/flex/sdk/branches/hero_private/modules/compiler/src/java/flex2/compiler/mxml/rep/DocumentInfo.java</path>
<path kind="file" action="M">/private/flex/sdk/branches/hero_private/modules/compiler/src/java/flex2/compiler/mxml/rep/BindingExpression.java</path>
<path kind="file" action="M">/private/flex/sdk/branches/hero_private/modules/compiler/src/java/flex2/compiler/mxml/gen/ClassDefLib.vm</path>
<path kind="file" action="M">/private/flex/sdk/branches/hero_private/modules/compiler/src/java/flex2/compiler/mxml/lang/NodeTypeResolver.java</path>
<path kind="file" action="M">/private/flex/sdk/branches/hero_private/modules/compiler/src/java/flex2/compiler/mxml/lang/TypeCompatibility.java</path>
<path kind="file" action="M">/private/flex/sdk/branches/hero_private/modules/compiler/src/java/flex2/compiler/mxml/ImplementationGenerator.java</path>
<path kind="file" action="M">/private/flex/sdk/branches/hero_private/modules/compiler/src/java/flex2/compiler/mxml/builder/VectorBuilder.java</path>
<path kind="file" action="M">/private/flex/sdk/branches/hero_private/frameworks/projects/framework/src/mx/states/AddItems.as</path>
<path kind="file" action="M">/private/flex/sdk/branches/hero_private/modules/compiler/src/java/flex2/compiler/mxml/builder/AbstractBuilder.java</path>
<path kind="file" action="M">/private/flex/sdk/branches/hero_private/modules/compiler/src/java/flex2/compiler/SymbolTable.java</path>
<path kind="file" action="M">/private/flex/sdk/branches/hero_private/modules/compiler/src/java/flex2/compiler/mxml/rep/MxmlDocument.java</path>
<path kind="file" action="M">/private/flex/sdk/branches/hero_private/modules/compiler/src/java/flex2/compiler/util/NameFormatter.java</path>

Changed paths

Path Details
Directoryincubator/flex/trunk/frameworks/projects/framework/src/mx/states/AddItems.as modified , text changed

infrastructure at apache.org
ViewVC Help
Powered by ViewVC 1.1.26