/[Apache-SVN]
ViewVC logotype

Revision 1214011


Jump to revision: Previous Next
Author: jvs
Date: Wed Dec 14 00:59:16 2011 UTC (12 years, 4 months ago)
Changed paths: 886 (showing only 100; show all)
Log Message:
HIVE-1040 [jira] use sed rather than diff for masking out noise in diff-based
tests
(Marek Sapota via John Sichi)

Summary:
Replace diff -I with regex masking in Java

The current diff -I approach has two problems:  (1) it does not allow resolution
finer than line-level, so it's impossible to mask out pattern occurrences within
a line, and (2) it produces unmasked files, so if you run diff on the command
line to compare the result .q.out with the checked-in file, you see the noise.

My suggestion is to first run sed to replace noise patterns with an
unlikely-to-occur string like ZYZZYZVA, and then diff the pre-masked files
without using any -I.

This would require a one-time hit to update all existing .q.out files so that
they would contain the pre-masked results.

Test Plan: EMPTY

Reviewers: JIRA, jsichi

Reviewed By: jsichi

CC: jsichi

Differential Revision: 597



Changed paths

Path Details
Directoryhive/trunk/contrib/src/test/results/clientnegative/case_with_row_sequence.q.out modified , text changed
Directoryhive/trunk/contrib/src/test/results/clientnegative/serde_regex.q.out modified , text changed
Directoryhive/trunk/contrib/src/test/results/clientpositive/dboutput.q.out modified , text changed
Directoryhive/trunk/contrib/src/test/results/clientpositive/fileformat_base64.q.out modified , text changed
Directoryhive/trunk/contrib/src/test/results/clientpositive/java_mr_example.q.out modified , text changed
Directoryhive/trunk/contrib/src/test/results/clientpositive/lateral_view_explode2.q.out modified , text changed
Directoryhive/trunk/contrib/src/test/results/clientpositive/serde_regex.q.out modified , text changed
Directoryhive/trunk/contrib/src/test/results/clientpositive/serde_s3.q.out modified , text changed
Directoryhive/trunk/contrib/src/test/results/clientpositive/serde_typedbytes.q.out modified , text changed
Directoryhive/trunk/contrib/src/test/results/clientpositive/serde_typedbytes2.q.out modified , text changed
Directoryhive/trunk/contrib/src/test/results/clientpositive/serde_typedbytes3.q.out modified , text changed
Directoryhive/trunk/contrib/src/test/results/clientpositive/serde_typedbytes4.q.out modified , text changed
Directoryhive/trunk/contrib/src/test/results/clientpositive/serde_typedbytes5.q.out modified , text changed
Directoryhive/trunk/contrib/src/test/results/clientpositive/serde_typedbytes_null.q.out modified , text changed
Directoryhive/trunk/contrib/src/test/results/clientpositive/udaf_example_avg.q.out modified , text changed
Directoryhive/trunk/contrib/src/test/results/clientpositive/udaf_example_group_concat.q.out modified , text changed
Directoryhive/trunk/contrib/src/test/results/clientpositive/udaf_example_max.q.out modified , text changed
Directoryhive/trunk/contrib/src/test/results/clientpositive/udaf_example_max_n.q.out modified , text changed
Directoryhive/trunk/contrib/src/test/results/clientpositive/udaf_example_min.q.out modified , text changed
Directoryhive/trunk/contrib/src/test/results/clientpositive/udaf_example_min_n.q.out modified , text changed
Directoryhive/trunk/contrib/src/test/results/clientpositive/udf_example_add.q.out modified , text changed
Directoryhive/trunk/contrib/src/test/results/clientpositive/udf_example_arraymapstruct.q.out modified , text changed
Directoryhive/trunk/contrib/src/test/results/clientpositive/udf_example_format.q.out modified , text changed
Directoryhive/trunk/contrib/src/test/results/clientpositive/udf_row_sequence.q.out modified , text changed
Directoryhive/trunk/contrib/src/test/results/clientpositive/udtf_explode2.q.out modified , text changed
Directoryhive/trunk/contrib/src/test/results/clientpositive/udtf_output_on_close.q.out modified , text changed
Directoryhive/trunk/hbase-handler/src/test/results/hbase_bulk.m.out modified , text changed
Directoryhive/trunk/hbase-handler/src/test/results/hbase_joins.q.out modified , text changed
Directoryhive/trunk/hbase-handler/src/test/results/hbase_pushdown.q.out modified , text changed
Directoryhive/trunk/hbase-handler/src/test/results/hbase_queries.q.out modified , text changed
Directoryhive/trunk/hbase-handler/src/test/results/hbase_stats.q.out modified , text changed
Directoryhive/trunk/hbase-handler/src/test/results/hbase_stats2.q.out modified , text changed
Directoryhive/trunk/ql/src/test/org/apache/hadoop/hive/ql/QTestUtil.java modified , text changed
Directoryhive/trunk/ql/src/test/results/clientnegative/alter_concatenate_indexed_table.q.out modified , text changed
Directoryhive/trunk/ql/src/test/results/clientnegative/alter_view_failure.q.out modified , text changed
Directoryhive/trunk/ql/src/test/results/clientnegative/alter_view_failure2.q.out modified , text changed
Directoryhive/trunk/ql/src/test/results/clientnegative/alter_view_failure4.q.out modified , text changed
Directoryhive/trunk/ql/src/test/results/clientnegative/alter_view_failure5.q.out modified , text changed
Directoryhive/trunk/ql/src/test/results/clientnegative/alter_view_failure6.q.out modified , text changed
Directoryhive/trunk/ql/src/test/results/clientnegative/alter_view_failure7.q.out modified , text changed
Directoryhive/trunk/ql/src/test/results/clientnegative/alter_view_failure9.q.out modified , text changed
Directoryhive/trunk/ql/src/test/results/clientnegative/analyze_view.q.out modified , text changed
Directoryhive/trunk/ql/src/test/results/clientnegative/archive_multi7.q.out modified , text changed
Directoryhive/trunk/ql/src/test/results/clientnegative/authorization_fail_1.q.out modified , text changed
Directoryhive/trunk/ql/src/test/results/clientnegative/authorization_fail_3.q.out modified , text changed
Directoryhive/trunk/ql/src/test/results/clientnegative/authorization_fail_4.q.out modified , text changed
Directoryhive/trunk/ql/src/test/results/clientnegative/authorization_fail_5.q.out modified , text changed
Directoryhive/trunk/ql/src/test/results/clientnegative/authorization_fail_7.q.out modified , text changed
Directoryhive/trunk/ql/src/test/results/clientnegative/authorization_part.q.out modified , text changed
Directoryhive/trunk/ql/src/test/results/clientnegative/autolocal1.q.out modified , text changed
Directoryhive/trunk/ql/src/test/results/clientnegative/bad_exec_hooks.q.out modified , text changed
Directoryhive/trunk/ql/src/test/results/clientnegative/create_or_replace_view1.q.out modified , text changed
Directoryhive/trunk/ql/src/test/results/clientnegative/create_or_replace_view2.q.out modified , text changed
Directoryhive/trunk/ql/src/test/results/clientnegative/create_or_replace_view3.q.out modified , text changed
Directoryhive/trunk/ql/src/test/results/clientnegative/create_or_replace_view4.q.out modified , text changed
Directoryhive/trunk/ql/src/test/results/clientnegative/create_or_replace_view5.q.out modified , text changed
Directoryhive/trunk/ql/src/test/results/clientnegative/create_or_replace_view6.q.out modified , text changed
Directoryhive/trunk/ql/src/test/results/clientnegative/create_or_replace_view7.q.out modified , text changed
Directoryhive/trunk/ql/src/test/results/clientnegative/create_or_replace_view8.q.out modified , text changed
Directoryhive/trunk/ql/src/test/results/clientnegative/create_view_failure1.q.out modified , text changed
Directoryhive/trunk/ql/src/test/results/clientnegative/create_view_failure2.q.out modified , text changed
Directoryhive/trunk/ql/src/test/results/clientnegative/create_view_failure4.q.out modified , text changed
Directoryhive/trunk/ql/src/test/results/clientnegative/describe_xpath1.q.out modified , text changed
Directoryhive/trunk/ql/src/test/results/clientnegative/describe_xpath2.q.out modified , text changed
Directoryhive/trunk/ql/src/test/results/clientnegative/drop_table_failure2.q.out modified , text changed
Directoryhive/trunk/ql/src/test/results/clientnegative/duplicate_insert3.q.out modified , text changed
Directoryhive/trunk/ql/src/test/results/clientnegative/dyn_part3.q.out modified , text changed
Directoryhive/trunk/ql/src/test/results/clientnegative/exim_01_nonpart_over_loaded.q.out modified , text changed
Directoryhive/trunk/ql/src/test/results/clientnegative/exim_02_all_part_over_overlap.q.out modified , text changed
Directoryhive/trunk/ql/src/test/results/clientnegative/exim_03_nonpart_noncompat_colschema.q.out modified , text changed
Directoryhive/trunk/ql/src/test/results/clientnegative/exim_04_nonpart_noncompat_colnumber.q.out modified , text changed
Directoryhive/trunk/ql/src/test/results/clientnegative/exim_05_nonpart_noncompat_coltype.q.out modified , text changed
Directoryhive/trunk/ql/src/test/results/clientnegative/exim_06_nonpart_noncompat_storage.q.out modified , text changed
Directoryhive/trunk/ql/src/test/results/clientnegative/exim_07_nonpart_noncompat_ifof.q.out modified , text changed
Directoryhive/trunk/ql/src/test/results/clientnegative/exim_08_nonpart_noncompat_serde.q.out modified , text changed
Directoryhive/trunk/ql/src/test/results/clientnegative/exim_09_nonpart_noncompat_serdeparam.q.out modified , text changed
Directoryhive/trunk/ql/src/test/results/clientnegative/exim_10_nonpart_noncompat_bucketing.q.out modified , text changed
Directoryhive/trunk/ql/src/test/results/clientnegative/exim_11_nonpart_noncompat_sorting.q.out modified , text changed
Directoryhive/trunk/ql/src/test/results/clientnegative/exim_13_nonnative_import.q.out modified , text changed
Directoryhive/trunk/ql/src/test/results/clientnegative/exim_14_nonpart_part.q.out modified , text changed
Directoryhive/trunk/ql/src/test/results/clientnegative/exim_15_part_nonpart.q.out modified , text changed
Directoryhive/trunk/ql/src/test/results/clientnegative/exim_16_part_noncompat_schema.q.out modified , text changed
Directoryhive/trunk/ql/src/test/results/clientnegative/exim_17_part_spec_underspec.q.out modified , text changed
Directoryhive/trunk/ql/src/test/results/clientnegative/exim_18_part_spec_missing.q.out modified , text changed
Directoryhive/trunk/ql/src/test/results/clientnegative/exim_19_external_over_existing.q.out modified , text changed
Directoryhive/trunk/ql/src/test/results/clientnegative/exim_20_managed_location_over_existing.q.out modified , text changed
Directoryhive/trunk/ql/src/test/results/clientnegative/exim_21_part_managed_external.q.out modified , text changed
Directoryhive/trunk/ql/src/test/results/clientnegative/exim_23_import_exist_authfail.q.out modified , text changed
Directoryhive/trunk/ql/src/test/results/clientnegative/exim_24_import_part_authfail.q.out modified , text changed
Directoryhive/trunk/ql/src/test/results/clientnegative/exim_25_import_nonexist_authfail.q.out modified , text changed
Directoryhive/trunk/ql/src/test/results/clientnegative/external1.q.out modified , text changed
Directoryhive/trunk/ql/src/test/results/clientnegative/external2.q.out modified , text changed
Directoryhive/trunk/ql/src/test/results/clientnegative/fetchtask_ioexception.q.out modified , text changed
Directoryhive/trunk/ql/src/test/results/clientnegative/fs_default_name1.q.out modified , text changed
Directoryhive/trunk/ql/src/test/results/clientnegative/fs_default_name2.q.out modified , text changed
Directoryhive/trunk/ql/src/test/results/clientnegative/index_compact_entry_limit.q.out modified , text changed
Directoryhive/trunk/ql/src/test/results/clientnegative/index_compact_size_limit.q.out modified , text changed
Directoryhive/trunk/ql/src/test/results/clientnegative/insert_view_failure.q.out modified , text changed
Directoryhive/trunk/ql/src/test/results/clientnegative/invalidate_view1.q.out modified , text changed
Directoryhive/trunk/ql/src/test/results/clientnegative/load_view_failure.q.out modified , text changed
[...]

infrastructure at apache.org
ViewVC Help
Powered by ViewVC 1.1.26