/[Apache-SVN]
ViewVC logotype

Revision 1311167


Jump to revision: Previous Next
Author: mbautin
Date: Mon Apr 9 09:00:11 2012 UTC (12 years, 7 months ago)
Changed paths: 3
Log Message:
[jira] [HBASE-5744] Thrift server metrics should be long instead of int

Summary:
As we measure our Thrift call latencies in nanoseconds, we need to make
latencies long instead of int everywhere. There is a bug where we truncate a
nanosecond latency to int, which is a problem with RPCs that take more than
2.147483647 seconds to process.

This is a trunk diff. The 89-fb version of this diff is at D2679.

Test Plan:
TestThriftServer is updated to test for the failure case (an RPC is artificially
made to take 3 seconds). The new test case fails without the fix.

Re-run all unit tests.

Reviewers: stack, sc, Kannan, JIRA

Reviewed By: sc

Differential Revision: https://reviews.facebook.net/D2685



Changed paths

Path Details
Directoryhbase/trunk/src/main/java/org/apache/hadoop/hbase/thrift/HbaseHandlerMetricsProxy.java modified , text changed
Directoryhbase/trunk/src/main/java/org/apache/hadoop/hbase/thrift/ThriftMetrics.java modified , text changed
Directoryhbase/trunk/src/test/java/org/apache/hadoop/hbase/thrift/TestThriftServer.java modified , text changed

infrastructure at apache.org
ViewVC Help
Powered by ViewVC 1.1.26