/[Apache-SVN]
ViewVC logotype

Revision 1243667


Jump to revision: Previous Next
Author: mbautin
Date: Mon Feb 13 19:41:58 2012 UTC (12 years, 9 months ago)
Changed paths: 4
Log Message:
[jira] [HBASE-5387] Reuse compression streams in HFileBlock.Writer

Summary: We need to to reuse compression streams in HFileBlock.Writer instead of
allocating them every time. The motivation is that when using Java's built-in
implementation of Gzip, we allocate a new GZIPOutputStream object and an
associated native data structure any time. This is one suspected cause of recent
TestHFileBlock failures on Hadoop QA:
https://builds.apache.org/job/HBase-TRUNK/2658/testReport/org.apache.hadoop.hbase.io.hfile/TestHFileBlock/testPreviousOffset_1_/.

Test Plan:
* Run unit tests
* Create a GZIP-compressed CF with new code, load some data, shut down HBase,
deploy old code, restart HBase, and scan the table

Reviewers: tedyu, Liyin, dhruba, JIRA, lhofhansl

Reviewed By: lhofhansl

CC: tedyu, lhofhansl, mbautin

Differential Revision: https://reviews.facebook.net/D1719

Changed paths

Path Details
Directoryhbase/trunk/src/main/java/org/apache/hadoop/hbase/io/hfile/Compression.java modified , text changed
Directoryhbase/trunk/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileBlock.java modified , text changed
Directoryhbase/trunk/src/main/java/org/apache/hadoop/hbase/io/hfile/ReusableStreamGzipCodec.java added
Directoryhbase/trunk/src/test/java/org/apache/hadoop/hbase/io/hfile/TestHFileBlock.java modified , text changed

infrastructure at apache.org
ViewVC Help
Powered by ViewVC 1.1.26