/[Apache-SVN]
ViewVC logotype

Revision 652587


Jump to revision: Previous Next
Author: jimk
Date: Thu May 1 17:37:24 2008 UTC (16 years, 5 months ago)
Changed paths: 5
Log Message:
HBASE-607 MultiRegionTable.makeMultiRegionTable is not deterministic enough for regression tests

M MultiRegionTable

  Make deterministic by creating the regions directly and not rely on
  the asychronous nature of cache flushes, compactions and splits. The
  regions are small, but the point of this class is to generate a
  table with multiple regions so we can test map / reduce, region
  onlining / offlining, etc.

  Removed PUNCTUATION from row keys. Not sure why it was there in the
  first place, other than perhaps to verify that a row key can have
  punctuation in it provided it is not the first character. This will
  become moot when row keys change from Text to byte[] anyways.

  Incorporate repeated code
{code}
    region.close();
    region.getLog().closeAndDelete();
{code}
  into private method closeRegionAndDeleteLog

M TestSplit

  extends HBaseClusterTestCase instead of MultiRegionTable. It didn't
  use the output of MultiRegionTable, so all that work was just wasted
  by this test.

M TestTableIndex, TestTableMapReduce

  The only two tests that currently use MultiRegionTable. Minor
  modifications needed because MultiRegionTable now handles starting
  and stopping of the mini-DFS cluster. With the new MultiRegionTable
  class, if these tests fail now it will be because something they are
  testing has regressed and not because MultiRegionTable failed.



Changed paths

Path Details
Directoryhadoop/hbase/trunk/CHANGES.txt modified , text changed
Directoryhadoop/hbase/trunk/src/test/org/apache/hadoop/hbase/MultiRegionTable.java modified , text changed
Directoryhadoop/hbase/trunk/src/test/org/apache/hadoop/hbase/mapred/TestTableIndex.java modified , text changed
Directoryhadoop/hbase/trunk/src/test/org/apache/hadoop/hbase/mapred/TestTableMapReduce.java modified , text changed
Directoryhadoop/hbase/trunk/src/test/org/apache/hadoop/hbase/regionserver/TestSplit.java modified , text changed

infrastructure at apache.org
ViewVC Help
Powered by ViewVC 1.1.26