/[Apache-SVN]
ViewVC logotype

Revision 1724802


Jump to revision: Previous Next
Author: jawi
Date: Fri Jan 15 13:34:41 2016 UTC (8 years, 10 months ago)
Changed paths: 10
Log Message:
Code review:

- cleaned up the code to use more recent Java constructs, such as foreach
  loops;
- cleaned up the test cases to make them a bit more readable and easier to
  maintain by folding some duplicate code into helper methods;
- fixed a corner case in which an AutoConf resource drops a configuration while
  updating existing ones at the same time. A NPE could be thrown in this
  situation due ConfigurationAdmin not being present;
- fixed a corner case in which a resource is dropped twice. A IOException could
  be thrown;
- moved some really specific MetaType code to a utility class;
- added some test cases for PersistencyManager;
- applied the code formatting guidelines for Apache Felix.



Changed paths

Path Details
Directoryfelix/trunk/deploymentadmin/autoconf/pom.xml modified , text changed
Directoryfelix/trunk/deploymentadmin/autoconf/src/main/java/org/apache/felix/deployment/rp/autoconf/Activator.java modified , text changed
Directoryfelix/trunk/deploymentadmin/autoconf/src/main/java/org/apache/felix/deployment/rp/autoconf/AutoConfResource.java modified , text changed
Directoryfelix/trunk/deploymentadmin/autoconf/src/main/java/org/apache/felix/deployment/rp/autoconf/AutoConfResourceProcessor.java modified , text changed
Directoryfelix/trunk/deploymentadmin/autoconf/src/main/java/org/apache/felix/deployment/rp/autoconf/MetaTypeUtil.java added
Directoryfelix/trunk/deploymentadmin/autoconf/src/main/java/org/apache/felix/deployment/rp/autoconf/PersistencyManager.java modified , text changed
Directoryfelix/trunk/deploymentadmin/autoconf/src/test/java/org/apache/felix/deployment/rp/autoconf/AutoConfResourceProcessorTest.java modified , text changed
Directoryfelix/trunk/deploymentadmin/autoconf/src/test/java/org/apache/felix/deployment/rp/autoconf/DefaultNullObject.java modified , text changed
Directoryfelix/trunk/deploymentadmin/autoconf/src/test/java/org/apache/felix/deployment/rp/autoconf/PersistencyManagerTest.java added
Directoryfelix/trunk/deploymentadmin/autoconf/src/test/java/org/apache/felix/deployment/rp/autoconf/Utils.java modified , text changed

infrastructure at apache.org
ViewVC Help
Powered by ViewVC 1.1.26