/[Apache-SVN]
ViewVC logotype

Revision 835281


Jump to revision: Previous Next
Author: davisp
Date: Thu Nov 12 07:35:38 2009 UTC (14 years, 5 months ago)
Changed paths: 3
Log Message:
Fixes COUCHDB-567 error with ErlView reduces.

Apparently we never tested ErlView reductions on 0.10.x? As far as I can tell   they never should have worked. It was exactly as Sean Geoghegan described in    that the interleaved calls to reduce where trouncing the mapper state.

Trunk uses the two process update scheme so wouldn't be affected by this        trouncing. This patch is a stop gap to make ErlViews work. I've tested with the Futon test patch and an updated query_server_spec.rb to revalidate things are working.

Fixing this bug has made it quite apparent that the query server specs need to be drastically rethought. I spent quite a bit of time tracking down that the specs were actually testing that the subprocess died. ErlViews causing the host process to die would be very bad. In the future I'd like to see script/response sets and file stuctures for function definitions.



Changed paths

Path Details
Directorycouchdb/branches/0.10.x/share/www/script/test/erlang_views.js modified , text changed
Directorycouchdb/branches/0.10.x/src/couchdb/couch_native_process.erl modified , text changed
Directorycouchdb/branches/0.10.x/test/query_server_spec.rb modified , text changed

infrastructure at apache.org
ViewVC Help
Powered by ViewVC 1.1.26