/[Apache-SVN]
ViewVC logotype

Revision 1651575


Jump to revision: Previous Next
Author: krosenvold
Date: Wed Jan 14 07:06:22 2015 UTC (9 years, 8 months ago)
Changed paths: 4
Log Message:
Added ZipArchiveEntryRequest class

ZipArchiveEntry is not thread safe, and the hand-off between the creating thread
and the executorService actually doing the compression has been somewhat of a
tightrope-walking effort, since we cannot reliably read fields off the ZipArchiveEntry

Furthermore, to achieve true maximum IO performance in the gather-phase it would
be required that Zip headers be created in the parallel part of the compression run,
which was not possible prior to this commit.

The ZipArchiveEntryRequest has clear and well-defined thread semantics and can cater
for any future algorithmic improvements that may want to try to take performance to the
very edge of what is achievable. To my understanding this will not be for this next
relasease :)

Changed paths

Path Details
Directorycommons/proper/compress/trunk/src/main/java/org/apache/commons/compress/archivers/zip/ParallelScatterZipCreator.java modified , text changed
Directorycommons/proper/compress/trunk/src/main/java/org/apache/commons/compress/archivers/zip/ScatterZipOutputStream.java modified , text changed
Directorycommons/proper/compress/trunk/src/main/java/org/apache/commons/compress/archivers/zip/ZipArchiveEntryRequest.java added
Directorycommons/proper/compress/trunk/src/test/java/org/apache/commons/compress/archivers/zip/ScatterZipOutputStreamTest.java modified , text changed

infrastructure at apache.org
ViewVC Help
Powered by ViewVC 1.1.26