/[Apache-SVN]
ViewVC logotype

Revision 1917864


Jump to revision: Previous Next
Author: hartmannathan
Date: Tue May 21 18:59:53 2024 UTC (2 months ago)
Changed paths: 2
Log Message:
Fix cmdline parsing bug: check the change argument for a double minus.

If the changeno is negative and is_negative is TRUE, raise
SVN_ERR_CL_ARG_PARSING_ERROR, because string with a double minus is
not a valid number. Do the same if the changeno_end is negative.

* subversion/svn/svn.c
  (sub_main): If the changeno is negative and is_negative is TRUE, raise
  SVN_ERR_CL_ARG_PARSING_ERROR. Do the same if the changeno_end is
  negative.

* subversion/tests/cmdline/diff_tests.py
  (diff_invalid_change_arg): New test.
  (test_list): Run new test.

See the dev@ mail list thread started 19 May 2024:
"[PATCH] Check the change argument for a double minus at the start."
archived here and elsewhere:
https://lists.apache.org/thread/tbld0locs0t3pq1hxzh2q1hqvx85l6gp

Patch by: Timofey Zhakov (tima {at} chemodax _dot_ net)

Review by: hartmannathan
           jun66j5


Changed paths

Path Details
Directorysubversion/trunk/subversion/svn/svn.c modified , text changed
Directorysubversion/trunk/subversion/tests/cmdline/diff_tests.py modified , text changed

infrastructure at apache.org
ViewVC Help
Powered by ViewVC 1.1.26