/[Apache-SVN]
ViewVC logotype

Revision 1874093


Jump to revision: Previous Next
Author: jamessan
Date: Mon Feb 17 02:13:34 2020 UTC (4 years, 2 months ago)
Changed paths: 2
Log Message:
Followup to r1874057, escape whitespace instead of quoting filename

As danielsh pointed out, only specific characters can be escaped by a backslash
in quoted shell strings.  Rather than surrounding the escaped path with double
quotes, post-process the quoted path and manually escape any whitespace that is
present.

* subversion/libsvn_subr/cmdline.c
  (escape_path): New function, wrapper around apr_pescape_shell(), which
   handles escaping of whitespace.
  (svn_cmdline__edit_file_externally, svn_cmdline__edit_string_externally):
   Call the new function instead of apr_pescape_shell()
* subversion/tests/cmdline/update_tests.py
  (update_accept_conflicts): Include ';' in renamed path ("p; i"), to ensure
   non-whitespace escaping is handled correctly.


Changed paths

Path Details
Directorysubversion/trunk/subversion/libsvn_subr/cmdline.c modified , text changed
Directorysubversion/trunk/subversion/tests/cmdline/update_tests.py modified , text changed

infrastructure at apache.org
ViewVC Help
Powered by ViewVC 1.1.26