/[Apache-SVN]
ViewVC logotype

Revision 1764040


Jump to revision: Previous Next
Author: kotkov
Date: Mon Oct 10 09:40:06 2016 UTC (7 years, 6 months ago)
Changed paths: 2
Log Message:
mod_dav: Fix a potential cause of unbounded memory usage or incorrect
behavior in a routine that sends <DAV:response>'s to the output filters.

The dav_send_one_response() function accepts the current head of the output
filter list as an argument, but the actual head can change between calls to
ap_pass_brigade().  This can happen with self-removing filters, e.g., with
the filter from mod_headers or mod_deflate.  Consequently, executing an
already removed filter can either cause unwanted memory usage or incorrect
behavior.

This patch changes the signature of the existing mod_dav's public API,
dav_send_one_response(), because this API is not yet a part of any 2.4.x
release.

* modules/dav/main/mod_dav.c
  (dav_send_one_response): Accept a request_rec instead of an ap_filter_t.
   Write the response to r->output_filters.
  (dav_send_multistatus, dav_stream_response): Update these calling sites
   of dav_send_one_response().

* modules/dav/main/mod_dav.h
  (dav_send_one_response): Adjust definition.


Changed paths

Path Details
Directoryhttpd/httpd/trunk/modules/dav/main/mod_dav.c modified , text changed
Directoryhttpd/httpd/trunk/modules/dav/main/mod_dav.h modified , text changed

infrastructure at apache.org
ViewVC Help
Powered by ViewVC 1.1.26