/[Apache-SVN]
ViewVC logotype

Revision 1602338


Jump to revision: Previous Next
Author: breser
Date: Fri Jun 13 08:34:05 2014 UTC (9 years, 10 months ago)
Changed paths: 4
Log Message:
Fix PR 56480: PROPFIND walker doesn't encode hrefs properly

Reverts r1529559 partially (specifically the dav_xml_escape_uri) bit.
Reverts r1531505 entirely.

* modules/dav/main/mod_dav.c
  (dav_xml_escape_uri): Revert the piece of r1529559 that removes the URI
    escaping from this function.

* modules/dav/main/props.c
  (dav_do_prop_subreq): Escape the URI before doing a sub request with it.
    This resolves some properties like getcontenttype from failing to be
    returned for files that contain characters that require encoding in their
    path.

* modules/dav/main/mod_dav.h
  (dav_resource): Note the inconsistency in the documentation.

* modules/dav/fs/repos.c
  (dav_fs_get_resource): Don't use the unparsed_uri to set the uri field of
    the resource.  This is the correct fix for the double encoding in mod_dav_fs
    that led to the dav_xml_escape_uri() change and r1531505.
  (dav_fs_walker, dav_fs_append_uri): Revert r1531505 changes.


Changed paths

Path Details
Directoryhttpd/httpd/trunk/modules/dav/fs/repos.c modified , text changed
Directoryhttpd/httpd/trunk/modules/dav/main/mod_dav.c modified , text changed
Directoryhttpd/httpd/trunk/modules/dav/main/mod_dav.h modified , text changed
Directoryhttpd/httpd/trunk/modules/dav/main/props.c modified , text changed

infrastructure at apache.org
ViewVC Help
Powered by ViewVC 1.1.26