/[Apache-SVN]
ViewVC logotype

Revision 326718


Jump to revision: Previous Next
Author: kmarsden
Date: Wed Oct 19 21:47:26 2005 UTC (4 years, 1 month ago)
Changed paths: 8
Log Message:
DERBY-498 - Result set holdability defined inside stored procedures is ignored by server/client

The attached patch 'derby-498.diff' changes network server to use statement holdability set within stored procedures. The patch does the following:

1. For callable statements, the execute method in DRDAStatement gets holdability from the statement that produced the resultset.
2. Added getResultSetHoldability method which takes a resultset and returns holdability.
3. execute method passes this holdability to addResultSet method, which sets DRDAResultSet.withHoldCursor with this value.
4. writeOPNQRYRM method in DRDAConnThread is changed to use the holdability of the current DRDAResultSet for setting SQLCSRHLD.
5. Added tests in lang/holdCursorJava.java. Created a new master file for DerbyNetClient.

Ran derbyall on WinXP Sun jdk1.4.2. No failures. However, in a previous run of derbyall I got failures in few encryption tests. The failures did not seem related to my change. So I ran the encryption suites again and they passed. Then ran derbyall again and all tests passed. 

Also attaching an additional patch "xa_proc_test.diff" for xa tests. It does the following:
1. Adds procedure test to jdbcapi/xaSimplePositive.sql.
2. Updates master files.

Contributed by Deepa Remesh dremesh@gmail.com


Changed paths:

Path Details
Directorydb/derby/code/trunk/java/drda/org/apache/derby/impl/drda/DRDAConnThread.java modified , text changed
Directorydb/derby/code/trunk/java/drda/org/apache/derby/impl/drda/DRDAStatement.java modified , text changed
Directorydb/derby/code/trunk/java/testing/org/apache/derbyTesting/functionTests/master/DerbyNetClient/holdCursorJava.out added
Directorydb/derby/code/trunk/java/testing/org/apache/derbyTesting/functionTests/master/DerbyNetClient/xaSimplePositive.out modified , text changed
Directorydb/derby/code/trunk/java/testing/org/apache/derbyTesting/functionTests/master/holdCursorJava.out modified , text changed
Directorydb/derby/code/trunk/java/testing/org/apache/derbyTesting/functionTests/master/xaSimplePositive.out modified , text changed
Directorydb/derby/code/trunk/java/testing/org/apache/derbyTesting/functionTests/tests/jdbcapi/xaSimplePositive.sql modified , text changed
Directorydb/derby/code/trunk/java/testing/org/apache/derbyTesting/functionTests/tests/lang/holdCursorJava.java modified , text changed

apache@apache.org
ViewVC Help
Powered by ViewVC 1.1.2