Parent Directory
| 
Revision Log
| Links to HEAD: | (view) (annotate) |
| Sticky Revision: |
* log: Provide "||program" syntax to optionally restore behavior broken in
2.0.50 which leads to bad process handling on Solaris and wasted process
resources on all platforms.
Trunk version (new behavior);
http://svn.apache.org/viewvc?view=rev&revision=775300
http://svn.apache.org/viewvc?view=rev&revision=775320
Proposed 2.2.12 patch, retaining default behavior from 2.2.11;
http://people.apache.org/~wrowe/fixlog22.patch
On win32, we must never, never close the parent's copy of the child's read end for a reliable piped logger. The child runs and manages it's own logs, and even if the parent did instead, the mpm would be adjusted to pass down the child write ends without read ends to the pipes, so this forever makes no sense. Backport: r607666
* core log.c: Work around possible solutions rejected by apr for
the old implementation of apr_proc_create(), and explicitly pass
the output and error channels to all log processes created.
This goes all the way back to piped logs failing to run on win32.
Not in or needed at trunk/, as apr 1.3.0 has the proper fix.
Approved and backported
use a special pool for stderr logging
log core: fix the new piped logger case where we couldn't connect the replacement stderr logger's stderr to the NULL stdout stream. Continue in this case, since the previous alternative of no error logging at all (/dev/null) is far worse. [William Rowe] also disambiguate an error message to diagnose future error reports Backport: r568326, r568322
merge from trunk:
*) Fix issue which could cause piped loggers to be orphaned and never
terminate after a graceful restart. PR 40651. [Joe Orton,
Ruediger Pluem]
Reviewed by: trawick, wrowe
update license header text
Revert r395231 from the 2.2.x branch. This gets us back to the old place with regard to the copyright statements.
Update the last year of copyright for the 2.2.x branch
No functional change: remove trailing whitespace. This also means that "blank" lines, which had consisted of just spaces and/or tabs are now truly blank lines
Recreate 2.2.x branch from trunk.
fix minor annoyance on z/OS: __FILE__ is set to "./foo.c" instead of simply "foo.c", so filter out all but the basename before logging it with debug messages
* server/log.c (piped_log_spawn): Don't leak an fd for each invocation. Reviewed by: Jeff Trawick
* server/log.c (ap_open_piped_log): Remove errno handling.
* server/log.c (piped_log_spawn): Return the APR error code, as expected by piped_log_maintenance (and fixing "Unknown error" messages in error path there). (ap_open_piped_log): Expect an APR error code.
Prevent hangs of child processes when writing to piped loggers at the time of graceful restart. PR: 26467 Reviewed by: Joe Orton
Update copyright year to 2005 and standardize on current copyright owner line.
general property cleanup
add ap_log_cerror(); use it in a couple of places in core output filter so that the client IP address is recorded in the log
* server/log.c (log_error_core): For APLOG_DEBUG on Unix, if __FILE__ is an absolute path (as in a VPATH build), just log the basename.
tweak error handling when reading the pid file previously strtol() would look at unitialized storage, but now the string is terminated where the data read ends give user a hint about removing the file if we can't read/parse it properly (somehow I ended up with a truncated httpd.pid on my own system, leading to these tweaks)
* modules/ssl/ssl_engine_kernel.c (ssl_callback_SSLVerify_CRL), * server/log.c (ap_log_pid), * server/mpm/prefork/prefork.c (accept_mutex_on, accept_mutex_off), * support/htdbm.c (htdbm_list): Fix some non-literal format strings (warnings from gcc -Wformat-security). PR: 30585 Submitted by: Ulf Harnhammar (SITIC), Joe Orton
start piped loggers via the shell, passing through the environment variables in the httpd process this requires a new APR feature (APR_SHELLCMD_ENV), just added to apr 1.0-dev
fix typo in recent commit Submitted by: Jean-Jacques Clar
Pass environment variables through to piped loggers, resolving a regression since 1.3. Submitted by: Ken Coar, Jeff Trawick
* modules/loggers/mod_log_config.c, server/log.c (open_error_log, ap_replace_stderr_log): Use APR_LARGEFILE when opening log files, to allow log files to exceed the 2Gb limit if necessary. PR: 13511
fix name of The Apache Software Foundation
fix copyright dates according to the first check in
apply Apache License, Version 2.0
use the UNSAFE designation for unescaped errorlogs Submitted by: Geoffrey Young, Joe Orton
allow unescaped errorlogs via compile time switch Submitted by: Geoffrey Young <geoff modperlcookbook.org>
update license to 2004.
Fix some piped log problems: bogus "piped log program '(null)' failed" messages during restart and problem with the logger respawning again after Apache is stopped. PR: 21648, 24805
SECURITY [CAN-2003-0020]: escape arbitrary data before writing into the errorlog. Reviewed by: Mark J Cox
no need to open error log for reading Submitted by: Bjoern A. Zeeb Reviewed by: Jeff Trawick, who added the same change to another path
Win32: Whack the fully qualified names that appear in the log when loglevel debug is being used.
Oops - undo wrong commit
On failures, try to add a hint what went wrong
SECURITY: Eliminated leaks of several file descriptors to child processes, such as CGI scripts. PR: 17206 Submitted by: Christian Kratzer <ck@cksoft.de>, Bjoern A. Zeeb <bz@zabbadoz.net> Reviewed by: Joe Orton, Will Rowe
Fix an existing problem with error handling in piped_log_spawn(). Use new APR apr_proc_create() features to prevent Apache from starting on Unix* in most cases where a piped log program can be started, and add log messages for the other situations. *Other platforms already failed Apache initialization if a piped log program couldn't be started. PR: 15761
Make failing piped loggers work more like apache-1.3 by 1) logging a message 2) trying to restart PR: 15761
finished that boring job: update license to 2003. Happy New Year! ;-))
Some errors are impossible to fathom, without the user knowing certain base numbers. This patch introduces "(EAP ##): Eap message" for the EAP errors, "(OS ##): Message" for modestly numbered os errors (under 100000) and hex "(OS 0x########): Message" for huge errors, which generally have bit-flag meanings and are usually represented in hex. This should make recognizing user bugreports a little less difficult. Would have done the same for other ranges, but they don't have (as) obvious numeric meanings on their own. Finally, we free up a buffer copy and give apr_strerror our string buffer to directly populate the message text.
Modify ap_open_logs (an internal function) to follow the hook open_logs argument schema so it can be directly invoked by the hook handler. Also clean up the open_logs processing to return an error rather than simply exit()ing.
Continue the Bill Rowe apr_size_t crusade.
Well the wrappers work out well... nice to be able to put off committing these API changes until the evening ;)
Clean up new compiler emit noise
Simplify ap_read_pid and make it more portable. - Switch to using apr_file_read_full() - Stop checking for \n (non-portable) - Error if we read the entire buffer or the first digit isn't a number
add ap_log_pid() for reading an Apache pid file Submitted by: Justin Erenkrantz
stop using APLOG_NOERRNO in calls to ap_log_?error()
ignore APLOG_NOERRNO; note that it is deprecated
Added the APLOG_TOCLIENT flag to ap_log_rerror() to explicitly tell the server that warning messages should be sent to the client in addition to being recorded in the error log. Prior to this change, ap_log_rerror() always sent warning messages to the client. In one case, a faulty CGI script caused the server to send a warning message to the client that contained the full path to the CGI script. This could be considered a minor security exposure.
Fix 'control reaches end of non-void function' warning Submitted by: Ben Collins-Sussman <sussman@collab.net> Tweaked by: Justin Erenkrantz
Introduced -E startup_logfile_name option to httpd to allow admins
to begin logging errors immediately. This provides Win32 users
an alternative to sending startup errors to the event viewer, and
allows other daemon tool authors an alternative to logging to stderr.
Spell out the merged log name, if we succeeded in merging the path
get the prototype for ap_recent_ctime()
Use the "recent time" cache to optimize timestamp generation for the httpd error log Background: According to some profile data that we collected on Solaris, half the run time of ap_log_rerror() was spent in localtime(3). With this change, the recent-time cache ensures that the error logger won't cause more than one localtime() call per second, no matter how high the error rate is.
Eliminate potential ap_server_root_relative segfaults, with the input of Jeff Trawick's style changes to the first patches. Doesn't include the fixes to ssl [more complex], and we won't trap errors that involve ap_serverroot, since we presume that was normalized on the way in. Therefore, testing ap_server_root_relative(DEFAULT_FOO) cases should never become necessary.
deal with the rename of kill_after_timeout to APR_KILL_AFTER_TIMEOUT
Update our copyright for this year.
Sander's Stylistic Submission (de-tab) PR: Obtained from: Submitted by: Reviewed by:
Whoh boy that's rough... We sometimes like to answer SIGHUP in the parent process, don't we? This -was- post-fork() in 1.3, but with the massive restructuring, we inadvertantly now whack the parent process.
This code seriously misassumed (and may yet) that stderr was a valid file. It also has some bogus non-apr code that probably does great evil to win32 services. This must be bumped into .32, code review is incomplete still.
Removed the #ifdef NETWARE to allow the standard abort() function to be called.
BS. This isn't an assert. This is a friggin developer's black hole. Suggesion: Netware needs to implement the appropriate abort() style fn. If there is none on Netware, this is non-portable, undebuggable, and will be yanked by tommorow evening.
Bring apache in line with the new apr_file_dup2() parameter type.
Allow the user to get detailed debugging information without a full recompile [absolutely necessary on Win32 and other platforms that really don't support administrator-compilation.] -e level follows the LogLevel options. The only question, should -e override the compiled-in default for the creation of the server_rec? No strong feeling either way, here.
Subset of another, have piped_log_cleanup_for_exec handle the dirtywork common to piped_log_cleanup
This brings apache back in line with apr following the addition of apr_file_dup2. Until Win32 and OS/2 have the function added this will break their builds, but Will Rowe has said he'll do it this morning and asked for the patch to apr to go in :) Go Will!
Style and formatting changes only. Removed tabs, reduced long lines, aligned parameters, added braces around some single-statement basic blocks.
Added NETWARE to the #ifdef list
Clean up the string passed to the error log hook. This removes the date, time, error level, etc strings. The only information in the string is the actual error. Submitted by: Jon Travis <jtravis@covalent.net>
Switch back to SIGUSR1 for graceful restarts on all platforms that support it. This defines a symbol called AP_SIG_GRACEFUL in ap_config_auto.h which will have the appropriate signal value. All direct references to SIGWINCH have been replaced with AP_SIG_GRACEFUL. On Linux 2.0, use SIGWINCH instead since SIGUSR1 is used by glibc 2.0's user-space threading library to control threads. All later versions of Linux/glibc don't have this problem. (Not to mention the security holes in older Linux versions which make it unsuitable for use as a web server.) If your platform doesn't have SIGUSR1, use the appropriate mojo in configure to define what your graceful restart signal should be. In theory, a configure switch could be added to allow the admin to specify the appropriate signal that should be used. This is left as an exercise to the reader for now. The docs need to be updated. Since the signal is now configurable, just saying SIGUSR1 for graceful restart isn't completely true. Also, the apachectl functionality needs to be moved into httpd - this is what Win32 does and it makes us consistent across platforms. Roy issued a veto against use of SIGWINCH by default, so this should resolve that veto.
httpd.exp and lots of other export files are generated based on the AP[RU]_DECLARE macros. This commit gets mod_cgid working again as a DSO on AIX. However, this brings up the need to look for any functions that are available as part of the API, and AP[RU]_DECLAREing them, so things don't blow up in DSOs.
Missed one, all should have recovered from APR_INHERIT now.
Obvious files that need inheritance, correct me if I'm wrong.
Add a new request phase, for allowing management modules to forward error logs to their management agents.
Fix a segfault in apr_proc_other_child_unregister. Jeff recently made a change in APR otherchild.c to unregister all OC registrations as part of pool cleanup. This means that we must NOT explicitly call apr_proc_other_child_unregister out of other pool clean-up routines. In this case, the OC cleanup was being called first then the piped_log_cleanup was being called which called apr_proc_other_child_unregister. We could fix this by detecting the case when there are no more OCs registered in apr_proc_other_child_unregister but that might just mask other problems we need to fix anyway.
Remove a needless assignment.
Missed one...
*Sigh*. Pointless repetition of calculations. It bothers me. Even if it is simple bitwise AND.
Hmmm... this made things easier for me to read a while back, perhaps someone else may appreciate
Update copyright to 2001
*) include "apr_signal.h" when needed *) some other minor include tweaks
Clean up some of the includes: - explicitly include apr_lib.h since ap_config.h doesn't - use apr_want.h where possible - use APR_HAVE_ where possible - remove some unneeded includes
renaming various functions for consistency sake see: http://apr.apache.org/~dougm/apr_rename.pl PR: Obtained from: Submitted by: Reviewed by:
Use the appropriate APR_FINFO_flags for the apr_stat/lstat/getfileinfo calls to avoid ownership and permissions on Win32 when they are not required, and until they are implemented.
The changes required for the APR_FINFO_wanted argument to apr_stat/lstat/getfileinfo. These are -NOT- optimal, they are simply the required changes to get the server working. The size of the patch is a warning about how we need to really look at what we are trying to accomplish with all of these stat/lstat calls.
Some missing exports
get rid of some bogus uses of perror()
Fix message when the error log file can't be opened.
Set up stderr logging explictly early in initialization so that a pool is available for creating the APR representation of stderr.
We have a pool in this function, and log_error_core needs a pool in order to open stderr successfully. By using ap_log_perror, we can pass a valid pool down to log_error_core
Use a real pool to dup the error log file descriptor.
*) Compensate for recent changes in the APR headers. Specifically, some files need to specifically include stdio.h, or a particular apr_*.h header. *) Adjust callers of apr_create_process() to deal with the extra "const" *) Add "const" to args of ap_os_create_privileged_process()
*) Accomodate an out-of-space condition in the piped logs and the
rotatelogs.c code, and no longer churn log processes for this
condition. [Victor J. Orlikowski]
Add the referer to the error log if one is available. PR: 73 Submitted by: Markus Gyger <mgyger@itr.ch>
Namespace protect the rest of the macros defined by ap_config.h
Fix piped logs in 2.0. This basically: 1) cleans up an annoying type that was getting in my way while I was trying to fix things. 2) Makes some of the allocations pcalloc instead of palloc 3) The arg array passed to create_process is a const *char *, not const *char []. PR: 6642
Renamed all MODULE_EXPORT symbols to AP_MODULE_DECLARE and all symbols for CORE_EXPORT to AP_CORE_DECLARE (namespace protecting the wrapper) and retitled API_EXPORT as AP_DECLARE and APR_EXPORT as APR_DECLARE. All _VAR_ flavors changes to _DATA to be absolutely clear. Thank you Greg, for the most obvious suggestion.
Add #include <unistd.h> for getpid() prototype.
Remaining cleanup of ap_ -> apr_ and AP_ -> APR_ transformation... see src/lib/apr/apr_compat.h for most details. Also a few minor nits to get Win32 to build. PR: Obtained from: Submitted by: Reviewed by:
Remove some old APIs. These were left around for legacy modules. Since we have broken all modules anyway, this is a good time to cleanup a bit.
prefix libapr functions and types with apr_
This should be clean... ap_snprintf already holds a byte for the null terminator, and this patch sets aside whatever space is needed for the newline termination. PR: Obtained from: Submitted by: Reviewed by:
Add APR_EOL_STR for a platform specific text delimiter, provided by apr.h (defined in apr.h.in and apr.hw). This is needed -only- in APR created files (true raw files) such as logs. It is not required in any splat to screen (stderr/stdout) formatting, nor any html markup. Some other modules slipped through in the prior apr_strings.h commit. Sorry 'bout that. PR: Obtained from: Submitted by: Reviewed by:
Move all APR functions related to strings to their own directory, and create a new header for those functions. This is the first step to removing the apr/lib directory completely, and moving those files/functions to descriptive directories.
Apache doesn't actually check for stdarg.h, but APR does. Just use the APR defined APR_HAVE_STDARG_H to check for the existance of stdarg.h
Save the write end of the pipe. pipe_log_spawn really needs to be combined with log_child.
Ooops... Didn't notice this one until I tried compiling with APR_HAS_OTHER_CHILD
Fix a nasty stack corruption. ap_proc_t should be allocated out of the same pool passed to ap_create_process. A little further down the road to getting reliable piped logs working on Win32.
Include strings.h for strcasecmp(), strncasecmp(), and bzero(). Include time.h for time(). This removes a bunch of compiler warnings with gcc -Wall on AIX. Submitted by: Jeff Trawick, Victor Orlikowski
ap_create_pipe was changed to return a pipe with both handles blocking (previously, both handles were non-blocking). ap_set_pipe_timeout() is now the only way to manipulate the blocking state of the pipe. Pass -1 for timeout to make it blocking; pass 0 for timeout to make it non-blocking. ap_block_pipe() is gone. A few minor bugs were fixed along the way. OS-specific notes: non-Unix in general: Only Unix/BeOS currently has the optimization to keep track of the blocking state. This is used to avoid syscalls as well as to handle ap_put_os_file(), which is a case where we don't know the blocking state of the handle we are given. OS/2: ap_set_pipe_timeout() with timeout value > 0: The code didn't play with the blocking state before and it doesn't still. I did add logic for special timeout values 0 and -1 to play with the blocking state. ap_create_pipe(): old logic didn't do anything with the blocking state of the second handle; it still doesn't; hopefully it is blocking pre-BONE BEOS: old code to make a pipe non-blocking was a no-op; now it returns APR_ENOTIMPL BONE: old code to make a pipe non-blocking; it passed &zero as the parm to FIONBIO instead of &one; this bug was fixed Win32: The pipe was always created blocking before; no change previously, ap_setprocattr_io() ignored the blocking flag; now it respects it like other platforms and calls ap_set_pipe_timeout(p,0) on appropriate pipe handles (Bill Stoddard was just working in ap_set_pipe_timeout(), so I presume this is golden)
Protect system header files with the appropriate macros.
Fix logging of errors creating the httpd.pid file. perror() was converted to ap_log_error(), which will interpret the specified APR error code properly. The existing ap_log_error() call was changed so that the message is formatted properly. Note that this call is made from the mpm after we detach from the foreground process, so it can only appear in the log.
Back out ap_set_default_perms(). Remove old logic to play with umask around the creation of the httpd.pid file. Pass explicit permissions to ap_open(), omitting write-ability except by the owning user. As always, we end up with rw-r--r-- for the permissions unless the umask is something unusual. Note that the OS/2 and Win32 implementations of ap_open() ignore the permissions parameter altogether.
Add a new function ap_set_default_fperms. This allows people to set the umask to be used when creating files. This should change the permissions of files created using APR_DEFAULT_OS. Also removed a warning introduced with the sys/stat.h changes.
Remove all occurances of strerror from Apache. ap_strerror works just fine with standard errno values, and it is more portable. This also allows me to remove the check for strerror from Apache's configure script.
Increase the size of the buffer passed to ap_strerror(); I saw truncation of a particularly long message on OS/390, and useful info was past char 100.
Rename stdin, stdout, stderr from new ap_proc_t to in, out, and err because Windows was having problems with the original names.
Convert ap_proc_t to a complete type. This lets us access the pid directly. Only the prefork MPM has been ported so far, the rest of the Unix MPM's are coming later today.
Remove all remaining instances in Apache code of
ap_{block,unblock}_alarms.
Remove an unused variable and warning.
Port reliable piped logs to mpmt_pthread and dexter. Also a couple of small cleanups for reliable piped logs.
Make reliable piped logs work on 2.0.
Make piped logs work again in 2.0. The next step is reliable piped logs.
Get rid of ap_pool_t argument on ap_strerror
Tell APR to truncate the httpd.pid file if it exists. Fix a bug in the Windows side of APR to correctly handle this flag. Also fix related bug in ap_write.
Add support for pool to log_error_core. Also add ap_log_perror to allow logging without either a request or server _rec.
Add a pool to dupfile. There is no reason that when we duplicate a file, we would want to use the same pool for the duplicated file as we used for the original file. This should solve a problem we were having with dieing quietly on startup, because we are no longer closing stderr in the original process and then opening the config file as file descriptor 2. The original problem report can be found in the message <20000311232812.A1066@sanguine.linuxcare.com.au>
Change ap_context_t to ap_pool_t. This compiles, runs, and serves pages on Linux, but probably breaks somewhere.
stop relying on a macro to map signal() to ap_signal(); call ap_signal() directly
Eliminate apr_win.h and apr_winconfig.h (and the ugly #ifdefs they cause). Now, apr.h and apr_config.h are generated from apr.hw and apr_config.hw at build time. At this point, the server will not compile on Windows because of the recent DSO commits. Fixing those next. Submitted by: Bill Rowe & Bill Stoddard
Update to Apache Software License version 1.1
Backport the CSS security fixes to Apache 2.0a. Or is that forward port? My sense of direction is all confused. PR: Obtained from: Submitted by: Reviewed by:
Fix all the License issues. Including: s/Apache Group/Apache Software Foundation/ s/1999/2000/ s/Sascha's license/ASF license
Fix the logic for ap_signal, so it is exposed in external header files in APR. Also change the header file included in http_log.c.
clean up a bunch of -Wall/etc warnings
Ahh, found ap_flush()!
Update Windows ap_filedup() call to recognise when it is asked to dup2 a standard i/o handle. Return error if the dup2 handle is not one of the standard i/o handles (because Windows does not support a dup2 style function to operate on native file handles)
ap_dupfile (specifically dup2) is not available in a general form under Windows. So use SetStdHandle directly. A single call to ap_dup2stderr() (or similar) could replace the entire chunk of code in the #ifdef #else #endif block. Ryan didn't want to put this speciality function into APR, but we could put it into os.c if folks are interested.
First step to get piped logs working on Windows (and Unix as well). There are still all kinds of problems in http_log.c. This patch just barely scratches the surface.
Enforce a sensible permission on the httpd.pid file. Submitted by: Frank Miller <frankm@system-associates.com> Reviewed by: Martin Kraemer
Finish the commits for the change in the header files. Basically, this hides all of the Apache macros that modules don't need access to. This should have been committed with the modules, but I wasn't paying attention to the directory I was in when I ran the commit. Submitted by: Manoj Kasichainula and Ryan Bloom
time overhaul: - ap_time_t is a 64-bit scalar, microseconds since epoch - ap_exploded_time_t corresponds to struct tm with a few extras probably broken on anything except linux.
Separate the stat structure from the file structure and use ap_stat and ap_getfileinfo in apache.
Initialize all ap_file_t's to NULL. This allows ap_open and ap_stat to work together without causing memory leaks.
Get rid of more platform dependant code.
Get rid of a couple more ap_os_file_t's along with their platform dependant code.
We may not always want to make the pipes between processes non-blocking. This patch allows us to set if both sides of the pipes are nonblocking, both sides are blocking, just the parent side blocks, or just the child side blocks for all three of the pipes created during create_process. I have also modified Apache to take advantage of this change.
Eliminate ap_config.h's checks when using autoconf. Now, ap_ac_config.h is used instead, and autoconf's configure script will check for everything else.
Some compile fixes for the piped log code. It doesn't completely completely compile, but it looks a little better.
First step in removing the fprintf(stderr problem from Apache. Basically, I defined APLOG_STARTUP, which refrains from printing the date string and the log level information in log_error_core. I then changed all the fprintf(stderr calls to ap_log_error, and used APLOG_STARTUP. log_error_core on Unix takes care of creating a log file and directing it to stderr if a log file isn't already active. I will continue to make these changes tomorrow. Currently, the main code and the dexter mpm have been modified.
Get rid of a number of 'incompatible pointer type' warnings using
ap_os_{get,put}_file() on platforms who's ap_os_file_t is not an int.
Stop using APR_BUFFERED for the error log and httpd.pid file. The error logging code has been tweaked a bit so that we still have one write per log entry.
Be on the safe side
Add a status value to ap_log_error and ap_log_rerror. This allows us to use apr_status codes in our error logs. The main advantage of this, is portable error codes. Now, Windows will finally be able to use errno!
Need APR_CREATE flag when opening error log & pid file.
I missed one function when swapping paramters. This fixes it. I think I have caught them all this time. I really hope this is the final time I have to swap parameters.
This finishes the argument swaps. The docs haven't been updated, and probably won't be for a while yet. These argument orders have been documented in the APR Design doc committed earlier today.
Make Apache use the new ap_create_process call. This is the first of a group of patches. This patch, allows the core server to compile and serve pages. There is a set of patches which will follow to allow the standard modules to use ap_create_process. This change should make writing code which spawns new processes easy to read and understand. Submitted by: Paul Reder
Bring file_io up to the new parameter order for APR. I have decided to do these on a directory by directory basis for the rest of APR. I hope to cause fewer problems for other developers by doing it this way.
First patch to re-order function parameters. This one gets the low hanging fruit, and moves most of the result parameters to the first argument. Future patches in this series will move the rest of the result parameters to the beginning of the list, and will move the context's to the end of the list
Remove all of the calls to functions like "ap_popenf". These functions were moved down to APR, but they are being removed. They are not portable, and were only moved down for backwards compatability. With this change, they can be safely removed, which is the next commit on it's way. Submitted by: Ryan Bloom and Paul Reder
Changed pools to contexts. Tested with prefork and pthread mpm's. I'll check this out tomorrow and make sure everything was checked in correctly.
Odd comments and leftover bits from the pthreads version. The comments really should be deleted, or at least cleaned up. Submitted by: pthreads leftovers
Sorry, but using C comments in place of C++ comments makes life for me and my compiler much easier. This one should be back-ported to Apache 1.3.10-dev Submitted by: Martin Kraemer
Replace all alarms and timeouts with a mutex on alloc. Replace file descriptors with APRFile. Add ap_is_aborted macro. Submitted by: Bill Stoddard, Dean Gaudet
Apache 1.3.9 baseline for the Apache 2.0 repository. Obtained from: Apache 1.3.9 (minus unused files), tag APACHE_1_3_9 Submitted by: Apache Group
This form allows you to request diffs between any two revisions of this file. For each of the two "sides" of the diff, enter a numeric revision.
| apache@apache.org | ViewVC Help |
| Powered by ViewVC 1.1.2 |