/[Apache-SVN]
ViewVC logotype

Revision 161390


Jump to revision: Previous Next
Author: craigmcc
Date: Fri Apr 15 05:32:30 2005 UTC (19 years, 6 months ago)
Changed paths: 6
Log Message:
Add a new "findbugs" target to build.xml to run the FindBugs tool
<http://findbugs.sourceforge.net>.  Cool tool!

Clean up several issues reported by findbugs -- including a real functionality
bug in TokenProcessor due to a botched copy-n-paste exercise.

The remaining nine warnings are all related to the fact that the
org.apache.commons.chain.impl.ContextBase class "extends HashMap" instead of
"extends AbstractMap", and therefore inherits the "implements Serializable"
characteristic of HashMap.  It's pretty dubious whether Context implementations
should be *required* to be Serializable, but this needs to be discussed on the
Commons Dev list.


Changed paths

Path Details
Directorystruts/shale/trunk/core-library/build.properties.sample modified , text changed
Directorystruts/shale/trunk/core-library/build.xml modified , text changed
Directorystruts/shale/trunk/core-library/src/java/org/apache/shale/remote/ContextAttributes.java modified , text changed
Directorystruts/shale/trunk/core-library/src/java/org/apache/shale/remote/RequestAttributes.java modified , text changed
Directorystruts/shale/trunk/core-library/src/java/org/apache/shale/remote/SessionAttributes.java modified , text changed
Directorystruts/shale/trunk/core-library/src/java/org/apache/shale/util/TokenProcessor.java modified , text changed

infrastructure at apache.org
ViewVC Help
Powered by ViewVC 1.1.26