================================================================================ Licensed to the Apache Software Foundation (ASF) under one or more contributor license agreements. See the NOTICE file distributed with this work for additional information regarding copyright ownership. The ASF licenses this file to You under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. ================================================================================ $Revision$ $Date$ ================================= Apache Tomcat 6.0 Patch Proposals ================================= RELEASE SHOWSTOPPERS: PATCHES ACCEPTED TO BACKPORT: [ start all new proposals below, under PATCHES PROPOSED. ] PATCHES PROPOSED TO BACKPORT: [ New proposals should be added at the end of the list ] * Fix issue where the first request for a deleted JSPs returns as if the JSP still exists. http://svn.apache.org/viewvc?view=rev&revision=683969 +1: markt, funkman 0: remm (looks risky, very minor problem), fhanik - minor problem -1: * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=45403 See commit message for details of negligable performance impact http://svn.apache.org/viewvc?rev=701358&view=rev +1: markt, funkman -0: remm (I also do not think the patch is a good idea as a backport) -0: fhanik - the bug talks about WEB-INF/lib and reload, that would be when reload="true" which should be considered development only So to make this bug actually worth while fixing, and not impact performance, then it should only do this check on files that are relevant to the reload of an application, in other words a watched resource * Backport cleanup of semantics of thisAccessedTime and lastAccessedTime for sessions: - preparational whitespace changes http://svn.apache.org/viewvc?rev=711695&view=rev - Give thisAccessedTime and lastAccessedTime for sessions a clear semantics: http://svn.apache.org/viewvc?rev=711711&view=rev - thisAccessedTime will be updated at the beginning and at the end of session use - lastAccessedTime will only be updated at the end of session use This means: - lastAccessedTime is the last access time of a session disregarding any request still being processed on. So this is good to use even from within a request to detect when its own session has been used last before. - thisAccessedTime already gets updated when a new request disregarding any request still being processed on. So this is better for any idleness check or information. - thisAccessedTime >= lastAccessedTime always - Port from StandardSession to DeltaSession http://svn.apache.org/viewvc?rev=711714&view=rev - Expose thisAccessedTime via the session interface and ManagerBase, so we can use it from outside the session. http://svn.apache.org/viewvc?rev=711716&view=rev - Make the classes checking session idleness use thisAccessedTime. http://svn.apache.org/viewvc?rev=711720&view=rev This is not for invalidation, only for displaying idle times and making persistance decisions. +1: rjung, markt 0: billbarker: generally agree with remm that this is too big of a change for the stable branch but could agree to some of it if it was split into parts -1: remm: no for TC 6.0 -1: funkman : api change in Session.java for .x.x release * Fix Close Stream at WebappClassLoader after read error http://svn.apache.org/viewvc?rev=772872&view=rev +1: pero, funkman -0: kkolinko: http://marc.info/?l=tomcat-dev&m=124192105131636&w=2 -1: * Dont try to report thread counts when using an executor from outside http://people.apache.org/~fhanik/connector-thread-report.patch +1: fhanik +1: markt - would 0 make more sense rather than -1? Happy with either -1: * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=47369. http://svn.apache.org/viewvc?rev=784879&view=rev +1: fhanik, markt, mturk, rjung -1: * Update release process to include new windows package zip files with .dll and .exe matching a target CPU. Patch also syncs and fixes nsi installer script. Patch for 6.0.x is available at: http://people.apache.org/~mturk/tomcat/tomcat6-package-winzip-2.patch +1: mturk, kkolinko, rjung -1: * When throwing Non-serializable exception, mark which argument was non-serializable to help tracing the cause when developing. http://svn.apache.org/viewvc?rev=713953&view=rev http://svn.apache.org/viewvc?rev=714002&view=rev 6.0.x version of the patch: http://people.apache.org/~mturk/tomcat/setAttribute.iae.patch +1: mturk -1: kkolinko: ( good in general, but 1) please use native2ascii for LocalStrings_fr.properties s/ e / \u00nn / 2) o.a.c.session.ha.session.LocalString*.properties files also have this string. Should it be removed from there, or updated there also? ) -1: * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=47158 Update AccessLogValve with all the recent threading improvements http://people.apache.org/~markt/patches/2009-06-24-AccessLogValve-tc6.patch +1: markt -1: * Remove some obsolete (and partially broken) message strings. http://svn.apache.org/viewvc?rev=789944&view=rev +1: rjung, kkolinko, markt -1: * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=37984 Strip {MD5} as well as {SHA} from digested passwords http://svn.apache.org/viewvc?rev=790405&view=rev +1: markt -1: * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=47149 Explicitly specify encoding for the source files http://people.apache.org/~kkolinko/patches/2009-07-04_tc6_encodings.patch +1: kkolinko -1: