The following document contains the results of FindBugs Report
FindBugs Version is 1.3.9
Threshold is
Effort is min
Files
org.apache.oodt.cas.metadata.Metadata
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.oodt.cas.metadata.Metadata defines equals and uses Object.hashCode() | BAD_PRACTICE | HE_EQUALS_USE_HASHCODE | 563-575 | High |
| Method org.apache.oodt.cas.metadata.Metadata.addMetadata(Hashtable, boolean) makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 388 | Medium |
org.apache.oodt.cas.metadata.Metadata$Group
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.oodt.cas.metadata.Metadata$Group defines clone() but doesn't implement Cloneable | BAD_PRACTICE | CN_IMPLEMENTS_CLONE_BUT_NOT_CLONEABLE | 450 | High |
org.apache.oodt.cas.metadata.SerializableMetadata
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.oodt.cas.metadata.SerializableMetadata doesn't override Metadata.equals(Object) | STYLE | EQ_DOESNT_OVERRIDE_EQUALS | 61-261 | Medium |
| Load of known null value in org.apache.oodt.cas.metadata.SerializableMetadata.toXML() | STYLE | NP_LOAD_OF_KNOWN_NULL_VALUE | 193 | Medium |
org.apache.oodt.cas.metadata.extractors.CmdLineMetExtractor
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Null pointer dereference of System.err in org.apache.oodt.cas.metadata.extractors.CmdLineMetExtractor.processMain(String[], CmdLineMetExtractor) | CORRECTNESS | NP_ALWAYS_NULL | 61 | High |
| Null pointer dereference of System.err in org.apache.oodt.cas.metadata.extractors.CmdLineMetExtractor.processMain(String[], CmdLineMetExtractor, OutputStream) | CORRECTNESS | NP_ALWAYS_NULL | 81 | High |
org.apache.oodt.cas.metadata.extractors.ExternalMetExtractorConfig
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.oodt.cas.metadata.extractors.ExternalMetExtractorConfig.getArgList() may expose internal representation by returning ExternalMetExtractorConfig.argList | MALICIOUS_CODE | EI_EXPOSE_REP | 60 | Medium |
| new org.apache.oodt.cas.metadata.extractors.ExternalMetExtractorConfig(String, String, String[]) may expose internal representation by storing an externally mutable object into ExternalMetExtractorConfig.argList | MALICIOUS_CODE | EI_EXPOSE_REP2 | 52 | Medium |
| org.apache.oodt.cas.metadata.extractors.ExternalMetExtractorConfig.setArgList(String[]) may expose internal representation by storing an externally mutable object into ExternalMetExtractorConfig.argList | MALICIOUS_CODE | EI_EXPOSE_REP2 | 68 | Medium |
org.apache.oodt.cas.metadata.extractors.MetReaderExtractor
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.oodt.cas.metadata.extractors.MetReaderExtractor.reader isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | 50 | High |
org.apache.oodt.cas.metadata.extractors.TikaCmdLineMetExtractor
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.oodt.cas.metadata.extractors.TikaCmdLineMetExtractor.reader isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | 54 | High |
| Exception is caught when Exception is not thrown in org.apache.oodt.cas.metadata.extractors.TikaCmdLineMetExtractor.extrMetadata(File) | STYLE | REC_CATCH_EXCEPTION | 109 | Medium |
org.apache.oodt.cas.metadata.preconditions.ExistanceCheckComparator
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.oodt.cas.metadata.preconditions.ExistanceCheckComparator.performCheck(File, Boolean) invokes inefficient Boolean constructor; use Boolean.valueOf(...) instead | PERFORMANCE | DM_BOOLEAN_CTOR | 43 | Medium |
org.apache.oodt.cas.metadata.preconditions.FileSizeComparator
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Method org.apache.oodt.cas.metadata.preconditions.FileSizeComparator.performCheck(File, Long) invokes inefficient new Long(long) constructor; use Long.valueOf(long) instead | PERFORMANCE | DM_NUMBER_CTOR | 42 | Medium |
org.apache.oodt.cas.metadata.preconditions.MimeTypeComparator
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Possible null pointer dereference of tikaMimeType in org.apache.oodt.cas.metadata.preconditions.MimeTypeComparator.performCheck(File, String) | CORRECTNESS | NP_NULL_ON_SOME_PATH | 59 | High |
org.apache.oodt.cas.metadata.preconditions.PreCondEvalUtils
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Write to static field org.apache.oodt.cas.metadata.preconditions.PreCondEvalUtils.applicationContext from instance method new org.apache.oodt.cas.metadata.preconditions.PreCondEvalUtils(ApplicationContext) | STYLE | ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD | 51 | High |
org.apache.oodt.cas.metadata.preconditions.PreConditionComparator
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Exception is caught when Exception is not thrown in org.apache.oodt.cas.metadata.preconditions.PreConditionComparator.passes(File) | STYLE | REC_CATCH_EXCEPTION | 71 | Medium |
org.apache.oodt.cas.metadata.preconditions.SubProductExistenceCheckComparator
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.oodt.cas.metadata.preconditions.SubProductExistenceCheckComparator.performCheck(File, Boolean) invokes inefficient Boolean constructor; use Boolean.valueOf(...) instead | PERFORMANCE | DM_BOOLEAN_CTOR | 61 | Medium |
org.apache.oodt.cas.metadata.util.MimeTypeUtils
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Possible null pointer dereference of type in org.apache.oodt.cas.metadata.util.MimeTypeUtils.autoResolveContentType(String, String, byte[]) on exception path | CORRECTNESS | NP_NULL_ON_SOME_PATH_EXCEPTION | 210 | Medium |
org.apache.oodt.cas.metadata.util.PathUtils
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.oodt.cas.metadata.util.PathUtils.DELIMITER isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | 52 | High |
org.apache.oodt.cas.metadata.util.PathUtils$VarData
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Should org.apache.oodt.cas.metadata.util.PathUtils$VarData be a _static_ inner class? | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC | 360-395 | Medium |