Catalog and Archive File Management Component

FindBugs Bug Detector Report

Summary

Files

The following document contains the results of FindBugs Report

FindBugs Version is 1.3.9

Threshold is

Effort is min

Summary

ClassesBugsErrorsMissing Classes
17618100

Files

ClassBugs
org.apache.oodt.cas.filemgr.catalog.DataSourceCatalog18
org.apache.oodt.cas.filemgr.catalog.LenientDataSourceCatalog10
org.apache.oodt.cas.filemgr.catalog.LuceneCatalog4
org.apache.oodt.cas.filemgr.catalog.LuceneCatalog$CompleteProduct1
org.apache.oodt.cas.filemgr.catalog.MappedDataSourceCatalogFactory2
org.apache.oodt.cas.filemgr.catalog.ScienceDataCatalog10
org.apache.oodt.cas.filemgr.catalog.solr.DefaultProductSerializer3
org.apache.oodt.cas.filemgr.catalog.solr.Parameters1
org.apache.oodt.cas.filemgr.catalog.solr.SolrCatalogFactory1
org.apache.oodt.cas.filemgr.catalog.solr.SolrClient1
org.apache.oodt.cas.filemgr.datatransfer.LocalDataTransferer1
org.apache.oodt.cas.filemgr.datatransfer.S3DataTransferer1
org.apache.oodt.cas.filemgr.ingest.CachedIngester3
org.apache.oodt.cas.filemgr.ingest.CmdLineIngester2
org.apache.oodt.cas.filemgr.ingest.RmiCacheServer2
org.apache.oodt.cas.filemgr.ingest.RmiCacheServerFactory2
org.apache.oodt.cas.filemgr.ingest.StdIngester1
org.apache.oodt.cas.filemgr.repository.DataSourceRepositoryManager4
org.apache.oodt.cas.filemgr.repository.ScienceDataRepositoryManager3
org.apache.oodt.cas.filemgr.structs.BooleanQueryCriteria2
org.apache.oodt.cas.filemgr.structs.FreeTextQueryCriteria4
org.apache.oodt.cas.filemgr.structs.Reference1
org.apache.oodt.cas.filemgr.structs.query.QueryResult1
org.apache.oodt.cas.filemgr.structs.query.QueryResultComparator2
org.apache.oodt.cas.filemgr.structs.query.filter.ObjectTimeEvent1
org.apache.oodt.cas.filemgr.structs.query.filter.TimeEvent2
org.apache.oodt.cas.filemgr.system.XmlRpcFileManager10
org.apache.oodt.cas.filemgr.system.XmlRpcFileManagerClient12
org.apache.oodt.cas.filemgr.tools.CASAnalyzer1
org.apache.oodt.cas.filemgr.tools.CatalogSearch29
org.apache.oodt.cas.filemgr.tools.DeleteProduct2
org.apache.oodt.cas.filemgr.tools.DumpDbElementsToXml2
org.apache.oodt.cas.filemgr.tools.ExpImpCatalog1
org.apache.oodt.cas.filemgr.tools.MetadataBasedProductMover1
org.apache.oodt.cas.filemgr.tools.MetadataDumper1
org.apache.oodt.cas.filemgr.tools.OptimizeLuceneCatalog1
org.apache.oodt.cas.filemgr.tools.ProductDumper1
org.apache.oodt.cas.filemgr.tools.ProductTypeDocTool2
org.apache.oodt.cas.filemgr.tools.QueryTool5
org.apache.oodt.cas.filemgr.tools.RangeQueryTester3
org.apache.oodt.cas.filemgr.tools.SolrIndexer3
org.apache.oodt.cas.filemgr.tools.SolrIndexer$IndexerConfig1
org.apache.oodt.cas.filemgr.util.SqlParser4
org.apache.oodt.cas.filemgr.util.XmlRpcStructFactory5
org.apache.oodt.cas.filemgr.util.XmlStructFactory1
org.apache.oodt.cas.filemgr.validation.DataSourceValidationLayer8
org.apache.oodt.cas.filemgr.validation.ScienceDataValidationLayer4
org.apache.oodt.cas.filemgr.versioning.AcquisitionDateVersioner1

org.apache.oodt.cas.filemgr.catalog.DataSourceCatalog

BugCategoryDetailsLinePriority
org.apache.oodt.cas.filemgr.catalog.DataSourceCatalog.addProduct(Product) invokes inefficient new String() constructorPERFORMANCEDM_STRING_VOID_CTOR289Medium
Exception is caught when Exception is not thrown in org.apache.oodt.cas.filemgr.catalog.DataSourceCatalog.paginateQuery(Query, ProductType, int)STYLEREC_CATCH_EXCEPTION2090Medium
Method org.apache.oodt.cas.filemgr.catalog.DataSourceCatalog.getReducedMetadata(Product, List) concatenates strings using + in a loopPERFORMANCESBSC_USE_STRINGBUFFER_CONCATENATION1160Medium
Method org.apache.oodt.cas.filemgr.catalog.DataSourceCatalog.getSqlQuery(QueryCriteria, ProductType) concatenates strings using + in a loopPERFORMANCESBSC_USE_STRINGBUFFER_CONCATENATION2151Medium
Method org.apache.oodt.cas.filemgr.catalog.DataSourceCatalog.addMetadataValue(Element, Product, String) passes a nonconstant String to an execute method on an SQL statementSECURITYSQL_NONCONSTANT_STRING_PASSED_TO_EXECUTE1398High
Method org.apache.oodt.cas.filemgr.catalog.DataSourceCatalog.addProduct(Product) passes a nonconstant String to an execute method on an SQL statementSECURITYSQL_NONCONSTANT_STRING_PASSED_TO_EXECUTE286High
Method org.apache.oodt.cas.filemgr.catalog.DataSourceCatalog.addProductReferences(Product) passes a nonconstant String to an execute method on an SQL statementSECURITYSQL_NONCONSTANT_STRING_PASSED_TO_EXECUTE618High
Method org.apache.oodt.cas.filemgr.catalog.DataSourceCatalog.getNumProducts(ProductType) passes a nonconstant String to an execute method on an SQL statementSECURITYSQL_NONCONSTANT_STRING_PASSED_TO_EXECUTE1532High
Method org.apache.oodt.cas.filemgr.catalog.DataSourceCatalog.getProductByName(String) passes a nonconstant String to an execute method on an SQL statementSECURITYSQL_NONCONSTANT_STRING_PASSED_TO_EXECUTE763High
Method org.apache.oodt.cas.filemgr.catalog.DataSourceCatalog.getProductsByProductType(ProductType) passes a nonconstant String to an execute method on an SQL statementSECURITYSQL_NONCONSTANT_STRING_PASSED_TO_EXECUTE1002High
Method org.apache.oodt.cas.filemgr.catalog.DataSourceCatalog.getReducedMetadata(Product, List) passes a nonconstant String to an execute method on an SQL statementSECURITYSQL_NONCONSTANT_STRING_PASSED_TO_EXECUTE1169High
Method org.apache.oodt.cas.filemgr.catalog.DataSourceCatalog.getResultListSize(Query, ProductType) passes a nonconstant String to an execute method on an SQL statementSECURITYSQL_NONCONSTANT_STRING_PASSED_TO_EXECUTE1860High
Method org.apache.oodt.cas.filemgr.catalog.DataSourceCatalog.getTopNProducts(int, ProductType) passes a nonconstant String to an execute method on an SQL statementSECURITYSQL_NONCONSTANT_STRING_PASSED_TO_EXECUTE1294High
Method org.apache.oodt.cas.filemgr.catalog.DataSourceCatalog.modifyProduct(Product) passes a nonconstant String to an execute method on an SQL statementSECURITYSQL_NONCONSTANT_STRING_PASSED_TO_EXECUTE401High
Method org.apache.oodt.cas.filemgr.catalog.DataSourceCatalog.removeMetadataValue(Element, Product, String) passes a nonconstant String to an execute method on an SQL statementSECURITYSQL_NONCONSTANT_STRING_PASSED_TO_EXECUTE1465High
Method org.apache.oodt.cas.filemgr.catalog.DataSourceCatalog.setProductTransferStatus(Product) passes a nonconstant String to an execute method on an SQL statementSECURITYSQL_NONCONSTANT_STRING_PASSED_TO_EXECUTE538High
Method org.apache.oodt.cas.filemgr.catalog.DataSourceCatalog.updateReferences(Product) passes a nonconstant String to an execute method on an SQL statementSECURITYSQL_NONCONSTANT_STRING_PASSED_TO_EXECUTE2226High
Method org.apache.oodt.cas.filemgr.catalog.DataSourceCatalog.paginateQuery(Query, ProductType, int) passes a nonconstant String to an execute method on an SQL statementSECURITYSQL_NONCONSTANT_STRING_PASSED_TO_EXECUTE2046Medium

org.apache.oodt.cas.filemgr.catalog.LenientDataSourceCatalog

BugCategoryDetailsLinePriority
Exception is caught when Exception is not thrown in org.apache.oodt.cas.filemgr.catalog.LenientDataSourceCatalog.getReducedMetadata(Product, List)STYLEREC_CATCH_EXCEPTION372Medium
Method org.apache.oodt.cas.filemgr.catalog.LenientDataSourceCatalog.getReducedMetadata(Product, List) concatenates strings using + in a loopPERFORMANCESBSC_USE_STRINGBUFFER_CONCATENATION347Medium
Method org.apache.oodt.cas.filemgr.catalog.LenientDataSourceCatalog.getSqlQuery(QueryCriteria, ProductType) concatenates strings using + in a loopPERFORMANCESBSC_USE_STRINGBUFFER_CONCATENATION787Medium
Method org.apache.oodt.cas.filemgr.catalog.LenientDataSourceCatalog.addMetadataValue(String, Product, String) passes a nonconstant String to an execute method on an SQL statementSECURITYSQL_NONCONSTANT_STRING_PASSED_TO_EXECUTE447High
Method org.apache.oodt.cas.filemgr.catalog.LenientDataSourceCatalog.getMetadata(Product) passes a nonconstant String to an execute method on an SQL statementSECURITYSQL_NONCONSTANT_STRING_PASSED_TO_EXECUTE233High
Method org.apache.oodt.cas.filemgr.catalog.LenientDataSourceCatalog.getReducedMetadata(Product, List) passes a nonconstant String to an execute method on an SQL statementSECURITYSQL_NONCONSTANT_STRING_PASSED_TO_EXECUTE366High
Method org.apache.oodt.cas.filemgr.catalog.LenientDataSourceCatalog.getResultListSize(Query, ProductType) passes a nonconstant String to an execute method on an SQL statementSECURITYSQL_NONCONSTANT_STRING_PASSED_TO_EXECUTE715High
Method org.apache.oodt.cas.filemgr.catalog.LenientDataSourceCatalog.removeMetadataValue(String, Product, String) passes a nonconstant String to an execute method on an SQL statementSECURITYSQL_NONCONSTANT_STRING_PASSED_TO_EXECUTE524High
Method org.apache.oodt.cas.filemgr.catalog.LenientDataSourceCatalog.addMetadata(Metadata, Product) makes inefficient use of keySet iterator instead of entrySet iteratorPERFORMANCEWMI_WRONG_MAP_ITERATOR101Medium
Method org.apache.oodt.cas.filemgr.catalog.LenientDataSourceCatalog.removeMetadata(Metadata, Product) makes inefficient use of keySet iterator instead of entrySet iteratorPERFORMANCEWMI_WRONG_MAP_ITERATOR187Medium

org.apache.oodt.cas.filemgr.catalog.LuceneCatalog

BugCategoryDetailsLinePriority
Dead store to prevPage in org.apache.oodt.cas.filemgr.catalog.LuceneCatalog.getPrevPage(ProductType, ProductPage)STYLEDLS_DEAD_LOCAL_STORE897Medium
Exception is caught when Exception is not thrown in org.apache.oodt.cas.filemgr.catalog.LuceneCatalog.paginateQuery(Query, ProductType, int, ProductPage)STYLEREC_CATCH_EXCEPTION1354Medium
Private method org.apache.oodt.cas.filemgr.catalog.LuceneCatalog.getCompleteProductById(String) is never calledPERFORMANCEUPM_UNCALLED_PRIVATE_METHOD389Medium
Private method org.apache.oodt.cas.filemgr.catalog.LuceneCatalog.toCompleteProduct(Document) is never calledPERFORMANCEUPM_UNCALLED_PRIVATE_METHOD1019Medium

org.apache.oodt.cas.filemgr.catalog.LuceneCatalog$CompleteProduct

BugCategoryDetailsLinePriority
Should org.apache.oodt.cas.filemgr.catalog.LuceneCatalog$CompleteProduct be a _static_ inner class?PERFORMANCESIC_INNER_SHOULD_BE_STATIC1436-1492Medium

org.apache.oodt.cas.filemgr.catalog.MappedDataSourceCatalogFactory

BugCategoryDetailsLinePriority
new org.apache.oodt.cas.filemgr.catalog.MappedDataSourceCatalogFactory() may fail to close streamBAD_PRACTICEOS_OPEN_STREAM56Medium

org.apache.oodt.cas.filemgr.catalog.ScienceDataCatalog

BugCategoryDetailsLinePriority
Exception is caught when Exception is not thrown in org.apache.oodt.cas.filemgr.catalog.ScienceDataCatalog.addMetadata(Metadata, Product)STYLEREC_CATCH_EXCEPTION201Medium
Method org.apache.oodt.cas.filemgr.catalog.ScienceDataCatalog.createGranule(int, String) passes a nonconstant String to an execute method on an SQL statementSECURITYSQL_NONCONSTANT_STRING_PASSED_TO_EXECUTE223High
Method org.apache.oodt.cas.filemgr.catalog.ScienceDataCatalog.createParameter(int, String) passes a nonconstant String to an execute method on an SQL statementSECURITYSQL_NONCONSTANT_STRING_PASSED_TO_EXECUTE282High
Method org.apache.oodt.cas.filemgr.catalog.ScienceDataCatalog.getEndDateTime(Product) passes a nonconstant String to an execute method on an SQL statementSECURITYSQL_NONCONSTANT_STRING_PASSED_TO_EXECUTE1163High
Method org.apache.oodt.cas.filemgr.catalog.ScienceDataCatalog.getNumProducts(ProductType) passes a nonconstant String to an execute method on an SQL statementSECURITYSQL_NONCONSTANT_STRING_PASSED_TO_EXECUTE423High
Method org.apache.oodt.cas.filemgr.catalog.ScienceDataCatalog.getProductByName(String) passes a nonconstant String to an execute method on an SQL statementSECURITYSQL_NONCONSTANT_STRING_PASSED_TO_EXECUTE516High
Method org.apache.oodt.cas.filemgr.catalog.ScienceDataCatalog.getStartDateTime(Product) passes a nonconstant String to an execute method on an SQL statementSECURITYSQL_NONCONSTANT_STRING_PASSED_TO_EXECUTE1111High

org.apache.oodt.cas.filemgr.catalog.solr.DefaultProductSerializer

BugCategoryDetailsLinePriority
Call to method of static java.text.DateFormat in org.apache.oodt.cas.filemgr.catalog.solr.DefaultProductSerializer.serialize(Product, boolean)MT_CORRECTNESSSTCAL_INVOKE_ON_STATIC_DATE_FORMAT_INSTANCE85Medium
Method org.apache.oodt.cas.filemgr.catalog.solr.DefaultProductSerializer.generateInsertDocuments(String, Map) makes inefficient use of keySet iterator instead of entrySet iteratorPERFORMANCEWMI_WRONG_MAP_ITERATOR226Medium
Method org.apache.oodt.cas.filemgr.catalog.solr.DefaultProductSerializer.generateUpdateDocuments(String, Map, boolean) makes inefficient use of keySet iterator instead of entrySet iteratorPERFORMANCEWMI_WRONG_MAP_ITERATOR253Medium

org.apache.oodt.cas.filemgr.catalog.solr.Parameters

BugCategoryDetailsLinePriority
Found static field of type java.text.DateFormat in org.apache.oodt.cas.filemgr.catalog.solr.Parameters.SOLR_DATE_TIME_FORMATTERMT_CORRECTNESSSTCAL_STATIC_SIMPLE_DATE_FORMAT_INSTANCENot availableHigh

org.apache.oodt.cas.filemgr.catalog.solr.SolrCatalogFactory

BugCategoryDetailsLinePriority
org.apache.oodt.cas.filemgr.catalog.solr.SolrCatalogFactory.configure() invokes System.exit(...), which shuts down the entire virtual machineBAD_PRACTICEDM_EXIT66Medium

org.apache.oodt.cas.filemgr.catalog.solr.SolrClient

BugCategoryDetailsLinePriority
Method org.apache.oodt.cas.filemgr.catalog.solr.SolrClient.doGet(String, Map, String) makes inefficient use of keySet iterator instead of entrySet iteratorPERFORMANCEWMI_WRONG_MAP_ITERATOR238Medium

org.apache.oodt.cas.filemgr.datatransfer.LocalDataTransferer

BugCategoryDetailsLinePriority
Null pointer dereference of System.err in org.apache.oodt.cas.filemgr.datatransfer.LocalDataTransferer.main(String[])CORRECTNESSNP_ALWAYS_NULL239High

org.apache.oodt.cas.filemgr.datatransfer.S3DataTransferer

BugCategoryDetailsLinePriority

org.apache.oodt.cas.filemgr.ingest.CachedIngester

BugCategoryDetailsLinePriority
org.apache.oodt.cas.filemgr.ingest.CachedIngester.hasProduct(URL, String) invokes java.net.URL.equals(Object), which blocks to do domain name resolutionPERFORMANCEDMI_BLOCKING_METHODS_ON_URL115High
new org.apache.oodt.cas.filemgr.ingest.CachedIngester(String, String, String) may fail to close streamBAD_PRACTICEOS_OPEN_STREAM69Medium

org.apache.oodt.cas.filemgr.ingest.CmdLineIngester

BugCategoryDetailsLinePriority
Null pointer dereference of System.err in org.apache.oodt.cas.filemgr.ingest.CmdLineIngester.main(String[])CORRECTNESSNP_ALWAYS_NULL102High
Null pointer dereference of System.out in org.apache.oodt.cas.filemgr.ingest.CmdLineIngester.main(String[])CORRECTNESSNP_ALWAYS_NULL127High

org.apache.oodt.cas.filemgr.ingest.RmiCacheServer

BugCategoryDetailsLinePriority
Null pointer dereference of System.out in org.apache.oodt.cas.filemgr.ingest.RmiCacheServer.launchRmiServer(int)CORRECTNESSNP_ALWAYS_NULL188High
Class org.apache.oodt.cas.filemgr.ingest.RmiCacheServer defines non-transient non-serializable instance field cacheBAD_PRACTICESE_BAD_FIELDNot availableHigh

org.apache.oodt.cas.filemgr.ingest.RmiCacheServerFactory

BugCategoryDetailsLinePriority
Null pointer dereference of System.err in org.apache.oodt.cas.filemgr.ingest.RmiCacheServerFactory.main(String[])CORRECTNESSNP_ALWAYS_NULL85High
Null pointer dereference of System.out in org.apache.oodt.cas.filemgr.ingest.RmiCacheServerFactory.main(String[])CORRECTNESSNP_ALWAYS_NULL75High

org.apache.oodt.cas.filemgr.ingest.StdIngester

BugCategoryDetailsLinePriority
org.apache.oodt.cas.filemgr.ingest.StdIngester.checkOrSetFileManager(URL) invokes java.net.URL.equals(Object), which blocks to do domain name resolutionPERFORMANCEDMI_BLOCKING_METHODS_ON_URL234High

org.apache.oodt.cas.filemgr.repository.DataSourceRepositoryManager

BugCategoryDetailsLinePriority
org.apache.oodt.cas.filemgr.repository.DataSourceRepositoryManager.addProductType(ProductType) invokes inefficient new String() constructorPERFORMANCEDM_STRING_VOID_CTOR100Medium
Method org.apache.oodt.cas.filemgr.repository.DataSourceRepositoryManager.addProductType(ProductType) passes a nonconstant String to an execute method on an SQL statementSECURITYSQL_NONCONSTANT_STRING_PASSED_TO_EXECUTE98High
Method org.apache.oodt.cas.filemgr.repository.DataSourceRepositoryManager.getProductTypeByName(String) passes a nonconstant String to an execute method on an SQL statementSECURITYSQL_NONCONSTANT_STRING_PASSED_TO_EXECUTE402High
Method org.apache.oodt.cas.filemgr.repository.DataSourceRepositoryManager.modifyProductType(ProductType) passes a nonconstant String to an execute method on an SQL statementSECURITYSQL_NONCONSTANT_STRING_PASSED_TO_EXECUTE201High

org.apache.oodt.cas.filemgr.repository.ScienceDataRepositoryManager

BugCategoryDetailsLinePriority
Method org.apache.oodt.cas.filemgr.repository.ScienceDataRepositoryManager.addProductType(ProductType) passes a nonconstant String to an execute method on an SQL statementSECURITYSQL_NONCONSTANT_STRING_PASSED_TO_EXECUTE78High
Method org.apache.oodt.cas.filemgr.repository.ScienceDataRepositoryManager.getProductTypeByName(String) passes a nonconstant String to an execute method on an SQL statementSECURITYSQL_NONCONSTANT_STRING_PASSED_TO_EXECUTE177High
Method org.apache.oodt.cas.filemgr.repository.ScienceDataRepositoryManager.modifyProductType(ProductType) passes a nonconstant String to an execute method on an SQL statementSECURITYSQL_NONCONSTANT_STRING_PASSED_TO_EXECUTE284High

org.apache.oodt.cas.filemgr.structs.BooleanQueryCriteria

BugCategoryDetailsLinePriority
org.apache.oodt.cas.filemgr.structs.BooleanQueryCriteria.toString() invokes inefficient new String() constructorPERFORMANCEDM_STRING_VOID_CTOR162Medium
Method org.apache.oodt.cas.filemgr.structs.BooleanQueryCriteria.toString() concatenates strings using + in a loopPERFORMANCESBSC_USE_STRINGBUFFER_CONCATENATION173Medium

org.apache.oodt.cas.filemgr.structs.FreeTextQueryCriteria

BugCategoryDetailsLinePriority
new org.apache.oodt.cas.filemgr.structs.FreeTextQueryCriteria() invokes inefficient new String() constructorPERFORMANCEDM_STRING_VOID_CTOR56Medium
Method org.apache.oodt.cas.filemgr.structs.FreeTextQueryCriteria.toString() concatenates strings using + in a loopPERFORMANCESBSC_USE_STRINGBUFFER_CONCATENATION169Medium
Write to static field org.apache.oodt.cas.filemgr.structs.FreeTextQueryCriteria.noiseWordHash from instance method new org.apache.oodt.cas.filemgr.structs.FreeTextQueryCriteria()STYLEST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD59High
Write to static field org.apache.oodt.cas.filemgr.structs.FreeTextQueryCriteria.noiseWordHash from instance method new org.apache.oodt.cas.filemgr.structs.FreeTextQueryCriteria(String, List)STYLEST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD76High

org.apache.oodt.cas.filemgr.structs.Reference

BugCategoryDetailsLinePriority
Exception is caught when Exception is not thrown in org.apache.oodt.cas.filemgr.structs.Reference.<static initializer>()STYLEREC_CATCH_EXCEPTION68Medium

org.apache.oodt.cas.filemgr.structs.query.QueryResult

BugCategoryDetailsLinePriority
org.apache.oodt.cas.filemgr.structs.query.QueryResult defines equals and uses Object.hashCode()BAD_PRACTICEHE_EQUALS_USE_HASHCODE97-119High

org.apache.oodt.cas.filemgr.structs.query.QueryResultComparator

BugCategoryDetailsLinePriority
Comparison of String objects using == or != in org.apache.oodt.cas.filemgr.structs.query.QueryResultComparator.compare(QueryResult, QueryResult) BAD_PRACTICEES_COMPARING_STRINGS_WITH_EQ48Medium
org.apache.oodt.cas.filemgr.structs.query.QueryResultComparator implements Comparator but not SerializableBAD_PRACTICESE_COMPARATOR_SHOULD_BE_SERIALIZABLE33-55Medium

org.apache.oodt.cas.filemgr.structs.query.filter.ObjectTimeEvent

BugCategoryDetailsLinePriority
org.apache.oodt.cas.filemgr.structs.query.filter.ObjectTimeEvent defines equals and uses Object.hashCode()BAD_PRACTICEHE_EQUALS_USE_HASHCODE47-51High

org.apache.oodt.cas.filemgr.structs.query.filter.TimeEvent

BugCategoryDetailsLinePriority
Method org.apache.oodt.cas.filemgr.structs.query.filter.TimeEvent.compareTo(TimeEvent) invokes inefficient new Long(long) constructor; use Long.valueOf(long) insteadPERFORMANCEDM_NUMBER_CTOR85Medium
org.apache.oodt.cas.filemgr.structs.query.filter.TimeEvent defines equals and uses Object.hashCode()BAD_PRACTICEHE_EQUALS_USE_HASHCODE68-72High

org.apache.oodt.cas.filemgr.system.XmlRpcFileManager

BugCategoryDetailsLinePriority
Dead store to manager in org.apache.oodt.cas.filemgr.system.XmlRpcFileManager.main(String[])STYLEDLS_DEAD_LOCAL_STORE1020Medium
Null pointer dereference of System.err in org.apache.oodt.cas.filemgr.system.XmlRpcFileManager.main(String[])CORRECTNESSNP_ALWAYS_NULL1015High
org.apache.oodt.cas.filemgr.system.XmlRpcFileManager.loadConfiguration() may fail to close streamBAD_PRACTICEOS_OPEN_STREAM1337Medium
org.apache.oodt.cas.filemgr.system.XmlRpcFileManager.transferFile(String, byte[], int, int) may fail to close streamBAD_PRACTICEOS_OPEN_STREAM817Medium
Exception is caught when Exception is not thrown in org.apache.oodt.cas.filemgr.system.XmlRpcFileManager.ingestProduct(Hashtable, Hashtable, boolean)STYLEREC_CATCH_EXCEPTION774Medium
org.apache.oodt.cas.filemgr.system.XmlRpcFileManager.transferFile(String, byte[], int, int) ignores exceptional return value of java.io.File.mkdirs()BAD_PRACTICERV_RETURN_VALUE_IGNORED_BAD_PRACTICE831Medium
org.apache.oodt.cas.filemgr.system.XmlRpcFileManager.retrieveFile(String, int, int) ignores result of java.io.FileInputStream.skip(long)BAD_PRACTICESR_NOT_CHECKED787Medium

org.apache.oodt.cas.filemgr.system.XmlRpcFileManagerClient

BugCategoryDetailsLinePriority
Dead store to numProducts in org.apache.oodt.cas.filemgr.system.XmlRpcFileManagerClient.getNumProducts(ProductType)STYLEDLS_DEAD_LOCAL_STORE622Medium
Dead store to productTypeHash in org.apache.oodt.cas.filemgr.system.XmlRpcFileManagerClient.getProductTypeById(String)STYLEDLS_DEAD_LOCAL_STORE1071Medium
Dead store to productTypeHash in org.apache.oodt.cas.filemgr.system.XmlRpcFileManagerClient.getProductTypeByName(String)STYLEDLS_DEAD_LOCAL_STORE1048Medium
Method org.apache.oodt.cas.filemgr.system.XmlRpcFileManagerClient.getNumProducts(ProductType) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) insteadPERFORMANCEDM_NUMBER_CTOR622Medium
Method org.apache.oodt.cas.filemgr.system.XmlRpcFileManagerClient.getTopNProducts(int) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) insteadPERFORMANCEDM_NUMBER_CTOR639Medium
Method org.apache.oodt.cas.filemgr.system.XmlRpcFileManagerClient.getTopNProducts(int, ProductType) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) insteadPERFORMANCEDM_NUMBER_CTOR661Medium
Method org.apache.oodt.cas.filemgr.system.XmlRpcFileManagerClient.pagedQuery(Query, ProductType, int) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) insteadPERFORMANCEDM_NUMBER_CTOR461Medium
Method org.apache.oodt.cas.filemgr.system.XmlRpcFileManagerClient.retrieveFile(String, int, int) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) insteadPERFORMANCEDM_NUMBER_CTOR840Medium
Method org.apache.oodt.cas.filemgr.system.XmlRpcFileManagerClient.transferFile(String, byte[], int, int) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) insteadPERFORMANCEDM_NUMBER_CTOR857Medium
new org.apache.oodt.cas.filemgr.system.XmlRpcFileManagerClient(URL, boolean) may fail to close streamBAD_PRACTICEOS_OPEN_STREAM113Medium
Exception is caught when Exception is not thrown in org.apache.oodt.cas.filemgr.system.XmlRpcFileManagerClient.ingestProduct(Product, Metadata, boolean)STYLEREC_CATCH_EXCEPTION1299Medium

org.apache.oodt.cas.filemgr.tools.CASAnalyzer

BugCategoryDetailsLinePriority
org.apache.oodt.cas.filemgr.tools.CASAnalyzer.STOP_WORDS should be package protectedMALICIOUS_CODEMS_PKGPROTECT50Medium

org.apache.oodt.cas.filemgr.tools.CatalogSearch

BugCategoryDetailsLinePriority
Dead store to cs in org.apache.oodt.cas.filemgr.tools.CatalogSearch.main(String[])STYLEDLS_DEAD_LOCAL_STORE354High
Dead store to results in org.apache.oodt.cas.filemgr.tools.CatalogSearch.PostQuery(String, Query)STYLEDLS_DEAD_LOCAL_STORE91Medium
Dead store to products in org.apache.oodt.cas.filemgr.tools.CatalogSearch.listElements()STYLEDLS_DEAD_LOCAL_STORE154Medium
org.apache.oodt.cas.filemgr.tools.CatalogSearch.CommandParser(String) invokes inefficient new String() constructorPERFORMANCEDM_STRING_VOID_CTOR333Medium
Null pointer dereference of System.out in org.apache.oodt.cas.filemgr.tools.CatalogSearch.CommandParser(String)CORRECTNESSNP_ALWAYS_NULL303High
Null pointer dereference of System.out in org.apache.oodt.cas.filemgr.tools.CatalogSearch.CommandParser(String)CORRECTNESSNP_ALWAYS_NULL309High
Null pointer dereference of System.out in org.apache.oodt.cas.filemgr.tools.CatalogSearch.CommandParser(String)CORRECTNESSNP_ALWAYS_NULL316High
Null pointer dereference of System.out in org.apache.oodt.cas.filemgr.tools.CatalogSearch.CommandParser(String)CORRECTNESSNP_ALWAYS_NULL323High
Null pointer dereference of System.out in org.apache.oodt.cas.filemgr.tools.CatalogSearch.CommandParser(String)CORRECTNESSNP_ALWAYS_NULL330High
Null pointer dereference of System.out in org.apache.oodt.cas.filemgr.tools.CatalogSearch.CommandParser(String)CORRECTNESSNP_ALWAYS_NULL337High
Null pointer dereference of System.out in org.apache.oodt.cas.filemgr.tools.CatalogSearch.GenerateCASQuery(Query, Query)CORRECTNESSNP_ALWAYS_NULL278High
Null pointer dereference of System.out in org.apache.oodt.cas.filemgr.tools.CatalogSearch.ListProducts()CORRECTNESSNP_ALWAYS_NULL142High
Null pointer dereference of System.out in org.apache.oodt.cas.filemgr.tools.CatalogSearch.ListProducts()CORRECTNESSNP_ALWAYS_NULL147High
Null pointer dereference of System.out in org.apache.oodt.cas.filemgr.tools.CatalogSearch.ParseQuery(String)CORRECTNESSNP_ALWAYS_NULL236High
Null pointer dereference of System.out in org.apache.oodt.cas.filemgr.tools.CatalogSearch.PostQuery(String, Query)CORRECTNESSNP_ALWAYS_NULL97High
Null pointer dereference of System.out in org.apache.oodt.cas.filemgr.tools.CatalogSearch.PostQuery(String, Query)CORRECTNESSNP_ALWAYS_NULL104High
Null pointer dereference of System.out in org.apache.oodt.cas.filemgr.tools.CatalogSearch.PostQuery(String, Query)CORRECTNESSNP_ALWAYS_NULL110High
Null pointer dereference of System.out in org.apache.oodt.cas.filemgr.tools.CatalogSearch.PostQuery(String, Query)CORRECTNESSNP_ALWAYS_NULL112High
Null pointer dereference of System.out in org.apache.oodt.cas.filemgr.tools.CatalogSearch.PostQuery(Query)CORRECTNESSNP_ALWAYS_NULL79High
Null pointer dereference of System.out in org.apache.oodt.cas.filemgr.tools.CatalogSearch.listElements()CORRECTNESSNP_ALWAYS_NULL161High
Null pointer dereference of System.out in org.apache.oodt.cas.filemgr.tools.CatalogSearch.listElements(String)CORRECTNESSNP_ALWAYS_NULL176High
Null pointer dereference of System.out in org.apache.oodt.cas.filemgr.tools.CatalogSearch.listElements(String)CORRECTNESSNP_ALWAYS_NULL185High
Null pointer dereference of System.err in org.apache.oodt.cas.filemgr.tools.CatalogSearch.main(String[])CORRECTNESSNP_ALWAYS_NULL364High
Null pointer dereference of System.out in org.apache.oodt.cas.filemgr.tools.CatalogSearch.main(String[])CORRECTNESSNP_ALWAYS_NULL373High
Null pointer dereference of System.out in org.apache.oodt.cas.filemgr.tools.CatalogSearch.main(String[])CORRECTNESSNP_ALWAYS_NULL381High
Null pointer dereference of System.out in org.apache.oodt.cas.filemgr.tools.CatalogSearch.printHelp()CORRECTNESSNP_ALWAYS_NULL219High
Null pointer dereference of System.out in org.apache.oodt.cas.filemgr.tools.CatalogSearch.setFilter(String)CORRECTNESSNP_ALWAYS_NULL126High
Null pointer dereference of System.out in org.apache.oodt.cas.filemgr.tools.CatalogSearch.setFilter(String)CORRECTNESSNP_ALWAYS_NULL130High
Method org.apache.oodt.cas.filemgr.tools.CatalogSearch.CommandParser(String) concatenates strings using + in a loopPERFORMANCESBSC_USE_STRINGBUFFER_CONCATENATION335Medium

org.apache.oodt.cas.filemgr.tools.DeleteProduct

BugCategoryDetailsLinePriority
Null pointer dereference of System.err in org.apache.oodt.cas.filemgr.tools.DeleteProduct.main(String[])CORRECTNESSNP_ALWAYS_NULL106High
Write to static field org.apache.oodt.cas.filemgr.tools.DeleteProduct.client from instance method new org.apache.oodt.cas.filemgr.tools.DeleteProduct(String, boolean)STYLEST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD65High

org.apache.oodt.cas.filemgr.tools.DumpDbElementsToXml

BugCategoryDetailsLinePriority
Null pointer dereference of System.err in org.apache.oodt.cas.filemgr.tools.DumpDbElementsToXml.main(String[])CORRECTNESSNP_ALWAYS_NULL63High
Null pointer dereference of System.out in org.apache.oodt.cas.filemgr.tools.DumpDbElementsToXml.main(String[])CORRECTNESSNP_ALWAYS_NULL67High

org.apache.oodt.cas.filemgr.tools.ExpImpCatalog

BugCategoryDetailsLinePriority
Null pointer dereference of System.err in org.apache.oodt.cas.filemgr.tools.ExpImpCatalog.main(String[])CORRECTNESSNP_ALWAYS_NULL361High

org.apache.oodt.cas.filemgr.tools.MetadataBasedProductMover

BugCategoryDetailsLinePriority
Null pointer dereference of System.err in org.apache.oodt.cas.filemgr.tools.MetadataBasedProductMover.main(String[])CORRECTNESSNP_ALWAYS_NULL166High

org.apache.oodt.cas.filemgr.tools.MetadataDumper

BugCategoryDetailsLinePriority
Null pointer dereference of System.err in org.apache.oodt.cas.filemgr.tools.MetadataDumper.main(String[])CORRECTNESSNP_ALWAYS_NULL157High

org.apache.oodt.cas.filemgr.tools.OptimizeLuceneCatalog

BugCategoryDetailsLinePriority
Null pointer dereference of System.err in org.apache.oodt.cas.filemgr.tools.OptimizeLuceneCatalog.main(String[])CORRECTNESSNP_ALWAYS_NULL104High

org.apache.oodt.cas.filemgr.tools.ProductDumper

BugCategoryDetailsLinePriority
Null pointer dereference of System.err in org.apache.oodt.cas.filemgr.tools.ProductDumper.main(String[])CORRECTNESSNP_ALWAYS_NULL169High

org.apache.oodt.cas.filemgr.tools.ProductTypeDocTool

BugCategoryDetailsLinePriority
Null pointer dereference of System.err in org.apache.oodt.cas.filemgr.tools.ProductTypeDocTool.main(String[])CORRECTNESSNP_ALWAYS_NULL113High
org.apache.oodt.cas.filemgr.tools.ProductTypeDocTool.doProductTypeDoc(String, String) ignores exceptional return value of java.io.File.delete()BAD_PRACTICERV_RETURN_VALUE_IGNORED_BAD_PRACTICE90Medium

org.apache.oodt.cas.filemgr.tools.QueryTool

BugCategoryDetailsLinePriority
Dead store to products in org.apache.oodt.cas.filemgr.tools.QueryTool.query(Query)STYLEDLS_DEAD_LOCAL_STORE99Medium
Null pointer dereference of System.err in org.apache.oodt.cas.filemgr.tools.QueryTool.exit(String)CORRECTNESSNP_ALWAYS_NULL260High
Null pointer dereference of System.out in org.apache.oodt.cas.filemgr.tools.QueryTool.main(String[])CORRECTNESSNP_ALWAYS_NULL238High
Null pointer dereference of System.out in org.apache.oodt.cas.filemgr.tools.QueryTool.main(String[])CORRECTNESSNP_ALWAYS_NULL242High
Null pointer dereference of System.out in org.apache.oodt.cas.filemgr.tools.QueryTool.parseQuery(String)CORRECTNESSNP_ALWAYS_NULL91High

org.apache.oodt.cas.filemgr.tools.RangeQueryTester

BugCategoryDetailsLinePriority
Null pointer dereference of System.err in org.apache.oodt.cas.filemgr.tools.RangeQueryTester.main(String[])CORRECTNESSNP_ALWAYS_NULL200High
Null pointer dereference of System.out in org.apache.oodt.cas.filemgr.tools.RangeQueryTester.main(String[])CORRECTNESSNP_ALWAYS_NULL218High
Null pointer dereference of System.out in org.apache.oodt.cas.filemgr.tools.RangeQueryTester.main(String[])CORRECTNESSNP_ALWAYS_NULL221High

org.apache.oodt.cas.filemgr.tools.SolrIndexer

BugCategoryDetailsLinePriority
Exception is caught when Exception is not thrown in org.apache.oodt.cas.filemgr.tools.SolrIndexer.deleteProductByName(String)STYLEREC_CATCH_EXCEPTION506Medium
Exception is caught when Exception is not thrown in org.apache.oodt.cas.filemgr.tools.SolrIndexer.indexProductByName(String, boolean)STYLEREC_CATCH_EXCEPTION418Medium

org.apache.oodt.cas.filemgr.tools.SolrIndexer$IndexerConfig

BugCategoryDetailsLinePriority
Should org.apache.oodt.cas.filemgr.tools.SolrIndexer$IndexerConfig be a _static_ inner class?PERFORMANCESIC_INNER_SHOULD_BE_STATIC710-794Medium

org.apache.oodt.cas.filemgr.util.SqlParser

BugCategoryDetailsLinePriority
org.apache.oodt.cas.filemgr.util.SqlParser.toPostFix(String) invokes inefficient new String(String) constructorPERFORMANCEDM_STRING_CTOR256Medium
Null pointer dereference of System.out in org.apache.oodt.cas.filemgr.util.SqlParser.main(String[])CORRECTNESSNP_ALWAYS_NULL453High
Method org.apache.oodt.cas.filemgr.util.SqlParser.getInfixCriteriaString(QueryCriteria) concatenates strings using + in a loopPERFORMANCESBSC_USE_STRINGBUFFER_CONCATENATION171Medium
Method org.apache.oodt.cas.filemgr.util.SqlParser.listToString(List) concatenates strings using + in a loopPERFORMANCESBSC_USE_STRINGBUFFER_CONCATENATION331Medium

org.apache.oodt.cas.filemgr.util.XmlRpcStructFactory

BugCategoryDetailsLinePriority
Method org.apache.oodt.cas.filemgr.util.XmlRpcStructFactory.getXmlRpcProductPage(ProductPage) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) insteadPERFORMANCEDM_NUMBER_CTOR119Medium
Method org.apache.oodt.cas.filemgr.util.XmlRpcStructFactory.getXmlRpcQueryCriteria(QueryCriteria) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) insteadPERFORMANCEDM_NUMBER_CTOR663Medium
Null pointer dereference of System.out in org.apache.oodt.cas.filemgr.util.XmlRpcStructFactory.getQueryCriteriaFromXmlRpc(Hashtable)CORRECTNESSNP_ALWAYS_NULL701High
Null pointer dereference of System.out in org.apache.oodt.cas.filemgr.util.XmlRpcStructFactory.getQueryCriteriaFromXmlRpc(Hashtable)CORRECTNESSNP_ALWAYS_NULL711High
Method org.apache.oodt.cas.filemgr.util.XmlRpcStructFactory.getPropertiesFromXmlRpc(Hashtable) makes inefficient use of keySet iterator instead of entrySet iteratorPERFORMANCEWMI_WRONG_MAP_ITERATOR496Medium

org.apache.oodt.cas.filemgr.util.XmlStructFactory

BugCategoryDetailsLinePriority
Method org.apache.oodt.cas.filemgr.util.XmlStructFactory.getProductTypeMapXmlDocument(HashMap, HashMap) makes inefficient use of keySet iterator instead of entrySet iteratorPERFORMANCEWMI_WRONG_MAP_ITERATOR262Medium

org.apache.oodt.cas.filemgr.validation.DataSourceValidationLayer

BugCategoryDetailsLinePriority
org.apache.oodt.cas.filemgr.validation.DataSourceValidationLayer.addElement(Element) invokes inefficient new String() constructorPERFORMANCEDM_STRING_VOID_CTOR95Medium
Method org.apache.oodt.cas.filemgr.validation.DataSourceValidationLayer.addElement(Element) passes a nonconstant String to an execute method on an SQL statementSECURITYSQL_NONCONSTANT_STRING_PASSED_TO_EXECUTE93High
Method org.apache.oodt.cas.filemgr.validation.DataSourceValidationLayer.addElementToProductType(ProductType, Element) passes a nonconstant String to an execute method on an SQL statementSECURITYSQL_NONCONSTANT_STRING_PASSED_TO_EXECUTE300High
Method org.apache.oodt.cas.filemgr.validation.DataSourceValidationLayer.addParentToProductType(ProductType, String) passes a nonconstant String to an execute method on an SQL statementSECURITYSQL_NONCONSTANT_STRING_PASSED_TO_EXECUTE427High
Method org.apache.oodt.cas.filemgr.validation.DataSourceValidationLayer.getElements(ProductType) passes a nonconstant String to an execute method on an SQL statementSECURITYSQL_NONCONSTANT_STRING_PASSED_TO_EXECUTE554High
Method org.apache.oodt.cas.filemgr.validation.DataSourceValidationLayer.modifyElement(Element) passes a nonconstant String to an execute method on an SQL statementSECURITYSQL_NONCONSTANT_STRING_PASSED_TO_EXECUTE176High
Method org.apache.oodt.cas.filemgr.validation.DataSourceValidationLayer.removeElementFromProductType(ProductType, Element) passes a nonconstant String to an execute method on an SQL statementSECURITYSQL_NONCONSTANT_STRING_PASSED_TO_EXECUTE367High
Method org.apache.oodt.cas.filemgr.validation.DataSourceValidationLayer.removeParentFromProductType(ProductType, String) passes a nonconstant String to an execute method on an SQL statementSECURITYSQL_NONCONSTANT_STRING_PASSED_TO_EXECUTE485High

org.apache.oodt.cas.filemgr.validation.ScienceDataValidationLayer

BugCategoryDetailsLinePriority
Method org.apache.oodt.cas.filemgr.validation.ScienceDataValidationLayer.addElement(Element) passes a nonconstant String to an execute method on an SQL statementSECURITYSQL_NONCONSTANT_STRING_PASSED_TO_EXECUTE73High
Method org.apache.oodt.cas.filemgr.validation.ScienceDataValidationLayer.getElementByName(String) passes a nonconstant String to an execute method on an SQL statementSECURITYSQL_NONCONSTANT_STRING_PASSED_TO_EXECUTE211High
Method org.apache.oodt.cas.filemgr.validation.ScienceDataValidationLayer.modifyElement(Element) passes a nonconstant String to an execute method on an SQL statementSECURITYSQL_NONCONSTANT_STRING_PASSED_TO_EXECUTE371High
Method org.apache.oodt.cas.filemgr.validation.ScienceDataValidationLayer.addElementToProductType(ProductType, Element) passes a nonconstant String to an execute method on an SQL statementSECURITYSQL_NONCONSTANT_STRING_PASSED_TO_EXECUTE114Medium

org.apache.oodt.cas.filemgr.versioning.AcquisitionDateVersioner

BugCategoryDetailsLinePriority
org.apache.oodt.cas.filemgr.versioning.AcquisitionDateVersioner.ACQ_DATE_FORMAT isn't final but should beMALICIOUS_CODEMS_SHOULD_BE_FINAL59High