The following document contains the results of FindBugs Report
FindBugs Version is 1.3.9
Threshold is
Effort is min
Files
org.apache.oodt.cas.filemgr.catalog.DataSourceCatalog
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
org.apache.oodt.cas.filemgr.catalog.DataSourceCatalog.addProduct(Product) invokes inefficient new String() constructor | PERFORMANCE | DM_STRING_VOID_CTOR | 289 | Medium |
Exception is caught when Exception is not thrown in org.apache.oodt.cas.filemgr.catalog.DataSourceCatalog.paginateQuery(Query, ProductType, int) | STYLE | REC_CATCH_EXCEPTION | 2090 | Medium |
Method org.apache.oodt.cas.filemgr.catalog.DataSourceCatalog.getReducedMetadata(Product, List) concatenates strings using + in a loop | PERFORMANCE | SBSC_USE_STRINGBUFFER_CONCATENATION | 1160 | Medium |
Method org.apache.oodt.cas.filemgr.catalog.DataSourceCatalog.getSqlQuery(QueryCriteria, ProductType) concatenates strings using + in a loop | PERFORMANCE | SBSC_USE_STRINGBUFFER_CONCATENATION | 2151 | Medium |
Method org.apache.oodt.cas.filemgr.catalog.DataSourceCatalog.addMetadataValue(Element, Product, String) passes a nonconstant String to an execute method on an SQL statement | SECURITY | SQL_NONCONSTANT_STRING_PASSED_TO_EXECUTE | 1398 | High |
Method org.apache.oodt.cas.filemgr.catalog.DataSourceCatalog.addProduct(Product) passes a nonconstant String to an execute method on an SQL statement | SECURITY | SQL_NONCONSTANT_STRING_PASSED_TO_EXECUTE | 286 | High |
Method org.apache.oodt.cas.filemgr.catalog.DataSourceCatalog.addProductReferences(Product) passes a nonconstant String to an execute method on an SQL statement | SECURITY | SQL_NONCONSTANT_STRING_PASSED_TO_EXECUTE | 618 | High |
Method org.apache.oodt.cas.filemgr.catalog.DataSourceCatalog.getNumProducts(ProductType) passes a nonconstant String to an execute method on an SQL statement | SECURITY | SQL_NONCONSTANT_STRING_PASSED_TO_EXECUTE | 1532 | High |
Method org.apache.oodt.cas.filemgr.catalog.DataSourceCatalog.getProductByName(String) passes a nonconstant String to an execute method on an SQL statement | SECURITY | SQL_NONCONSTANT_STRING_PASSED_TO_EXECUTE | 763 | High |
Method org.apache.oodt.cas.filemgr.catalog.DataSourceCatalog.getProductsByProductType(ProductType) passes a nonconstant String to an execute method on an SQL statement | SECURITY | SQL_NONCONSTANT_STRING_PASSED_TO_EXECUTE | 1002 | High |
Method org.apache.oodt.cas.filemgr.catalog.DataSourceCatalog.getReducedMetadata(Product, List) passes a nonconstant String to an execute method on an SQL statement | SECURITY | SQL_NONCONSTANT_STRING_PASSED_TO_EXECUTE | 1169 | High |
Method org.apache.oodt.cas.filemgr.catalog.DataSourceCatalog.getResultListSize(Query, ProductType) passes a nonconstant String to an execute method on an SQL statement | SECURITY | SQL_NONCONSTANT_STRING_PASSED_TO_EXECUTE | 1860 | High |
Method org.apache.oodt.cas.filemgr.catalog.DataSourceCatalog.getTopNProducts(int, ProductType) passes a nonconstant String to an execute method on an SQL statement | SECURITY | SQL_NONCONSTANT_STRING_PASSED_TO_EXECUTE | 1294 | High |
Method org.apache.oodt.cas.filemgr.catalog.DataSourceCatalog.modifyProduct(Product) passes a nonconstant String to an execute method on an SQL statement | SECURITY | SQL_NONCONSTANT_STRING_PASSED_TO_EXECUTE | 401 | High |
Method org.apache.oodt.cas.filemgr.catalog.DataSourceCatalog.removeMetadataValue(Element, Product, String) passes a nonconstant String to an execute method on an SQL statement | SECURITY | SQL_NONCONSTANT_STRING_PASSED_TO_EXECUTE | 1465 | High |
Method org.apache.oodt.cas.filemgr.catalog.DataSourceCatalog.setProductTransferStatus(Product) passes a nonconstant String to an execute method on an SQL statement | SECURITY | SQL_NONCONSTANT_STRING_PASSED_TO_EXECUTE | 538 | High |
Method org.apache.oodt.cas.filemgr.catalog.DataSourceCatalog.updateReferences(Product) passes a nonconstant String to an execute method on an SQL statement | SECURITY | SQL_NONCONSTANT_STRING_PASSED_TO_EXECUTE | 2226 | High |
Method org.apache.oodt.cas.filemgr.catalog.DataSourceCatalog.paginateQuery(Query, ProductType, int) passes a nonconstant String to an execute method on an SQL statement | SECURITY | SQL_NONCONSTANT_STRING_PASSED_TO_EXECUTE | 2046 | Medium |
org.apache.oodt.cas.filemgr.catalog.LenientDataSourceCatalog
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Exception is caught when Exception is not thrown in org.apache.oodt.cas.filemgr.catalog.LenientDataSourceCatalog.getReducedMetadata(Product, List) | STYLE | REC_CATCH_EXCEPTION | 372 | Medium |
Method org.apache.oodt.cas.filemgr.catalog.LenientDataSourceCatalog.getReducedMetadata(Product, List) concatenates strings using + in a loop | PERFORMANCE | SBSC_USE_STRINGBUFFER_CONCATENATION | 347 | Medium |
Method org.apache.oodt.cas.filemgr.catalog.LenientDataSourceCatalog.getSqlQuery(QueryCriteria, ProductType) concatenates strings using + in a loop | PERFORMANCE | SBSC_USE_STRINGBUFFER_CONCATENATION | 787 | Medium |
Method org.apache.oodt.cas.filemgr.catalog.LenientDataSourceCatalog.addMetadataValue(String, Product, String) passes a nonconstant String to an execute method on an SQL statement | SECURITY | SQL_NONCONSTANT_STRING_PASSED_TO_EXECUTE | 447 | High |
Method org.apache.oodt.cas.filemgr.catalog.LenientDataSourceCatalog.getMetadata(Product) passes a nonconstant String to an execute method on an SQL statement | SECURITY | SQL_NONCONSTANT_STRING_PASSED_TO_EXECUTE | 233 | High |
Method org.apache.oodt.cas.filemgr.catalog.LenientDataSourceCatalog.getReducedMetadata(Product, List) passes a nonconstant String to an execute method on an SQL statement | SECURITY | SQL_NONCONSTANT_STRING_PASSED_TO_EXECUTE | 366 | High |
Method org.apache.oodt.cas.filemgr.catalog.LenientDataSourceCatalog.getResultListSize(Query, ProductType) passes a nonconstant String to an execute method on an SQL statement | SECURITY | SQL_NONCONSTANT_STRING_PASSED_TO_EXECUTE | 715 | High |
Method org.apache.oodt.cas.filemgr.catalog.LenientDataSourceCatalog.removeMetadataValue(String, Product, String) passes a nonconstant String to an execute method on an SQL statement | SECURITY | SQL_NONCONSTANT_STRING_PASSED_TO_EXECUTE | 524 | High |
Method org.apache.oodt.cas.filemgr.catalog.LenientDataSourceCatalog.addMetadata(Metadata, Product) makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 101 | Medium |
Method org.apache.oodt.cas.filemgr.catalog.LenientDataSourceCatalog.removeMetadata(Metadata, Product) makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 187 | Medium |
org.apache.oodt.cas.filemgr.catalog.LuceneCatalog
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Dead store to prevPage in org.apache.oodt.cas.filemgr.catalog.LuceneCatalog.getPrevPage(ProductType, ProductPage) | STYLE | DLS_DEAD_LOCAL_STORE | 897 | Medium |
Exception is caught when Exception is not thrown in org.apache.oodt.cas.filemgr.catalog.LuceneCatalog.paginateQuery(Query, ProductType, int, ProductPage) | STYLE | REC_CATCH_EXCEPTION | 1354 | Medium |
Private method org.apache.oodt.cas.filemgr.catalog.LuceneCatalog.getCompleteProductById(String) is never called | PERFORMANCE | UPM_UNCALLED_PRIVATE_METHOD | 389 | Medium |
Private method org.apache.oodt.cas.filemgr.catalog.LuceneCatalog.toCompleteProduct(Document) is never called | PERFORMANCE | UPM_UNCALLED_PRIVATE_METHOD | 1019 | Medium |
org.apache.oodt.cas.filemgr.catalog.LuceneCatalog$CompleteProduct
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Should org.apache.oodt.cas.filemgr.catalog.LuceneCatalog$CompleteProduct be a _static_ inner class? | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC | 1436-1492 | Medium |
org.apache.oodt.cas.filemgr.catalog.MappedDataSourceCatalogFactory
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
new org.apache.oodt.cas.filemgr.catalog.MappedDataSourceCatalogFactory() may fail to close stream | BAD_PRACTICE | OS_OPEN_STREAM | 56 | Medium |
org.apache.oodt.cas.filemgr.catalog.ScienceDataCatalog
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Exception is caught when Exception is not thrown in org.apache.oodt.cas.filemgr.catalog.ScienceDataCatalog.addMetadata(Metadata, Product) | STYLE | REC_CATCH_EXCEPTION | 201 | Medium |
Method org.apache.oodt.cas.filemgr.catalog.ScienceDataCatalog.createGranule(int, String) passes a nonconstant String to an execute method on an SQL statement | SECURITY | SQL_NONCONSTANT_STRING_PASSED_TO_EXECUTE | 223 | High |
Method org.apache.oodt.cas.filemgr.catalog.ScienceDataCatalog.createParameter(int, String) passes a nonconstant String to an execute method on an SQL statement | SECURITY | SQL_NONCONSTANT_STRING_PASSED_TO_EXECUTE | 282 | High |
Method org.apache.oodt.cas.filemgr.catalog.ScienceDataCatalog.getEndDateTime(Product) passes a nonconstant String to an execute method on an SQL statement | SECURITY | SQL_NONCONSTANT_STRING_PASSED_TO_EXECUTE | 1163 | High |
Method org.apache.oodt.cas.filemgr.catalog.ScienceDataCatalog.getNumProducts(ProductType) passes a nonconstant String to an execute method on an SQL statement | SECURITY | SQL_NONCONSTANT_STRING_PASSED_TO_EXECUTE | 423 | High |
Method org.apache.oodt.cas.filemgr.catalog.ScienceDataCatalog.getProductByName(String) passes a nonconstant String to an execute method on an SQL statement | SECURITY | SQL_NONCONSTANT_STRING_PASSED_TO_EXECUTE | 516 | High |
Method org.apache.oodt.cas.filemgr.catalog.ScienceDataCatalog.getStartDateTime(Product) passes a nonconstant String to an execute method on an SQL statement | SECURITY | SQL_NONCONSTANT_STRING_PASSED_TO_EXECUTE | 1111 | High |
org.apache.oodt.cas.filemgr.catalog.solr.DefaultProductSerializer
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Call to method of static java.text.DateFormat in org.apache.oodt.cas.filemgr.catalog.solr.DefaultProductSerializer.serialize(Product, boolean) | MT_CORRECTNESS | STCAL_INVOKE_ON_STATIC_DATE_FORMAT_INSTANCE | 85 | Medium |
Method org.apache.oodt.cas.filemgr.catalog.solr.DefaultProductSerializer.generateInsertDocuments(String, Map) makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 226 | Medium |
Method org.apache.oodt.cas.filemgr.catalog.solr.DefaultProductSerializer.generateUpdateDocuments(String, Map, boolean) makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 253 | Medium |
org.apache.oodt.cas.filemgr.catalog.solr.Parameters
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Found static field of type java.text.DateFormat in org.apache.oodt.cas.filemgr.catalog.solr.Parameters.SOLR_DATE_TIME_FORMATTER | MT_CORRECTNESS | STCAL_STATIC_SIMPLE_DATE_FORMAT_INSTANCE | Not available | High |
org.apache.oodt.cas.filemgr.catalog.solr.SolrCatalogFactory
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
org.apache.oodt.cas.filemgr.catalog.solr.SolrCatalogFactory.configure() invokes System.exit(...), which shuts down the entire virtual machine | BAD_PRACTICE | DM_EXIT | 66 | Medium |
org.apache.oodt.cas.filemgr.catalog.solr.SolrClient
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Method org.apache.oodt.cas.filemgr.catalog.solr.SolrClient.doGet(String, Map, String) makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 238 | Medium |
org.apache.oodt.cas.filemgr.datatransfer.LocalDataTransferer
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Null pointer dereference of System.err in org.apache.oodt.cas.filemgr.datatransfer.LocalDataTransferer.main(String[]) | CORRECTNESS | NP_ALWAYS_NULL | 239 | High |
org.apache.oodt.cas.filemgr.ingest.CachedIngester
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
org.apache.oodt.cas.filemgr.ingest.CachedIngester.hasProduct(URL, String) invokes java.net.URL.equals(Object), which blocks to do domain name resolution | PERFORMANCE | DMI_BLOCKING_METHODS_ON_URL | 115 | High |
new org.apache.oodt.cas.filemgr.ingest.CachedIngester(String, String, String) may fail to close stream | BAD_PRACTICE | OS_OPEN_STREAM | 69 | Medium |
org.apache.oodt.cas.filemgr.ingest.CmdLineIngester
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Null pointer dereference of System.err in org.apache.oodt.cas.filemgr.ingest.CmdLineIngester.main(String[]) | CORRECTNESS | NP_ALWAYS_NULL | 102 | High |
Null pointer dereference of System.out in org.apache.oodt.cas.filemgr.ingest.CmdLineIngester.main(String[]) | CORRECTNESS | NP_ALWAYS_NULL | 127 | High |
org.apache.oodt.cas.filemgr.ingest.RmiCacheServer
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Null pointer dereference of System.out in org.apache.oodt.cas.filemgr.ingest.RmiCacheServer.launchRmiServer(int) | CORRECTNESS | NP_ALWAYS_NULL | 188 | High |
Class org.apache.oodt.cas.filemgr.ingest.RmiCacheServer defines non-transient non-serializable instance field cache | BAD_PRACTICE | SE_BAD_FIELD | Not available | High |
org.apache.oodt.cas.filemgr.ingest.RmiCacheServerFactory
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Null pointer dereference of System.err in org.apache.oodt.cas.filemgr.ingest.RmiCacheServerFactory.main(String[]) | CORRECTNESS | NP_ALWAYS_NULL | 85 | High |
Null pointer dereference of System.out in org.apache.oodt.cas.filemgr.ingest.RmiCacheServerFactory.main(String[]) | CORRECTNESS | NP_ALWAYS_NULL | 75 | High |
org.apache.oodt.cas.filemgr.ingest.StdIngester
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
org.apache.oodt.cas.filemgr.ingest.StdIngester.checkOrSetFileManager(URL) invokes java.net.URL.equals(Object), which blocks to do domain name resolution | PERFORMANCE | DMI_BLOCKING_METHODS_ON_URL | 234 | High |
org.apache.oodt.cas.filemgr.repository.DataSourceRepositoryManager
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
org.apache.oodt.cas.filemgr.repository.DataSourceRepositoryManager.addProductType(ProductType) invokes inefficient new String() constructor | PERFORMANCE | DM_STRING_VOID_CTOR | 100 | Medium |
Method org.apache.oodt.cas.filemgr.repository.DataSourceRepositoryManager.addProductType(ProductType) passes a nonconstant String to an execute method on an SQL statement | SECURITY | SQL_NONCONSTANT_STRING_PASSED_TO_EXECUTE | 98 | High |
Method org.apache.oodt.cas.filemgr.repository.DataSourceRepositoryManager.getProductTypeByName(String) passes a nonconstant String to an execute method on an SQL statement | SECURITY | SQL_NONCONSTANT_STRING_PASSED_TO_EXECUTE | 402 | High |
Method org.apache.oodt.cas.filemgr.repository.DataSourceRepositoryManager.modifyProductType(ProductType) passes a nonconstant String to an execute method on an SQL statement | SECURITY | SQL_NONCONSTANT_STRING_PASSED_TO_EXECUTE | 201 | High |
org.apache.oodt.cas.filemgr.repository.ScienceDataRepositoryManager
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Method org.apache.oodt.cas.filemgr.repository.ScienceDataRepositoryManager.addProductType(ProductType) passes a nonconstant String to an execute method on an SQL statement | SECURITY | SQL_NONCONSTANT_STRING_PASSED_TO_EXECUTE | 78 | High |
Method org.apache.oodt.cas.filemgr.repository.ScienceDataRepositoryManager.getProductTypeByName(String) passes a nonconstant String to an execute method on an SQL statement | SECURITY | SQL_NONCONSTANT_STRING_PASSED_TO_EXECUTE | 177 | High |
Method org.apache.oodt.cas.filemgr.repository.ScienceDataRepositoryManager.modifyProductType(ProductType) passes a nonconstant String to an execute method on an SQL statement | SECURITY | SQL_NONCONSTANT_STRING_PASSED_TO_EXECUTE | 284 | High |
org.apache.oodt.cas.filemgr.structs.BooleanQueryCriteria
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
org.apache.oodt.cas.filemgr.structs.BooleanQueryCriteria.toString() invokes inefficient new String() constructor | PERFORMANCE | DM_STRING_VOID_CTOR | 162 | Medium |
Method org.apache.oodt.cas.filemgr.structs.BooleanQueryCriteria.toString() concatenates strings using + in a loop | PERFORMANCE | SBSC_USE_STRINGBUFFER_CONCATENATION | 173 | Medium |
org.apache.oodt.cas.filemgr.structs.FreeTextQueryCriteria
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
new org.apache.oodt.cas.filemgr.structs.FreeTextQueryCriteria() invokes inefficient new String() constructor | PERFORMANCE | DM_STRING_VOID_CTOR | 56 | Medium |
Method org.apache.oodt.cas.filemgr.structs.FreeTextQueryCriteria.toString() concatenates strings using + in a loop | PERFORMANCE | SBSC_USE_STRINGBUFFER_CONCATENATION | 169 | Medium |
Write to static field org.apache.oodt.cas.filemgr.structs.FreeTextQueryCriteria.noiseWordHash from instance method new org.apache.oodt.cas.filemgr.structs.FreeTextQueryCriteria() | STYLE | ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD | 59 | High |
Write to static field org.apache.oodt.cas.filemgr.structs.FreeTextQueryCriteria.noiseWordHash from instance method new org.apache.oodt.cas.filemgr.structs.FreeTextQueryCriteria(String, List) | STYLE | ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD | 76 | High |
org.apache.oodt.cas.filemgr.structs.Reference
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Exception is caught when Exception is not thrown in org.apache.oodt.cas.filemgr.structs.Reference.<static initializer>() | STYLE | REC_CATCH_EXCEPTION | 68 | Medium |
org.apache.oodt.cas.filemgr.structs.query.QueryResult
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
org.apache.oodt.cas.filemgr.structs.query.QueryResult defines equals and uses Object.hashCode() | BAD_PRACTICE | HE_EQUALS_USE_HASHCODE | 97-119 | High |
org.apache.oodt.cas.filemgr.structs.query.QueryResultComparator
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Comparison of String objects using == or != in org.apache.oodt.cas.filemgr.structs.query.QueryResultComparator.compare(QueryResult, QueryResult) | BAD_PRACTICE | ES_COMPARING_STRINGS_WITH_EQ | 48 | Medium |
org.apache.oodt.cas.filemgr.structs.query.QueryResultComparator implements Comparator but not Serializable | BAD_PRACTICE | SE_COMPARATOR_SHOULD_BE_SERIALIZABLE | 33-55 | Medium |
org.apache.oodt.cas.filemgr.structs.query.filter.ObjectTimeEvent
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
org.apache.oodt.cas.filemgr.structs.query.filter.ObjectTimeEvent defines equals and uses Object.hashCode() | BAD_PRACTICE | HE_EQUALS_USE_HASHCODE | 47-51 | High |
org.apache.oodt.cas.filemgr.structs.query.filter.TimeEvent
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Method org.apache.oodt.cas.filemgr.structs.query.filter.TimeEvent.compareTo(TimeEvent) invokes inefficient new Long(long) constructor; use Long.valueOf(long) instead | PERFORMANCE | DM_NUMBER_CTOR | 85 | Medium |
org.apache.oodt.cas.filemgr.structs.query.filter.TimeEvent defines equals and uses Object.hashCode() | BAD_PRACTICE | HE_EQUALS_USE_HASHCODE | 68-72 | High |
org.apache.oodt.cas.filemgr.system.XmlRpcFileManager
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Dead store to manager in org.apache.oodt.cas.filemgr.system.XmlRpcFileManager.main(String[]) | STYLE | DLS_DEAD_LOCAL_STORE | 1020 | Medium |
Null pointer dereference of System.err in org.apache.oodt.cas.filemgr.system.XmlRpcFileManager.main(String[]) | CORRECTNESS | NP_ALWAYS_NULL | 1015 | High |
org.apache.oodt.cas.filemgr.system.XmlRpcFileManager.loadConfiguration() may fail to close stream | BAD_PRACTICE | OS_OPEN_STREAM | 1337 | Medium |
org.apache.oodt.cas.filemgr.system.XmlRpcFileManager.transferFile(String, byte[], int, int) may fail to close stream | BAD_PRACTICE | OS_OPEN_STREAM | 817 | Medium |
Exception is caught when Exception is not thrown in org.apache.oodt.cas.filemgr.system.XmlRpcFileManager.ingestProduct(Hashtable, Hashtable, boolean) | STYLE | REC_CATCH_EXCEPTION | 774 | Medium |
org.apache.oodt.cas.filemgr.system.XmlRpcFileManager.transferFile(String, byte[], int, int) ignores exceptional return value of java.io.File.mkdirs() | BAD_PRACTICE | RV_RETURN_VALUE_IGNORED_BAD_PRACTICE | 831 | Medium |
org.apache.oodt.cas.filemgr.system.XmlRpcFileManager.retrieveFile(String, int, int) ignores result of java.io.FileInputStream.skip(long) | BAD_PRACTICE | SR_NOT_CHECKED | 787 | Medium |
org.apache.oodt.cas.filemgr.system.XmlRpcFileManagerClient
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Dead store to numProducts in org.apache.oodt.cas.filemgr.system.XmlRpcFileManagerClient.getNumProducts(ProductType) | STYLE | DLS_DEAD_LOCAL_STORE | 622 | Medium |
Dead store to productTypeHash in org.apache.oodt.cas.filemgr.system.XmlRpcFileManagerClient.getProductTypeById(String) | STYLE | DLS_DEAD_LOCAL_STORE | 1071 | Medium |
Dead store to productTypeHash in org.apache.oodt.cas.filemgr.system.XmlRpcFileManagerClient.getProductTypeByName(String) | STYLE | DLS_DEAD_LOCAL_STORE | 1048 | Medium |
Method org.apache.oodt.cas.filemgr.system.XmlRpcFileManagerClient.getNumProducts(ProductType) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) instead | PERFORMANCE | DM_NUMBER_CTOR | 622 | Medium |
Method org.apache.oodt.cas.filemgr.system.XmlRpcFileManagerClient.getTopNProducts(int) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) instead | PERFORMANCE | DM_NUMBER_CTOR | 639 | Medium |
Method org.apache.oodt.cas.filemgr.system.XmlRpcFileManagerClient.getTopNProducts(int, ProductType) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) instead | PERFORMANCE | DM_NUMBER_CTOR | 661 | Medium |
Method org.apache.oodt.cas.filemgr.system.XmlRpcFileManagerClient.pagedQuery(Query, ProductType, int) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) instead | PERFORMANCE | DM_NUMBER_CTOR | 461 | Medium |
Method org.apache.oodt.cas.filemgr.system.XmlRpcFileManagerClient.retrieveFile(String, int, int) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) instead | PERFORMANCE | DM_NUMBER_CTOR | 840 | Medium |
Method org.apache.oodt.cas.filemgr.system.XmlRpcFileManagerClient.transferFile(String, byte[], int, int) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) instead | PERFORMANCE | DM_NUMBER_CTOR | 857 | Medium |
new org.apache.oodt.cas.filemgr.system.XmlRpcFileManagerClient(URL, boolean) may fail to close stream | BAD_PRACTICE | OS_OPEN_STREAM | 113 | Medium |
Exception is caught when Exception is not thrown in org.apache.oodt.cas.filemgr.system.XmlRpcFileManagerClient.ingestProduct(Product, Metadata, boolean) | STYLE | REC_CATCH_EXCEPTION | 1299 | Medium |
org.apache.oodt.cas.filemgr.tools.CASAnalyzer
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
org.apache.oodt.cas.filemgr.tools.CASAnalyzer.STOP_WORDS should be package protected | MALICIOUS_CODE | MS_PKGPROTECT | 50 | Medium |
org.apache.oodt.cas.filemgr.tools.CatalogSearch
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Dead store to cs in org.apache.oodt.cas.filemgr.tools.CatalogSearch.main(String[]) | STYLE | DLS_DEAD_LOCAL_STORE | 354 | High |
Dead store to results in org.apache.oodt.cas.filemgr.tools.CatalogSearch.PostQuery(String, Query) | STYLE | DLS_DEAD_LOCAL_STORE | 91 | Medium |
Dead store to products in org.apache.oodt.cas.filemgr.tools.CatalogSearch.listElements() | STYLE | DLS_DEAD_LOCAL_STORE | 154 | Medium |
org.apache.oodt.cas.filemgr.tools.CatalogSearch.CommandParser(String) invokes inefficient new String() constructor | PERFORMANCE | DM_STRING_VOID_CTOR | 333 | Medium |
Null pointer dereference of System.out in org.apache.oodt.cas.filemgr.tools.CatalogSearch.CommandParser(String) | CORRECTNESS | NP_ALWAYS_NULL | 303 | High |
Null pointer dereference of System.out in org.apache.oodt.cas.filemgr.tools.CatalogSearch.CommandParser(String) | CORRECTNESS | NP_ALWAYS_NULL | 309 | High |
Null pointer dereference of System.out in org.apache.oodt.cas.filemgr.tools.CatalogSearch.CommandParser(String) | CORRECTNESS | NP_ALWAYS_NULL | 316 | High |
Null pointer dereference of System.out in org.apache.oodt.cas.filemgr.tools.CatalogSearch.CommandParser(String) | CORRECTNESS | NP_ALWAYS_NULL | 323 | High |
Null pointer dereference of System.out in org.apache.oodt.cas.filemgr.tools.CatalogSearch.CommandParser(String) | CORRECTNESS | NP_ALWAYS_NULL | 330 | High |
Null pointer dereference of System.out in org.apache.oodt.cas.filemgr.tools.CatalogSearch.CommandParser(String) | CORRECTNESS | NP_ALWAYS_NULL | 337 | High |
Null pointer dereference of System.out in org.apache.oodt.cas.filemgr.tools.CatalogSearch.GenerateCASQuery(Query, Query) | CORRECTNESS | NP_ALWAYS_NULL | 278 | High |
Null pointer dereference of System.out in org.apache.oodt.cas.filemgr.tools.CatalogSearch.ListProducts() | CORRECTNESS | NP_ALWAYS_NULL | 142 | High |
Null pointer dereference of System.out in org.apache.oodt.cas.filemgr.tools.CatalogSearch.ListProducts() | CORRECTNESS | NP_ALWAYS_NULL | 147 | High |
Null pointer dereference of System.out in org.apache.oodt.cas.filemgr.tools.CatalogSearch.ParseQuery(String) | CORRECTNESS | NP_ALWAYS_NULL | 236 | High |
Null pointer dereference of System.out in org.apache.oodt.cas.filemgr.tools.CatalogSearch.PostQuery(String, Query) | CORRECTNESS | NP_ALWAYS_NULL | 97 | High |
Null pointer dereference of System.out in org.apache.oodt.cas.filemgr.tools.CatalogSearch.PostQuery(String, Query) | CORRECTNESS | NP_ALWAYS_NULL | 104 | High |
Null pointer dereference of System.out in org.apache.oodt.cas.filemgr.tools.CatalogSearch.PostQuery(String, Query) | CORRECTNESS | NP_ALWAYS_NULL | 110 | High |
Null pointer dereference of System.out in org.apache.oodt.cas.filemgr.tools.CatalogSearch.PostQuery(String, Query) | CORRECTNESS | NP_ALWAYS_NULL | 112 | High |
Null pointer dereference of System.out in org.apache.oodt.cas.filemgr.tools.CatalogSearch.PostQuery(Query) | CORRECTNESS | NP_ALWAYS_NULL | 79 | High |
Null pointer dereference of System.out in org.apache.oodt.cas.filemgr.tools.CatalogSearch.listElements() | CORRECTNESS | NP_ALWAYS_NULL | 161 | High |
Null pointer dereference of System.out in org.apache.oodt.cas.filemgr.tools.CatalogSearch.listElements(String) | CORRECTNESS | NP_ALWAYS_NULL | 176 | High |
Null pointer dereference of System.out in org.apache.oodt.cas.filemgr.tools.CatalogSearch.listElements(String) | CORRECTNESS | NP_ALWAYS_NULL | 185 | High |
Null pointer dereference of System.err in org.apache.oodt.cas.filemgr.tools.CatalogSearch.main(String[]) | CORRECTNESS | NP_ALWAYS_NULL | 364 | High |
Null pointer dereference of System.out in org.apache.oodt.cas.filemgr.tools.CatalogSearch.main(String[]) | CORRECTNESS | NP_ALWAYS_NULL | 373 | High |
Null pointer dereference of System.out in org.apache.oodt.cas.filemgr.tools.CatalogSearch.main(String[]) | CORRECTNESS | NP_ALWAYS_NULL | 381 | High |
Null pointer dereference of System.out in org.apache.oodt.cas.filemgr.tools.CatalogSearch.printHelp() | CORRECTNESS | NP_ALWAYS_NULL | 219 | High |
Null pointer dereference of System.out in org.apache.oodt.cas.filemgr.tools.CatalogSearch.setFilter(String) | CORRECTNESS | NP_ALWAYS_NULL | 126 | High |
Null pointer dereference of System.out in org.apache.oodt.cas.filemgr.tools.CatalogSearch.setFilter(String) | CORRECTNESS | NP_ALWAYS_NULL | 130 | High |
Method org.apache.oodt.cas.filemgr.tools.CatalogSearch.CommandParser(String) concatenates strings using + in a loop | PERFORMANCE | SBSC_USE_STRINGBUFFER_CONCATENATION | 335 | Medium |
org.apache.oodt.cas.filemgr.tools.DeleteProduct
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Null pointer dereference of System.err in org.apache.oodt.cas.filemgr.tools.DeleteProduct.main(String[]) | CORRECTNESS | NP_ALWAYS_NULL | 106 | High |
Write to static field org.apache.oodt.cas.filemgr.tools.DeleteProduct.client from instance method new org.apache.oodt.cas.filemgr.tools.DeleteProduct(String, boolean) | STYLE | ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD | 65 | High |
org.apache.oodt.cas.filemgr.tools.DumpDbElementsToXml
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Null pointer dereference of System.err in org.apache.oodt.cas.filemgr.tools.DumpDbElementsToXml.main(String[]) | CORRECTNESS | NP_ALWAYS_NULL | 63 | High |
Null pointer dereference of System.out in org.apache.oodt.cas.filemgr.tools.DumpDbElementsToXml.main(String[]) | CORRECTNESS | NP_ALWAYS_NULL | 67 | High |
org.apache.oodt.cas.filemgr.tools.ExpImpCatalog
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Null pointer dereference of System.err in org.apache.oodt.cas.filemgr.tools.ExpImpCatalog.main(String[]) | CORRECTNESS | NP_ALWAYS_NULL | 361 | High |
org.apache.oodt.cas.filemgr.tools.MetadataBasedProductMover
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Null pointer dereference of System.err in org.apache.oodt.cas.filemgr.tools.MetadataBasedProductMover.main(String[]) | CORRECTNESS | NP_ALWAYS_NULL | 166 | High |
org.apache.oodt.cas.filemgr.tools.MetadataDumper
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Null pointer dereference of System.err in org.apache.oodt.cas.filemgr.tools.MetadataDumper.main(String[]) | CORRECTNESS | NP_ALWAYS_NULL | 157 | High |
org.apache.oodt.cas.filemgr.tools.OptimizeLuceneCatalog
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Null pointer dereference of System.err in org.apache.oodt.cas.filemgr.tools.OptimizeLuceneCatalog.main(String[]) | CORRECTNESS | NP_ALWAYS_NULL | 104 | High |
org.apache.oodt.cas.filemgr.tools.ProductDumper
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Null pointer dereference of System.err in org.apache.oodt.cas.filemgr.tools.ProductDumper.main(String[]) | CORRECTNESS | NP_ALWAYS_NULL | 169 | High |
org.apache.oodt.cas.filemgr.tools.ProductTypeDocTool
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Null pointer dereference of System.err in org.apache.oodt.cas.filemgr.tools.ProductTypeDocTool.main(String[]) | CORRECTNESS | NP_ALWAYS_NULL | 113 | High |
org.apache.oodt.cas.filemgr.tools.ProductTypeDocTool.doProductTypeDoc(String, String) ignores exceptional return value of java.io.File.delete() | BAD_PRACTICE | RV_RETURN_VALUE_IGNORED_BAD_PRACTICE | 90 | Medium |
org.apache.oodt.cas.filemgr.tools.QueryTool
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Dead store to products in org.apache.oodt.cas.filemgr.tools.QueryTool.query(Query) | STYLE | DLS_DEAD_LOCAL_STORE | 99 | Medium |
Null pointer dereference of System.err in org.apache.oodt.cas.filemgr.tools.QueryTool.exit(String) | CORRECTNESS | NP_ALWAYS_NULL | 260 | High |
Null pointer dereference of System.out in org.apache.oodt.cas.filemgr.tools.QueryTool.main(String[]) | CORRECTNESS | NP_ALWAYS_NULL | 238 | High |
Null pointer dereference of System.out in org.apache.oodt.cas.filemgr.tools.QueryTool.main(String[]) | CORRECTNESS | NP_ALWAYS_NULL | 242 | High |
Null pointer dereference of System.out in org.apache.oodt.cas.filemgr.tools.QueryTool.parseQuery(String) | CORRECTNESS | NP_ALWAYS_NULL | 91 | High |
org.apache.oodt.cas.filemgr.tools.RangeQueryTester
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Null pointer dereference of System.err in org.apache.oodt.cas.filemgr.tools.RangeQueryTester.main(String[]) | CORRECTNESS | NP_ALWAYS_NULL | 200 | High |
Null pointer dereference of System.out in org.apache.oodt.cas.filemgr.tools.RangeQueryTester.main(String[]) | CORRECTNESS | NP_ALWAYS_NULL | 218 | High |
Null pointer dereference of System.out in org.apache.oodt.cas.filemgr.tools.RangeQueryTester.main(String[]) | CORRECTNESS | NP_ALWAYS_NULL | 221 | High |
org.apache.oodt.cas.filemgr.tools.SolrIndexer
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Exception is caught when Exception is not thrown in org.apache.oodt.cas.filemgr.tools.SolrIndexer.deleteProductByName(String) | STYLE | REC_CATCH_EXCEPTION | 506 | Medium |
Exception is caught when Exception is not thrown in org.apache.oodt.cas.filemgr.tools.SolrIndexer.indexProductByName(String, boolean) | STYLE | REC_CATCH_EXCEPTION | 418 | Medium |
org.apache.oodt.cas.filemgr.tools.SolrIndexer$IndexerConfig
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Should org.apache.oodt.cas.filemgr.tools.SolrIndexer$IndexerConfig be a _static_ inner class? | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC | 710-794 | Medium |
org.apache.oodt.cas.filemgr.util.SqlParser
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
org.apache.oodt.cas.filemgr.util.SqlParser.toPostFix(String) invokes inefficient new String(String) constructor | PERFORMANCE | DM_STRING_CTOR | 256 | Medium |
Null pointer dereference of System.out in org.apache.oodt.cas.filemgr.util.SqlParser.main(String[]) | CORRECTNESS | NP_ALWAYS_NULL | 453 | High |
Method org.apache.oodt.cas.filemgr.util.SqlParser.getInfixCriteriaString(QueryCriteria) concatenates strings using + in a loop | PERFORMANCE | SBSC_USE_STRINGBUFFER_CONCATENATION | 171 | Medium |
Method org.apache.oodt.cas.filemgr.util.SqlParser.listToString(List) concatenates strings using + in a loop | PERFORMANCE | SBSC_USE_STRINGBUFFER_CONCATENATION | 331 | Medium |
org.apache.oodt.cas.filemgr.util.XmlRpcStructFactory
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Method org.apache.oodt.cas.filemgr.util.XmlRpcStructFactory.getXmlRpcProductPage(ProductPage) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) instead | PERFORMANCE | DM_NUMBER_CTOR | 119 | Medium |
Method org.apache.oodt.cas.filemgr.util.XmlRpcStructFactory.getXmlRpcQueryCriteria(QueryCriteria) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) instead | PERFORMANCE | DM_NUMBER_CTOR | 663 | Medium |
Null pointer dereference of System.out in org.apache.oodt.cas.filemgr.util.XmlRpcStructFactory.getQueryCriteriaFromXmlRpc(Hashtable) | CORRECTNESS | NP_ALWAYS_NULL | 701 | High |
Null pointer dereference of System.out in org.apache.oodt.cas.filemgr.util.XmlRpcStructFactory.getQueryCriteriaFromXmlRpc(Hashtable) | CORRECTNESS | NP_ALWAYS_NULL | 711 | High |
Method org.apache.oodt.cas.filemgr.util.XmlRpcStructFactory.getPropertiesFromXmlRpc(Hashtable) makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 496 | Medium |
org.apache.oodt.cas.filemgr.util.XmlStructFactory
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Method org.apache.oodt.cas.filemgr.util.XmlStructFactory.getProductTypeMapXmlDocument(HashMap, HashMap) makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 262 | Medium |
org.apache.oodt.cas.filemgr.validation.DataSourceValidationLayer
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
org.apache.oodt.cas.filemgr.validation.DataSourceValidationLayer.addElement(Element) invokes inefficient new String() constructor | PERFORMANCE | DM_STRING_VOID_CTOR | 95 | Medium |
Method org.apache.oodt.cas.filemgr.validation.DataSourceValidationLayer.addElement(Element) passes a nonconstant String to an execute method on an SQL statement | SECURITY | SQL_NONCONSTANT_STRING_PASSED_TO_EXECUTE | 93 | High |
Method org.apache.oodt.cas.filemgr.validation.DataSourceValidationLayer.addElementToProductType(ProductType, Element) passes a nonconstant String to an execute method on an SQL statement | SECURITY | SQL_NONCONSTANT_STRING_PASSED_TO_EXECUTE | 300 | High |
Method org.apache.oodt.cas.filemgr.validation.DataSourceValidationLayer.addParentToProductType(ProductType, String) passes a nonconstant String to an execute method on an SQL statement | SECURITY | SQL_NONCONSTANT_STRING_PASSED_TO_EXECUTE | 427 | High |
Method org.apache.oodt.cas.filemgr.validation.DataSourceValidationLayer.getElements(ProductType) passes a nonconstant String to an execute method on an SQL statement | SECURITY | SQL_NONCONSTANT_STRING_PASSED_TO_EXECUTE | 554 | High |
Method org.apache.oodt.cas.filemgr.validation.DataSourceValidationLayer.modifyElement(Element) passes a nonconstant String to an execute method on an SQL statement | SECURITY | SQL_NONCONSTANT_STRING_PASSED_TO_EXECUTE | 176 | High |
Method org.apache.oodt.cas.filemgr.validation.DataSourceValidationLayer.removeElementFromProductType(ProductType, Element) passes a nonconstant String to an execute method on an SQL statement | SECURITY | SQL_NONCONSTANT_STRING_PASSED_TO_EXECUTE | 367 | High |
Method org.apache.oodt.cas.filemgr.validation.DataSourceValidationLayer.removeParentFromProductType(ProductType, String) passes a nonconstant String to an execute method on an SQL statement | SECURITY | SQL_NONCONSTANT_STRING_PASSED_TO_EXECUTE | 485 | High |
org.apache.oodt.cas.filemgr.validation.ScienceDataValidationLayer
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Method org.apache.oodt.cas.filemgr.validation.ScienceDataValidationLayer.addElement(Element) passes a nonconstant String to an execute method on an SQL statement | SECURITY | SQL_NONCONSTANT_STRING_PASSED_TO_EXECUTE | 73 | High |
Method org.apache.oodt.cas.filemgr.validation.ScienceDataValidationLayer.getElementByName(String) passes a nonconstant String to an execute method on an SQL statement | SECURITY | SQL_NONCONSTANT_STRING_PASSED_TO_EXECUTE | 211 | High |
Method org.apache.oodt.cas.filemgr.validation.ScienceDataValidationLayer.modifyElement(Element) passes a nonconstant String to an execute method on an SQL statement | SECURITY | SQL_NONCONSTANT_STRING_PASSED_TO_EXECUTE | 371 | High |
Method org.apache.oodt.cas.filemgr.validation.ScienceDataValidationLayer.addElementToProductType(ProductType, Element) passes a nonconstant String to an execute method on an SQL statement | SECURITY | SQL_NONCONSTANT_STRING_PASSED_TO_EXECUTE | 114 | Medium |
org.apache.oodt.cas.filemgr.versioning.AcquisitionDateVersioner
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
org.apache.oodt.cas.filemgr.versioning.AcquisitionDateVersioner.ACQ_DATE_FORMAT isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | 59 | High |