PMD Results
The following document contains the results of PMD 4.2.5.
Files
org/apache/myfaces/tobago/renderkit/BoxRendererBase.java
| Violation | Line |
|---|---|
| Avoid unused private fields such as 'LOG'. | 36 |
| Avoid unused private fields such as 'LOG'. | 36 |
| An empty method in an abstract class should be abstract instead | 38 - 40 |
| Parameter 'component' is not assigned and could be declared final | 43 |
| Parameter 'facesContext' is not assigned and could be declared final | 43 |
| Parameter 'component' is not assigned and could be declared final | 53 |
| Parameter 'facesContext' is not assigned and could be declared final | 53 |
| Parameter 'component' is not assigned and could be declared final | 61 |
| Parameter 'facesContext' is not assigned and could be declared final | 61 |
| Parameter 'component' is not assigned and could be declared final | 68 |
| Parameter 'component' is not assigned and could be declared final | 73 |
| Parameter 'facesContext' is not assigned and could be declared final | 73 |
org/apache/myfaces/tobago/renderkit/CommandRendererBase.java
| Violation | Line |
|---|---|
| The class 'CommandRendererBase' has a Cyclomatic Complexity of 4 (Highest = 6). | 32 - 71 |
| Parameter 'component' is not assigned and could be declared final | 36 |
| Parameter 'facesContext' is not assigned and could be declared final | 36 |
| The method 'decode' has a Cyclomatic Complexity of 6. | 36 - 54 |
| Local variable 'actionId' could be declared final | 41 |
| Local variable 'clientId' could be declared final | 42 |
| Parameter 'component' is not assigned and could be declared final | 56 |
| Parameter 'facesContext' is not assigned and could be declared final | 60 |
| Parameter 'image' is not assigned and could be declared final | 60 |
| Parameter 'disabled' is not assigned and could be declared final | 60 |
org/apache/myfaces/tobago/renderkit/html/Command.java
| Violation | Line |
|---|---|
| The class 'Command' has a Cyclomatic Complexity of 1 (Highest = 11). | 41 - 239 |
| The class 'Command' has a Cyclomatic Complexity of 1 (Highest = 11). | 41 - 239 |
| Document empty constructor | 62 - 63 |
| Avoid really long parameter lists. | 65 - 67 |
| Parameter 'action' is not assigned and could be declared final | 66 |
| Parameter 'target' is not assigned and could be declared final | 66 |
| Parameter 'transition' is not assigned and could be declared final | 66 |
| Parameter 'focus' is not assigned and could be declared final | 66 |
| Parameter 'partially' is not assigned and could be declared final | 66 |
| Parameter 'url' is not assigned and could be declared final | 66 |
| Parameter 'popup' is not assigned and could be declared final | 67 |
| Parameter 'omit' is not assigned and could be declared final | 67 |
| Parameter 'confirmation' is not assigned and could be declared final | 67 |
| Parameter 'delay' is not assigned and could be declared final | 67 |
| Parameter 'facesContext' is not assigned and could be declared final | 80 |
| Parameter 'command' is not assigned and could be declared final | 80 |
| Avoid reassigning parameters such as 'facetComponent' | 97 |
| Parameter 'facesContext' is not assigned and could be declared final | 97 |
| Parameter 'focusId' is not assigned and could be declared final | 97 |
| The constructor 'Command' has a Cyclomatic Complexity of 11. | 97 - 137 |
| The constructor 'Command' has a Cyclomatic Complexity of 11. | 97 - 137 |
| Local variable 'target' could be declared final | 107 |
| Local variable 'delay' could be declared final | 129 |
| Parameter 'command' is not assigned and could be declared final | 139 |
| Avoid if (x != y) ..; else ..; | 141 |
| Do not add empty strings | 141 |
| Parameter 'action' is not assigned and could be declared final | 148 |
| Parameter 'transition' is not assigned and could be declared final | 156 |
| Parameter 'target' is not assigned and could be declared final | 164 |
| Parameter 'url' is not assigned and could be declared final | 172 |
| Parameter 'partially' is not assigned and could be declared final | 180 |
| Parameter 'focus' is not assigned and could be declared final | 188 |
| Parameter 'confirmation' is not assigned and could be declared final | 196 |
| Parameter 'delay' is not assigned and could be declared final | 204 |
| Parameter 'popup' is not assigned and could be declared final | 212 |
| Parameter 'omit' is not assigned and could be declared final | 220 |
| Parameter 'script' is not assigned and could be declared final | 235 |
org/apache/myfaces/tobago/renderkit/html/CommandMap.java
| Violation | Line |
|---|---|
| Document empty constructor | 40 - 41 |
| Parameter 'click' is not assigned and could be declared final | 46 |
| Parameter 'click' is not assigned and could be declared final | 50 |
| Parameter 'name' is not assigned and could be declared final | 58 |
| Parameter 'command' is not assigned and could be declared final | 58 |
| Position literals first in String comparisons | 59 |
| Avoid if (x != y) ..; else ..; | 73 - 77 |
org/apache/myfaces/tobago/renderkit/html/JsonUtils.java
| Violation | Line |
|---|---|
| A class which only has private constructors should be final | 24 - 176 |
| The class 'JsonUtils' has a Cyclomatic Complexity of 4 (Highest = 16). | 24 - 176 |
| The class 'JsonUtils' has a Cyclomatic Complexity of 4 (Highest = 16). | 24 - 176 |
| Parameter 'name' is not assigned and could be declared final | 29 |
| Parameter 'builder' is not assigned and could be declared final | 29 |
| Parameter 'value' is not assigned and could be declared final | 29 |
| Parameter 'name' is not assigned and could be declared final | 44 |
| Parameter 'builder' is not assigned and could be declared final | 44 |
| Parameter 'value' is not assigned and could be declared final | 44 |
| Parameter 'name' is not assigned and could be declared final | 52 |
| Parameter 'builder' is not assigned and could be declared final | 52 |
| Parameter 'value' is not assigned and could be declared final | 52 |
| Avoid reassigning parameters such as 'value' | 60 |
| Parameter 'name' is not assigned and could be declared final | 60 |
| Parameter 'builder' is not assigned and could be declared final | 60 |
| Parameter 'commandMap' is not assigned and could be declared final | 69 |
| The method 'encode' has a Cyclomatic Complexity of 5. | 69 - 93 |
| Local variable 'builder' could be declared final | 70 |
| Local variable 'initialLength' could be declared final | 72 |
| Local variable 'click' could be declared final | 74 |
| Parameter 'name' is not assigned and could be declared final | 95 |
| Parameter 'builder' is not assigned and could be declared final | 95 |
| Parameter 'command' is not assigned and could be declared final | 95 |
| The method 'encode' has a Cyclomatic Complexity of 16. | 95 - 152 |
| The method encode() has an NPath complexity of 13824 | 95 - 152 |
| The method 'encode' has a Cyclomatic Complexity of 16. | 95 - 152 |
| Local variable 'initialLength' could be declared final | 99 |
| Local variable 'action' could be declared final | 101 |
| Local variable 'transition' could be declared final | 105 |
| Local variable 'target' could be declared final | 109 |
| Local variable 'url' could be declared final | 113 |
| Local variable 'partially' could be declared final | 117 |
| Local variable 'focus' could be declared final | 121 |
| Local variable 'confirmation' could be declared final | 125 |
| Local variable 'delay' could be declared final | 129 |
| Local variable 'popup' could be declared final | 133 |
| Local variable 'script' could be declared final | 137 |
| Local variable 'omit' could be declared final | 141 |
| Parameter 'popup' is not assigned and could be declared final | 154 |
| Parameter 'name' is not assigned and could be declared final | 154 |
| Parameter 'builder' is not assigned and could be declared final | 154 |
| Local variable 'initialLength' could be declared final | 158 |
| Local variable 'command' could be declared final | 160 |
| Local variable 'immediate' could be declared final | 164 |
org/apache/myfaces/tobago/renderkit/html/Popup.java
| Violation | Line |
|---|---|
| A class which only has private constructors should be final | 26 - 71 |
| Private field 'command' could be made final; it is only initialized in the declaration or constructor. | 31 |
| Private field 'immediate' could be made final; it is only initialized in the declaration or constructor. | 36 |
| Parameter 'immediate' is not assigned and could be declared final | 38 |
| Parameter 'command' is not assigned and could be declared final | 38 |
| Parameter 'component' is not assigned and could be declared final | 43 |
| Avoid if (x != y) ..; else ..; | 48 - 56 |
| Position literals first in String comparisons | 50 |
| Local variable 'popupAction' could be declared final | 52 |
| Avoid if (x != y) ..; else ..; | 57 - 61 |
org/apache/myfaces/tobago/renderkit/html/standard/standard/tag/MediatorRenderer.java
| Violation | Line |
|---|---|
| Avoid unused private fields such as 'LOG'. | 37 |
| Avoid unused private fields such as 'LOG'. | 37 |
| Parameter 'component' is not assigned and could be declared final | 40 |
| Parameter 'facesContext' is not assigned and could be declared final | 40 |
| Local variable 'mediator' could be declared final | 42 |
| Local variable 'writer' could be declared final | 43 |
| Parameter 'component' is not assigned and could be declared final | 50 |
| Parameter 'facesContext' is not assigned and could be declared final | 50 |
| Local variable 'writer' could be declared final | 52 |
org/apache/myfaces/tobago/renderkit/html/standard/standard/tag/SeparatorRenderer.java
| Violation | Line |
|---|---|
| Parameter 'component' is not assigned and could be declared final | 45 |
| Parameter 'facesContext' is not assigned and could be declared final | 45 |
| Local variable 'separator' could be declared final | 47 |
| Local variable 'writer' could be declared final | 48 |
| Avoid if (x != y) ..; else ..; | 52 - 95 |
| Local variable 'style' could be declared final | 61 |
| Local variable 'style' could be declared final | 91 |
| Parameter 'separator' is not assigned and could be declared final | 98 |
| Parameter 'component' is not assigned and could be declared final | 109 |
| Parameter 'facesContext' is not assigned and could be declared final | 109 |
| Local variable 'label' could be declared final | 110 |
org/apache/myfaces/tobago/renderkit/html/util/HtmlRendererUtils.java
| Violation | Line |
|---|---|
| A high number of imports can indicate a high degree of coupling within an object. | 20 - 852 |
| This class has a bunch of public methods and attributes | 20 - 852 |
| The class 'HtmlRendererUtils' has a Cyclomatic Complexity of 3 (Highest = 19). | 69 - 852 |
| This class has too many methods, consider refactoring it. | 69 - 852 |
| The class 'HtmlRendererUtils' has a Cyclomatic Complexity of 3 (Highest = 19). | 69 - 852 |
| Avoid if (x != y) ..; else ..; | 81 - 89 |
| Local variable 'writer' could be declared final | 83 |
| Local variable 'id' could be declared final | 84 |
| Parameter 'error' is not assigned and could be declared final | 94 |
| Parameter 'facesContext' is not assigned and could be declared final | 94 |
| Parameter 'focus' is not assigned and could be declared final | 94 |
| Parameter 'clientId' is not assigned and could be declared final | 94 |
| The method 'renderFocus' has a Cyclomatic Complexity of 5. | 94 - 102 |
| Parameter 'writer' is not assigned and could be declared final | 95 |
| The method 'renderFocusId' has a Cyclomatic Complexity of 5. | 111 - 127 |
| Local variable 'page' could be declared final | 117 |
| Local variable 'id' could be declared final | 118 |
| Avoid if (x != y) ..; else ..; | 119 - 125 |
| Local variable 'writer' could be declared final | 123 |
| Parameter 'component' is not assigned and could be declared final | 133 |
| Parameter 'facesContext' is not assigned and could be declared final | 133 |
| Local variable 'rendererName' could be declared final | 134 |
| Parameter 'component' is not assigned and could be declared final | 138 |
| Parameter 'facesContext' is not assigned and could be declared final | 138 |
| Local variable 'rendererType' could be declared final | 139 |
| Parameter 'label' is not assigned and could be declared final | 143 |
| Parameter 'writer' is not assigned and could be declared final | 143 |
| Local variable 'pos' could be declared final | 145 |
| Local variable 'text' could be declared final | 146 |
| Parameter 'facesContext' is not assigned and could be declared final | 160 |
| Parameter 'transition' is not assigned and could be declared final | 160 |
| Parameter 'facesContext' is not assigned and could be declared final | 166 |
| Parameter 'clientId' is not assigned and could be declared final | 166 |
| Parameter 'key' is not assigned and could be declared final | 166 |
| Parameter 'modifier' is not assigned and could be declared final | 172 |
| Parameter 'facesContext' is not assigned and could be declared final | 172 |
| Parameter 'clientId' is not assigned and could be declared final | 172 |
| Parameter 'key' is not assigned and could be declared final | 172 |
| Parameter 'facesContext' is not assigned and could be declared final | 180 |
| Parameter 'func' is not assigned and could be declared final | 180 |
| Parameter 'key' is not assigned and could be declared final | 180 |
| Parameter 'modifier' is not assigned and could be declared final | 185 |
| Parameter 'facesContext' is not assigned and could be declared final | 185 |
| Parameter 'func' is not assigned and could be declared final | 185 |
| Parameter 'key' is not assigned and could be declared final | 185 |
| Local variable 'str' could be declared final | 187 |
| Parameter 'modifier' is not assigned and could be declared final | 192 |
| Parameter 'clientId' is not assigned and could be declared final | 192 |
| Parameter 'key' is not assigned and could be declared final | 192 |
| Local variable 'func' could be declared final | 193 |
| Parameter 'modifier' is not assigned and could be declared final | 198 |
| Parameter 'func' is not assigned and could be declared final | 198 |
| Parameter 'key' is not assigned and could be declared final | 198 |
| Local variable 'buffer' could be declared final | 199 |
| Parameter 'component' is not assigned and could be declared final | 218 |
| Parameter 'name' is not assigned and could be declared final | 218 |
| Parameter 'component' is not assigned and could be declared final | 223 |
| Parameter 'facesContext' is not assigned and could be declared final | 223 |
| Parameter 'component' is not assigned and could be declared final | 228 |
| Parameter 'facesContext' is not assigned and could be declared final | 228 |
| Parameter 'width' is not assigned and could be declared final | 228 |
| Parameter 'src' is not assigned and could be declared final | 232 |
| Parameter 'ext' is not assigned and could be declared final | 232 |
| Local variable 'dot' could be declared final | 233 |
| Parameter 'facesContext' is not assigned and could be declared final | 242 |
| Local variable 'writer' could be declared final | 244 |
| Parameter 'facesContext' is not assigned and could be declared final | 256 |
| Parameter 'script' is not assigned and could be declared final | 256 |
| Parameter 'scripts' is not assigned and could be declared final | 265 |
| Parameter 'facesContext' is not assigned and could be declared final | 265 |
| Parameter 'afterLoadCmds' is not assigned and could be declared final | 265 |
| The method 'writeScriptLoader' has a Cyclomatic Complexity of 14. | 265 - 314 |
| The method writeScriptLoader() has an NPath complexity of 220 | 265 - 314 |
| The method 'writeScriptLoader' has a Cyclomatic Complexity of 14. | 265 - 314 |
| Local variable 'writer' could be declared final | 267 |
| Local variable 'ajax' could be declared final | 275 |
| Local variable 'splittedStrings' could be declared final | 292 |
| Parameter 'facesContext' is not assigned and could be declared final | 321 |
| Parameter 'styles' is not assigned and could be declared final | 321 |
| Local variable 'writer' could be declared final | 322 |
| Parameter 'component' is not assigned and could be declared final | 331 |
| Parameter 'facesContext' is not assigned and could be declared final | 331 |
| Local variable 'messages' could be declared final | 332 |
| Avoid reassigning parameters such as 'title' | 336 |
| Avoid reassigning parameters such as 'title' | 336 |
| Avoid reassigning parameters such as 'title' | 336 |
| Parameter 'tip' is not assigned and could be declared final | 336 |
| Parameter 'values' is not assigned and could be declared final | 348 |
| Parameter 'component' is not assigned and could be declared final | 348 |
| Parameter 'items' is not assigned and could be declared final | 348 |
| Parameter 'facesContext' is not assigned and could be declared final | 349 |
| Parameter 'writer' is not assigned and could be declared final | 349 |
| Parameter 'values' is not assigned and could be declared final | 354 |
| Parameter 'onlySelected' is not assigned and could be declared final | 354 |
| Parameter 'component' is not assigned and could be declared final | 354 |
| Parameter 'items' is not assigned and could be declared final | 354 |
| The method 'renderSelectItems' has a Cyclomatic Complexity of 19. | 354 - 417 |
| The method renderSelectItems() has an NPath complexity of 4506 | 354 - 417 |
| The method 'renderSelectItems' has a Cyclomatic Complexity of 19. | 354 - 417 |
| Parameter 'facesContext' is not assigned and could be declared final | 355 |
| Parameter 'writer' is not assigned and could be declared final | 355 |
| Local variable 'selectItems' could be declared final | 367 |
| Local variable 'contains' could be declared final | 377 |
| Local variable 'formattedValue' could be declared final | 390 |
| Local variable 'image' could be declared final | 393 |
| Avoid instantiating new objects inside loops | 395 |
| Parameter 'component' is not assigned and could be declared final | 419 |
| Parameter 'context' is not assigned and could be declared final | 419 |
| Parameter 'componentId' is not assigned and could be declared final | 419 |
| The method 'getComponentIds' has a Cyclomatic Complexity of 5. | 419 - 433 |
| Local variable 'sb' could be declared final | 420 |
| Local variable 'clientId' could be declared final | 426 |
| Parameter 'component' is not assigned and could be declared final | 436 |
| Parameter 'context' is not assigned and could be declared final | 436 |
| Parameter 'componentId' is not assigned and could be declared final | 436 |
| Local variable 'result' could be declared final | 437 |
| Local variable 'clientId' could be declared final | 440 |
| Parameter 'component' is not assigned and could be declared final | 449 |
| Parameter 'context' is not assigned and could be declared final | 449 |
| Parameter 'componentId' is not assigned and could be declared final | 449 |
| The method 'getComponentId' has a Cyclomatic Complexity of 5. | 449 - 463 |
| Local variable 'partiallyComponent' could be declared final | 450 |
| Local variable 'clientId' could be declared final | 452 |
| Local variable 'rowIndex' could be declared final | 454 |
| Parameter 'value' is not assigned and could be declared final | 469 |
| Parameter 'key' is not assigned and could be declared final | 469 |
| Local variable 'buf' could be declared final | 470 |
| Parameter 'value' is not assigned and could be declared final | 482 |
| Parameter 'key' is not assigned and could be declared final | 482 |
| Local variable 'buf' could be declared final | 483 |
| Parameter 'component' is not assigned and could be declared final | 495 |
| Parameter 'writer' is not assigned and could be declared final | 495 |
| Local variable 'objTip' could be declared final | 496 |
| Local variable 'tip' could be declared final | 498 |
| Parameter 'component' is not assigned and could be declared final | 506 |
| Parameter 'writer' is not assigned and could be declared final | 506 |
| Local variable 'objTip' could be declared final | 507 |
| Avoid if (x != y) ..; else ..; | 508 - 513 |
| Local variable 'tip' could be declared final | 509 |
| Parameter 'str' is not assigned and could be declared final | 516 |
| Parameter 'facesContext' is not assigned and could be declared final | 523 |
| Parameter 'command' is not assigned and could be declared final | 523 |
| Parameter 'facesContext' is not assigned and could be declared final | 530 |
| Parameter 'searchBase' is not assigned and could be declared final | 530 |
| The method 'getRenderedPartiallyJavascriptArray' has a Cyclomatic Complexity of 5. | 530 - 548 |
| Parameter 'supportsRenderedPartially' is not assigned and could be declared final | 531 |
| Local variable 'list' could be declared final | 532 |
| Local variable 'strBuilder' could be declared final | 536 |
| Parameter 'list' is not assigned and could be declared final | 550 |
| Local variable 'strBuilder' could be declared final | 551 |
| Parameter 'component' is not assigned and could be declared final | 565 |
| Parameter 'context' is not assigned and could be declared final | 565 |
| Local variable 'objDojoType' could be declared final | 567 |
| Parameter 'addStyle' is not assigned and could be declared final | 574 |
| Parameter 'component' is not assigned and could be declared final | 574 |
| Parameter 'writer' is not assigned and could be declared final | 574 |
| Local variable 'objDndType' could be declared final | 576 |
| Local variable 'objDndData' could be declared final | 580 |
| Parameter 'dojoType' is not assigned and could be declared final | 586 |
| Parameter 'component' is not assigned and could be declared final | 586 |
| Parameter 'clientId' is not assigned and could be declared final | 586 |
| The method 'createDojoDndType' has a Cyclomatic Complexity of 12. | 586 - 638 |
| The method createDojoDndType() has an NPath complexity of 640 | 586 - 638 |
| The method 'createDojoDndType' has a Cyclomatic Complexity of 12. | 586 - 638 |
| Local variable 'strBuilder' could be declared final | 587 |
| Local variable 'parameter' could be declared final | 589 |
| Local variable 'objHorizontal' could be declared final | 591 |
| Local variable 'objCopyOnly' could be declared final | 595 |
| Local variable 'objSkipForm' could be declared final | 599 |
| Local variable 'objWithHandles' could be declared final | 603 |
| Local variable 'objAccept' could be declared final | 607 |
| Local variable 'allowed' could be declared final | 611 |
| Prefer StringBuffer over += for concatenating strings | 616 |
| Local variable 'objSingular' could be declared final | 624 |
| Local variable 'objCreator' could be declared final | 628 |
| Parameter 'component' is not assigned and could be declared final | 640 |
| Parameter 'facesContext' is not assigned and could be declared final | 640 |
| Parameter 'writer' is not assigned and could be declared final | 641 |
| The method 'renderCommandFacet' has a Cyclomatic Complexity of 9. | 645 - 667 |
| Parameter 'id' is not assigned and could be declared final | 646 |
| Parameter 'component' is not assigned and could be declared final | 646 |
| Parameter 'facesContext' is not assigned and could be declared final | 646 |
| Parameter 'writer' is not assigned and could be declared final | 646 |
| Local variable 'facets' could be declared final | 652 |
| Local variable 'facetComponent' could be declared final | 654 |
| Avoid instantiating new objects inside loops | 658 |
| Local variable 'key' could be declared final | 660 |
| Avoid instantiating new objects inside loops | 661 |
| Parameter 'facesContext' is not assigned and could be declared final | 669 |
| Parameter 'sheet' is not assigned and could be declared final | 669 |
| The method 'renderSheetCommands' has a Cyclomatic Complexity of 9. | 669 - 692 |
| Parameter 'writer' is not assigned and could be declared final | 670 |
| Local variable 'columnEvent' could be declared final | 674 |
| Local variable 'selectionChild' could be declared final | 676 |
| No need to check for null before an instanceof | 677 |
| Local variable 'action' could be declared final | 678 |
| Avoid instantiating new objects inside loops | 680 |
| Avoid instantiating new objects inside loops | 682 |
| Parameter 'component' is not assigned and could be declared final | 695 |
| Parameter 'facesContext' is not assigned and could be declared final | 695 |
| Parameter 'writer' is not assigned and could be declared final | 695 |
| Parameter 'component' is not assigned and could be declared final | 700 |
| Parameter 'facesContext' is not assigned and could be declared final | 700 |
| Parameter 'clientIds' is not assigned and could be declared final | 700 |
| The method 'checkForCommandFacet' has a Cyclomatic Complexity of 5. | 700 - 712 |
| Parameter 'writer' is not assigned and could be declared final | 701 |
| Local variable 'facets' could be declared final | 706 |
| Parameter 'facetEntry' is not assigned and could be declared final | 715 |
| Parameter 'clientIds' is not assigned and could be declared final | 715 |
| Parameter 'facesContext' is not assigned and could be declared final | 716 |
| Parameter 'writer' is not assigned and could be declared final | 716 |
| Parameter 'facetEntry' is not assigned and could be declared final | 728 |
| Parameter 'clientId' is not assigned and could be declared final | 728 |
| Parameter 'facesContext' is not assigned and could be declared final | 729 |
| Parameter 'writer' is not assigned and could be declared final | 729 |
| Local variable 'facetComponent' could be declared final | 748 |
| Avoid if (x != y) ..; else ..; | 758 - 768 |
| Parameter 'target' is not assigned and could be declared final | 778 |
| Parameter 'transition' is not assigned and could be declared final | 778 |
| Parameter 'focus' is not assigned and could be declared final | 778 |
| Parameter 'clientId' is not assigned and could be declared final | 778 |
| The method 'createSubmitAction' has a Cyclomatic Complexity of 7. | 778 - 804 |
| Local variable 'builder' could be declared final | 779 |
| Parameter 'cell' is not assigned and could be declared final | 810 |
| Parameter 'facesContext' is not assigned and could be declared final | 814 |
| Parameter 'parent' is not assigned and could be declared final | 814 |
| Parameter 'writer' is not assigned and could be declared final | 814 |
| Parameter 'accessKey' is not assigned and could be declared final | 825 |
| Parameter 'component' is not assigned and could be declared final | 825 |
| Parameter 'facesContext' is not assigned and could be declared final | 825 |
| Local variable 'clientId' could be declared final | 826 |
| Local variable 'jsStatement' could be declared final | 827 |
| The method 'writeDataAttributes' has a Cyclomatic Complexity of 5. | 831 - 851 |
| Parameter 'component' is not assigned and could be declared final | 832 |
| Parameter 'context' is not assigned and could be declared final | 832 |
| Parameter 'writer' is not assigned and could be declared final | 832 |
org/apache/myfaces/tobago/renderkit/util/RenderUtils.java
| Violation | Line |
|---|---|
| A high number of imports can indicate a high degree of coupling within an object. | 20 - 567 |
| A class which only has private constructors should be final | 65 - 567 |
| The class 'RenderUtils' has a Cyclomatic Complexity of 5 (Highest = 22). | 65 - 567 |
| This class has too many methods, consider refactoring it. | 65 - 567 |
| The class 'RenderUtils' has a Cyclomatic Complexity of 5 (Highest = 22). | 65 - 567 |
| Parameter 'value' is not assigned and could be declared final | 81 |
| Parameter 'list' is not assigned and could be declared final | 81 |
| The method 'contains' has a Cyclomatic Complexity of 5. | 81 - 91 |
| Parameter 'panel' is not assigned and could be declared final | 93 |
| Parameter 'facesContext' is not assigned and could be declared final | 93 |
| Parameter 'component' is not assigned and could be declared final | 99 |
| Parameter 'facesContext' is not assigned and could be declared final | 99 |
| The method 'encode' has a Cyclomatic Complexity of 7. | 103 - 125 |
| Parameter 'component' is not assigned and could be declared final | 104 |
| Parameter 'facesContext' is not assigned and could be declared final | 104 |
| Parameter 'only' is not assigned and could be declared final | 104 |
| Parameter 'component' is not assigned and could be declared final | 127 |
| Parameter 'only' is not assigned and could be declared final | 127 |
| Parameter 'component' is not assigned and could be declared final | 136 |
| Parameter 'facesContext' is not assigned and could be declared final | 136 |
| The method 'prepareRendererAll' has a Cyclomatic Complexity of 5. | 136 - 155 |
| Local variable 'renderer' could be declared final | 140 |
| Local variable 'it' could be declared final | 149 |
| Local variable 'child' could be declared final | 151 |
| Parameter 'component' is not assigned and could be declared final | 158 |
| Parameter 'facesContext' is not assigned and could be declared final | 158 |
| The method 'getFormattedValue' has a Cyclomatic Complexity of 6. | 170 - 197 |
| Parameter 'component' is not assigned and could be declared final | 171 |
| Parameter 'context' is not assigned and could be declared final | 171 |
| Parameter 'currentValue' is not assigned and could be declared final | 171 |
| Local variable 'converterType' could be declared final | 188 |
| Parameter 'text' is not assigned and could be declared final | 199 |
| Parameter 'component' is not assigned and could be declared final | 199 |
| Parameter 'facesContext' is not assigned and could be declared final | 199 |
| Parameter 'text' is not assigned and could be declared final | 203 |
| Parameter 'component' is not assigned and could be declared final | 203 |
| Parameter 'facesContext' is not assigned and could be declared final | 203 |
| The method 'calculateStringWidth' has a Cyclomatic Complexity of 6. | 207 - 234 |
| Parameter 'text' is not assigned and could be declared final | 208 |
| Parameter 'component' is not assigned and could be declared final | 208 |
| Parameter 'facesContext' is not assigned and could be declared final | 208 |
| Parameter 'type' is not assigned and could be declared final | 208 |
| Local variable 'fontWidths' could be declared final | 220 |
| Local variable 'begin' could be declared final | 224 |
| Parameter 'component' is not assigned and could be declared final | 236 |
| Parameter 'component' is not assigned and could be declared final | 240 |
| Parameter 'component' is not assigned and could be declared final | 244 |
| The method 'getItems' has a Cyclomatic Complexity of 6. | 244 - 270 |
| Local variable 'selectItems' could be declared final | 246 |
| Local variable 'indices' could be declared final | 256 |
| Local variable 'items' could be declared final | 257 |
| Avoid if (x != y) ..; else ..; | 259 - 268 |
| Substitute calls to size() == 0 (or size() != 0) with calls to isEmpty() | 259 |
| Avoid instantiating new objects inside loops | 266 |
| Parameter 'component' is not assigned and could be declared final | 272 |
| The method 'currentValue' has a Cyclomatic Complexity of 7. | 272 - 300 |
| Local variable 'context' could be declared final | 287 |
| Avoid if (x != y) ..; else ..; | 290 - 296 |
| Parameter 'component' is not assigned and could be declared final | 302 |
| The method 'getSelectItems' has a Cyclomatic Complexity of 22. | 302 - 373 |
| The method 'getSelectItems' has a Cyclomatic Complexity of 22. | 302 - 373 |
| Local variable 'list' could be declared final | 304 |
| Local variable 'value' could be declared final | 312 |
| Local variable 'item' could be declared final | 314 |
| Avoid instantiating new objects inside loops | 319 - 321 |
| Avoid if (x != y) ..; else ..; | 320 |
| Local variable 'value' could be declared final | 333 |
| Local variable 'items' could be declared final | 347 |
| Local variable 'val' could be declared final | 356 |
| Avoid instantiating new objects inside loops | 358 |
| Parameter 'component' is not assigned and could be declared final | 375 |
| Parameter 'facesContext' is not assigned and could be declared final | 383 |
| Parameter 'data' is not assigned and could be declared final | 383 |
| The method 'decodedStateOfTreeData' has a Cyclomatic Complexity of 10. | 383 - 432 |
| The method decodedStateOfTreeData() has an NPath complexity of 250 | 383 - 432 |
| The method 'decodedStateOfTreeData' has a Cyclomatic Complexity of 10. | 383 - 432 |
| Parameter 'facesContext' is not assigned and could be declared final | 434 |
| Parameter 'data' is not assigned and could be declared final | 434 |
| Parameter 'suffix' is not assigned and could be declared final | 434 |
| Parameter 'component' is not assigned and could be declared final | 449 |
| Parameter 'facesContext' is not assigned and could be declared final | 449 |
| Parameter 'writer' is not assigned and could be declared final | 449 |
| Parameter 'component' is not assigned and could be declared final | 460 |
| Parameter 'facesContext' is not assigned and could be declared final | 460 |
| Parameter 'writer' is not assigned and could be declared final | 460 |
| Parameter 'scrollPosition' is not assigned and could be declared final | 460 |
| Avoid if (x != y) ..; else ..; | 467 - 472 |
| Local variable 'scroll' could be declared final | 468 |
| Parameter 'component' is not assigned and could be declared final | 477 |
| Parameter 'facesContext' is not assigned and could be declared final | 477 |
| Local variable 'value' could be declared final | 480 |
| Local variable 'scrollPosition' could be declared final | 482 |
| Parameter 'value' is not assigned and could be declared final | 490 |
| Local variable 'sep' could be declared final | 493 |
| String.indexOf(char) is faster than String.indexOf(String). | 493 |
| Do not add empty strings | 495 |
| Local variable 'left' could be declared final | 500 |
| Local variable 'top' could be declared final | 501 |
| Parameter 'component' is not assigned and could be declared final | 509 |
| Parameter 'facesContext' is not assigned and could be declared final | 509 |
| The method 'generateUrl' has a Cyclomatic Complexity of 11. | 509 - 565 |
| The method 'generateUrl' has a Cyclomatic Complexity of 11. | 509 - 565 |
| Avoid if (x != y) ..; else ..; | 517 - 562 |
| Local variable 'jsfResource' could be declared final | 518 |
| Avoid if (x != y) ..; else ..; | 520 - 530 |
| Local variable 'link' could be declared final | 533 |
| This call to String.startsWith can be rewritten using String.charAt(0) | 534 |
| Local variable 'builder' could be declared final | 543 |
| Local variable 'parameter' could be declared final | 547 |
| Local variable 'value' could be declared final | 556 |
| Avoid if (x != y) ..; else ..; | 558 |