The following document contains the results of PMD
| Violation | Line |
|---|---|
| Parameter 'planets' is not assigned and could be declared final | 51 |
| Violation | Line |
|---|---|
| Parameter 'diameter' is not assigned and could be declared final | 66 |
| Parameter 'mass' is not assigned and could be declared final | 74 |
| Parameter 'sunDistance' is not assigned and could be declared final | 82 |
| Parameter 'timeOfCirculation' is not assigned and could be declared final | 90 |
| Parameter 'moons' is not assigned and could be declared final | 98 |
| Violation | Line |
|---|---|
| Parameter 'name' is not assigned and could be declared final | 92 |
| Parameter 'number' is not assigned and could be declared final | 100 |
| Parameter 'orbit' is not assigned and could be declared final | 108 |
| Parameter 'distance' is not assigned and could be declared final | 116 |
| Parameter 'period' is not assigned and could be declared final | 124 |
| Parameter 'incl' is not assigned and could be declared final | 132 |
| Parameter 'eccen' is not assigned and could be declared final | 140 |
| Parameter 'discoverer' is not assigned and could be declared final | 148 |
| Parameter 'discoverYear' is not assigned and could be declared final | 156 |
| Parameter 'population' is not assigned and could be declared final | 164 |
| Position literals first in String comparisons | 169 |
| Avoid instantiating new objects inside loops | 175 |
| Local variable could be declared final | 182 |
| Local variable could be declared final | 183 |
| Parameter 'center' is not assigned and could be declared final | 190 |
| Local variable could be declared final | 191 |
| Local variable could be declared final | 192 |
| Violation | Line |
|---|---|
| Parameter 'key' is not assigned and could be declared final | 42 |
| Violation | Line |
|---|---|
| Parameter 'component' is not assigned and could be declared final | 31 |
| Parameter 'value' is not assigned and could be declared final | 31 |
| Parameter 'context' is not assigned and could be declared final | 31 |
| Parameter 'component' is not assigned and could be declared final | 35 |
| Parameter 'value' is not assigned and could be declared final | 35 |
| Parameter 'context' is not assigned and could be declared final | 35 |
| Violation | Line |
|---|---|
| Parameter 'facesContext' is not assigned and could be declared final | 40 |
| Local variable could be declared final | 41 |
| Parameter 'node' is not assigned and could be declared final | 46 |
| Local variable could be declared final | 47 - 48 |
| Parameter 'event' is not assigned and could be declared final | 53 |
| Local variable could be declared final | 55 |
| Violation | Line |
|---|---|
| Parameter 'tabChangeEvent' is not assigned and could be declared final | 39 |
| Violation | Line |
|---|---|
| The class 'ThemeConfigViewController' has a Cyclomatic Complexity of 2 (Highest = 7). | 50 - 254 |
| Private field could be made final. It is only initialized in the declaration or constructor. | 122 |
| The method 'init' has a Cyclomatic Complexity of 7. | 129 - 168 |
| Avoid if (x != y) ..; else ..; | 131 - 135 |
| Local variable could be declared final | 139 |
| Avoid instantiating new objects inside loops | 139 |
| Local variable could be declared final | 140 |
| Local variable could be declared final | 155 |
| Local variable could be declared final | 156 |
| Local variable could be declared final | 174 |
| Local variable could be declared final | 176 |
| Local variable could be declared final | 178 |
| Avoid instantiating new objects inside loops | 179 |
| Local variable could be declared final | 194 - 195 |
| Avoid if (x != y) ..; else ..; | 204 - 208 |
| Avoid instantiating new objects inside loops | 211 |
| Parameter 'themeNames' is not assigned and could be declared final | 222 |
| Parameter 'rendererTypes' is not assigned and could be declared final | 242 |
| Assigning an Object to null is a code smell. Consider refactoring. | 244 |
| Parameter 'rendererType' is not assigned and could be declared final | 251 |
| Violation | Line |
|---|---|
| Avoid instantiating new objects inside loops | 66 |
| Overridable method 'loadFromClientProperties' called during object construction | 83 |
| Local variable could be declared final | 90 |
| Local variable could be declared final | 95 |
| Local variable could be declared final | 96 - 97 |
| Local variable could be declared final | 109 - 110 |
| Local variable could be declared final | 118 - 119 |
| Local variable could be declared final | 127 |
| Local variable could be declared final | 128 |
| Local variable could be declared final | 129 |
| Local variable could be declared final | 130 |
| Local variable could be declared final | 132 |
| Local variable could be declared final | 135 |
| Parameter 'localeItem' is not assigned and could be declared final | 141 |
| Avoid if (x != y) ..; else ..; | 142 - 146 |
| Parameter 'facesContext' is not assigned and could be declared final | 150 |
| Parameter 'beanName' is not assigned and could be declared final | 150 |
| Parameter 'debugMode' is not assigned and could be declared final | 159 |
| Local variable could be declared final | 169 |
| Parameter 'theme' is not assigned and could be declared final | 177 |
| Parameter 'themeItems' is not assigned and could be declared final | 185 |
| Avoid if (x != y) ..; else ..; | 194 - 198 |
| Parameter 'locale' is not assigned and could be declared final | 201 |
| Parameter 'contentType' is not assigned and could be declared final | 209 |
| Parameter 'contentTypeItems' is not assigned and could be declared final | 217 |
| Violation | Line |
|---|---|
| Document empty method | 35 - 36 |
| Parameter 'event' is not assigned and could be declared final | 35 |
| Parameter 'event' is not assigned and could be declared final | 38 |
| Local variable could be declared final | 39 |
| Local variable could be declared final | 41 |
| Local variable could be declared final | 42 - 43 |
| Violation | Line |
|---|---|
| The class 'OverviewController' has a Cyclomatic Complexity of 2 (Highest = 13). | 48 - 410 |
| Avoid instantiating new objects inside loops | 111 |
| Avoid instantiating new objects inside loops | 119 |
| Parameter 'resourceManager' is not assigned and could be declared final | 124 |
| Parameter 'resource' is not assigned and could be declared final | 124 |
| Local variable could be declared final | 125 |
| Avoid instantiating new objects inside loops | 136 |
| Parameter 'keys' is not assigned and could be declared final | 142 |
| Parameter 'resourceManager' is not assigned and could be declared final | 142 |
| Parameter 'resource' is not assigned and could be declared final | 142 |
| Avoid instantiating new objects inside loops | 153 |
| Parameter 'actionEvent' is not assigned and could be declared final | 158 |
| Parameter 'event' is not assigned and could be declared final | 163 |
| The method 'sheetSorter' has a Cyclomatic Complexity of 13. | 163 - 226 |
| Local variable could be declared final | 165 |
| Local variable could be declared final | 166 |
| Local variable could be declared final | 167 - 168 |
| Local variable could be declared final | 169 |
| Local variable could be declared final | 170 |
| Local variable could be declared final | 171 |
| Avoid empty catch blocks | 193 - 195 |
| Avoid empty catch blocks | 193 - 195 |
| Must handle exceptions | 193 - 195 |
| Avoid empty catch blocks | 199 - 201 |
| Avoid empty catch blocks | 199 - 201 |
| Must handle exceptions | 199 - 201 |
| Parameter 'component' is not assigned and could be declared final | 233 |
| Parameter 'value' is not assigned and could be declared final | 233 |
| Parameter 'context' is not assigned and could be declared final | 233 |
| Local variable could be declared final | 248 - 249 |
| Local variable could be declared final | 254 - 255 |
| Local variable could be declared final | 262 - 263 |
| Local variable could be declared final | 269 - 270 |
| Parameter 'radioValue' is not assigned and could be declared final | 279 |
| Parameter 'singleValue' is not assigned and could be declared final | 287 |
| Parameter 'multiValue' is not assigned and could be declared final | 295 |
| Parameter 'basicDate' is not assigned and could be declared final | 303 |
| Parameter 'basicTime' is not assigned and could be declared final | 311 |
| Parameter 'treeSelectMode' is not assigned and could be declared final | 319 |
| Parameter 'treeListboxSelectMode' is not assigned and could be declared final | 327 |
| Parameter 'basicInput' is not assigned and could be declared final | 335 |
| Parameter 'basicArea' is not assigned and could be declared final | 343 |
| Parameter 'treeTabsState' is not assigned and could be declared final | 355 |
| Parameter 'sheetConfig' is not assigned and could be declared final | 363 |
| Parameter 'toolbarIconSize' is not assigned and could be declared final | 371 |
| Parameter 'toolbarIconItems' is not assigned and could be declared final | 379 |
| Parameter 'toolbarTextPosition' is not assigned and could be declared final | 387 |
| Parameter 'toolbarTextItems' is not assigned and could be declared final | 395 |
| Parameter 'prefix' is not assigned and could be declared final | 399 |
| Local variable could be declared final | 401 |
| Violation | Line |
|---|---|
| Private field could be made final. It is only initialized in the declaration or constructor. | 51 |
| Private field could be made final. It is only initialized in the declaration or constructor. | 52 |
| Parameter 'values' is not assigned and could be declared final | 77 |
| Avoid instantiating new objects inside loops | 81 |
| Parameter 'sheetShowHeader' is not assigned and could be declared final | 91 |
| Parameter 'sheetRows' is not assigned and could be declared final | 103 |
| Local variable could be declared final | 108 |
| Parameter 'sheetFirst' is not assigned and could be declared final | 112 |
| Parameter 'sheetConfigPopup' is not assigned and could be declared final | 120 |
| Parameter 'sheetDirectLinkCount' is not assigned and could be declared final | 128 |
| Parameter 'sheetRowPagingPosition' is not assigned and could be declared final | 140 |
| Parameter 'sheetDirectPagingPosition' is not assigned and could be declared final | 148 |
| Parameter 'sheetPagePagingPosition' is not assigned and could be declared final | 156 |
| Parameter 'sheetSelectableItems' is not assigned and could be declared final | 168 |
| Parameter 'selectable' is not assigned and could be declared final | 176 |
| Violation | Line |
|---|---|
| Parameter 'outside' is not assigned and could be declared final | 46 |
| Local variable could be declared final | 48 |
| Local variable could be declared final | 56 |
| Violation | Line |
|---|---|
| Local variable could be declared final | 28 |
| Violation | Line |
|---|---|
| Parameter 'args' is not assigned and could be declared final | 37 |
| Parameter 'out' is not assigned and could be declared final | 41 |
| Parameter 'filename' is not assigned and could be declared final | 41 |
| Local variable could be declared final | 43 - 44 |
| Parameter 'out' is not assigned and could be declared final | 52 |
| Parameter 'reader' is not assigned and could be declared final | 52 |
| Local variable could be declared final | 54 |
| Local variable could be declared final | 55 |
| Parameter 'reader' is not assigned and could be declared final | 75 |
| Local variable could be declared final | 76 |
| Local variable could be declared final | 77 |
| All methods are static. Consider using Singleton instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. | 87 |
| Violation | Line |
|---|---|
| The class 'JspTagConverter' has a Cyclomatic Complexity of 2 (Highest = 6). | 34 - 95 |
| Private field could be made final. It is only initialized in the declaration or constructor. | 38 |
| Private field could be made final. It is only initialized in the declaration or constructor. | 39 |
| Parameter 'java' is not assigned and could be declared final | 47 |
| Parameter 'fragment' is not assigned and could be declared final | 60 |
| The method 'convertMatch' has a Cyclomatic Complexity of 6. | 60 - 85 |
| An empty statement (semicolon) not part of a loop | 61 |
| Local variable could be declared final | 61 |
| An empty statement (semicolon) not part of a loop | 61 |
| Parameter 'input' is not assigned and could be declared final | 87 |
| Local variable could be declared final | 91 |
| Violation | Line |
|---|---|
| Parameter 'fragment' is not assigned and could be declared final | 34 |
| Local variable could be declared final | 37 - 38 |
| Violation | Line |
|---|---|
| The class 'StringExpression' has a Cyclomatic Complexity of 3 (Highest = 7). | 35 - 116 |
| Private field could be made final. It is only initialized in the declaration or constructor. | 41 |
| Parameter 'variables' is not assigned and could be declared final | 51 |
| The method 'replaceVariables' has a Cyclomatic Complexity of 5. | 56 - 84 |
| Parameter 'variables' is not assigned and could be declared final | 57 |
| Parameter 'stringExpression' is not assigned and could be declared final | 57 |
| Local variable could be declared final | 62 |
| Use ArrayList instead of Vector | 62 |
| Local variable could be declared final | 63 |
| Use ArrayList instead of Vector | 63 |
| Local variable could be declared final | 66 |
| Local variable could be declared final | 67 |
| Local variable could be declared final | 68 |
| Local variable could be declared final | 72 |
| The method 'parsePropertyString' has a Cyclomatic Complexity of 7. | 86 - 114 |
| Parameter 'value' is not assigned and could be declared final | 87 |
| Parameter 'propertyRefs' is not assigned and could be declared final | 87 |
| Parameter 'fragments' is not assigned and could be declared final | 87 |
| Avoid using implementation types like 'Vector'; use the interface instead | 87 |
| Avoid using implementation types like 'Vector'; use the interface instead | 87 |
| Avoid if (x != y) ..; else ..; | 97 - 109 |
| Local variable could be declared final | 101 |
| Local variable could be declared final | 105 |
| Violation | Line |
|---|---|
| Private field could be made final. It is only initialized in the declaration or constructor. | 41 |
| Private field could be made final. It is only initialized in the declaration or constructor. | 42 |
| Private field could be made final. It is only initialized in the declaration or constructor. | 43 |
| Parameter 'start' is not assigned and could be declared final | 66 |
| Parameter 'data' is not assigned and could be declared final | 66 |
| Parameter 'end' is not assigned and could be declared final | 66 |
| Parameter 'start' is not assigned and could be declared final | 70 |
| Parameter 'data' is not assigned and could be declared final | 70 |
| Parameter 'end' is not assigned and could be declared final | 70 |
| Parameter 'start' is not assigned and could be declared final | 74 |
| Parameter 'data' is not assigned and could be declared final | 74 |
| Parameter 'end' is not assigned and could be declared final | 74 |
| Parameter 'fragment' is not assigned and could be declared final | 78 |
| Parameter 'input' is not assigned and could be declared final | 82 |
| Local variable could be declared final | 83 |
| Local variable could be declared final | 85 |
| Local variable could be declared final | 86 |
| Local variable could be declared final | 89 |
| Local variable could be declared final | 90 |
| Local variable could be declared final | 91 |
| Parameter 'input' is not assigned and could be declared final | 101 |
| Violation | Line |
|---|---|
| Local variable could be declared final | 101 |
| Consider simply returning the value vs storing it in local variable 'selected' | 102 |
| Parameter 'viewId' is not assigned and could be declared final | 105 |
| Local variable could be declared final | 106 |
| Local variable could be declared final | 108 |
| Local variable could be declared final | 109 |
| Parameter 'tree' is not assigned and could be declared final | 121 |
| Parameter 'state' is not assigned and could be declared final | 129 |
| Local variable could be declared final | 134 |
| Local variable could be declared final | 140 |
| Local variable could be declared final | 149 |
| Local variable could be declared final | 166 |
| Local variable could be declared final | 167 |
| Local variable could be declared final | 168 |
| Local variable could be declared final | 169 |
| Local variable could be declared final | 173 |
| Local variable could be declared final | 174 |
| Parameter 'title' is not assigned and could be declared final | 203 |
| Parameter 'id' is not assigned and could be declared final | 211 |
| Parameter 'outcome' is not assigned and could be declared final | 219 |
| Violation | Line |
|---|---|
| Parameter 'version' is not assigned and could be declared final | 81 |
| Parameter 'enabled' is not assigned and could be declared final | 89 |
| Violation | Line |
|---|---|
| Document empty method | 30 - 31 |
| Parameter 'event' is not assigned and could be declared final | 30 |
| Parameter 'event' is not assigned and could be declared final | 33 |
| Local variable could be declared final | 35 |
| Local variable could be declared final | 36 |
| Local variable could be declared final | 38 |
| Local variable could be declared final | 39 |
| Violation | Line |
|---|---|
| Local variable could be declared final | 222 |
| Local variable could be declared final | 223 |
| Local variable could be declared final | 227 |
| Parameter 'tabChangeListener' is not assigned and could be declared final | 237 |
| Local variable could be declared final | 244 |
| Local variable could be declared final | 246 - 247 |
| Parameter 'keys' is not assigned and could be declared final | 264 |
| Parameter 'bundle' is not assigned and could be declared final | 264 |
| Local variable could be declared final | 265 |
| Local variable could be declared final | 268 |
| Avoid instantiating new objects inside loops | 269 |
| Document empty method | 274 - 276 |
| Parameter 'name' is not assigned and could be declared final | 278 |
| Parameter 'id' is not assigned and could be declared final | 278 |
| Parameter 'salutation' is not assigned and could be declared final | 295 |
| Parameter 'salutationItems' is not assigned and could be declared final | 303 |
| Parameter 'argBool' is not assigned and could be declared final | 311 |
| Parameter 'boolTest' is not assigned and could be declared final | 319 |
| Parameter 'text' is not assigned and could be declared final | 327 |
| Parameter 'solarArray' is not assigned and could be declared final | 335 |
| Parameter 'solarList' is not assigned and could be declared final | 347 |
| Parameter 'solarArrayColumns' is not assigned and could be declared final | 355 |
| Parameter 'solarArrayColumnLayout' is not assigned and could be declared final | 363 |
| Parameter 'tree' is not assigned and could be declared final | 371 |
| Parameter 'treeState' is not assigned and could be declared final | 379 |
| Parameter 'showJunctions' is not assigned and could be declared final | 387 |
| Parameter 'showIcons' is not assigned and could be declared final | 395 |
| Parameter 'showRoot' is not assigned and could be declared final | 403 |
| Parameter 'showRootJunction' is not assigned and could be declared final | 411 |
| Parameter 'multiselect' is not assigned and could be declared final | 419 |
| Parameter 'selectionType' is not assigned and could be declared final | 427 |
| Parameter 'selectionItems' is not assigned and could be declared final | 435 |
| Parameter 'mutable' is not assigned and could be declared final | 443 |
| Parameter 'required' is not assigned and could be declared final | 451 |
| Parameter 'solar' is not assigned and could be declared final | 459 |
| Parameter 'date' is not assigned and could be declared final | 467 |
| Parameter 'tabState0' is not assigned and could be declared final | 475 |
| Parameter 'tabState1' is not assigned and could be declared final | 483 |
| Parameter 'tabState2' is not assigned and could be declared final | 491 |
| Parameter 'sheetState' is not assigned and could be declared final | 499 |
| Parameter 'e' is not assigned and could be declared final | 503 |
| Parameter 'component' is not assigned and could be declared final | 508 |
| Parameter 'value' is not assigned and could be declared final | 508 |
| Parameter 'context' is not assigned and could be declared final | 508 |
| Parameter 'toolbarIconSize' is not assigned and could be declared final | 526 |
| Parameter 'toolbarTextPosition' is not assigned and could be declared final | 538 |
| Document empty method | 546 - 548 |
| Parameter 'o' is not assigned and could be declared final | 546 |
| Parameter 'name' is not assigned and could be declared final | 565 |
| Parameter 'id' is not assigned and could be declared final | 573 |
| Violation | Line |
|---|---|
| Parameter 'component' is not assigned and could be declared final | 36 |
| Parameter 'value' is not assigned and could be declared final | 36 |
| Parameter 'context' is not assigned and could be declared final | 36 |
| Parameter 'component' is not assigned and could be declared final | 41 |
| Parameter 'value' is not assigned and could be declared final | 41 |
| Parameter 'context' is not assigned and could be declared final | 41 |
| Violation | Line |
|---|---|
| Parameter 'number' is not assigned and could be declared final | 38 |
| Parameter 'value' is not assigned and could be declared final | 46 |
| Parameter 'date' is not assigned and could be declared final | 54 |
| Violation | Line |
|---|---|
| Local variable could be declared final | 33 - 34 |
| Parameter 'controller' is not assigned and could be declared final | 56 |
| Violation | Line |
|---|---|
| Parameter 'tree' is not assigned and could be declared final | 67 |
| Parameter 'state' is not assigned and could be declared final | 75 |
| Violation | Line |
|---|---|
| Private field could be made final. It is only initialized in the declaration or constructor. | 37 |
| Private field could be made final. It is only initialized in the declaration or constructor. | 39 |
| Private field could be made final. It is only initialized in the declaration or constructor. | 45 |
| Private field could be made final. It is only initialized in the declaration or constructor. | 47 |
| Private field could be made final. It is only initialized in the declaration or constructor. | 49 |
| Parameter 'manufacturer' is not assigned and could be declared final | 88 |
| Parameter 'vehicle' is not assigned and could be declared final | 105 |
| Parameter 'event' is not assigned and could be declared final | 118 |
| Local variable could be declared final | 125 |
| Local variable could be declared final | 126 |
| Parameter 'text' is not assigned and could be declared final | 148 |
| Parameter 'bool' is not assigned and could be declared final | 157 |
| Violation | Line |
|---|---|
| Private field could be made final. It is only initialized in the declaration or constructor. | 28 |
| Violation | Line |
|---|---|
| Private field could be made final. It is only initialized in the declaration or constructor. | 22 |
| Parameter 'name' is not assigned and could be declared final | 39 |
| Parameter 'tip' is not assigned and could be declared final | 47 |
| Violation | Line |
|---|---|
| Private field could be made final. It is only initialized in the declaration or constructor. | 36 |
| Avoid instantiating new objects inside loops | 42 |
| Parameter 'event' is not assigned and could be declared final | 50 |
| Local variable could be declared final | 56 |
| Parameter 'event' is not assigned and could be declared final | 61 |
| Parameter 'entry' is not assigned and could be declared final | 75 |
| Parameter 'column1' is not assigned and could be declared final | 88 |
| Parameter 'column2' is not assigned and could be declared final | 96 |
| Parameter 'column3' is not assigned and could be declared final | 104 |
| Violation | Line |
|---|---|
| The class 'PartialReloadController' has a Cyclomatic Complexity of 2 (Highest = 6). | 30 - 103 |
| The method 'navigateAction' has a Cyclomatic Complexity of 6. | 59 - 88 |
| Local variable could be declared final | 60 |
| Local variable could be declared final | 61 |
| Local variable could be declared final | 62 |
| Assigning an Object to null is a code smell. Consider refactoring. | 72 |
| Assigning an Object to null is a code smell. Consider refactoring. | 78 |
| Assigning an Object to null is a code smell. Consider refactoring. | 81 |
| Assigning an Object to null is a code smell. Consider refactoring. | 84 |
| Parameter 'navValue' is not assigned and could be declared final | 90 |
| Parameter 'navigateAction' is not assigned and could be declared final | 100 |