PMD Results

The following document contains the results of PMD 3.7.

Files

org/apache/myfaces/tobago/facelets/FixCharacterEncodingFilter.java

ViolationLine
Document empty method34 - 36
Parameter 'filterConfig' is not assigned and could be declared final34
Parameter 'servletRequest' is not assigned and could be declared final38
Parameter 'filterChain' is not assigned and could be declared final39
Parameter 'servletResponse' is not assigned and could be declared final39
Document empty method47 - 48

org/apache/myfaces/tobago/facelets/PopupReferenceHandler.java

ViolationLine
Parameter 'faceletContext' is not assigned and could be declared final50
Parameter 'parent' is not assigned and could be declared final50
Local variable could be declared final54

org/apache/myfaces/tobago/facelets/TabChangeListenerHandler.java

ViolationLine
The class 'TabChangeListenerHandler' has a Cyclomatic Complexity of 6 (Highest = 7).44 - 102
Parameter 'faceletContext' is not assigned and could be declared final69
Parameter 'parent' is not assigned and could be declared final69
The method 'apply' has a Cyclomatic Complexity of 7.69 - 101
Local variable could be declared final74
Deeply nested if..then statements are hard to read87 - 89
Avoid if (x != y) ..; else ..;91 - 96

org/apache/myfaces/tobago/facelets/AttributeHandler.java

ViolationLine
The class 'AttributeHandler' has a Cyclomatic Complexity of 8 (Highest = 20).47 - 152
Parameter 'faceletContext' is not assigned and could be declared final60
Parameter 'parent' is not assigned and could be declared final60
The method 'apply' has a Cyclomatic Complexity of 20.60 - 125
Local variable could be declared final67
Local variable could be declared final85
Local variable could be declared final92
Local variable could be declared final99 - 100
Local variable could be declared final106
Local variable could be declared final112
Parameter 'faceletContext' is not assigned and could be declared final127
Parameter 'args' is not assigned and could be declared final127
Parameter 'returnType' is not assigned and could be declared final127
Local variable could be declared final133
No need to check for null before an instanceof134
Local variable could be declared final135
Local variable could be declared final140
Local variable could be declared final141
Local variable could be declared final142

org/apache/myfaces/tobago/facelets/ScriptHandler.java

ViolationLine
The class 'ScriptHandler' has a Cyclomatic Complexity of 5 (Highest = 8).40 - 87
Parameter 'faceletContext' is not assigned and could be declared final55
Parameter 'parent' is not assigned and could be declared final55
The method 'apply' has a Cyclomatic Complexity of 8.55 - 86
Local variable could be declared final59
Local variable could be declared final72
Local variable could be declared final73
Local variable could be declared final75
Local variable could be declared final78

org/apache/myfaces/tobago/facelets/PageRule.java

ViolationLine
The class 'PageRule' has a Cyclomatic Complexity of 6 (Highest = 5).37 - 97
Parameter 'attribute' is not assigned and could be declared final40
Parameter 'name' is not assigned and could be declared final40
The method 'applyRule' has a Cyclomatic Complexity of 5.40 - 53
Parameter 'metadataTarget' is not assigned and could be declared final41
These nested if statements could be combined43 - 50
These nested if statements could be combined43 - 50
Deeply nested if..then statements are hard to read44 - 46
Deeply nested if..then statements are hard to read47 - 49
Parameter 'instance' is not assigned and could be declared final67
Parameter 'ctx' is not assigned and could be declared final67
Parameter 'instance' is not assigned and could be declared final79
Parameter 'ctx' is not assigned and could be declared final79
Local variable could be declared final80
Parameter 'instance' is not assigned and could be declared final92
Parameter 'ctx' is not assigned and could be declared final92
Local variable could be declared final93

org/apache/myfaces/tobago/facelets/ConverterHandler.java

ViolationLine
The class 'ConverterHandler' has a Cyclomatic Complexity of 4 (Highest = 7).43 - 86
Parameter 'faceletContext' is not assigned and could be declared final55
Parameter 'parent' is not assigned and could be declared final55
The method 'apply' has a Cyclomatic Complexity of 7.55 - 85
Local variable could be declared final59
Caught exception is rethrown, original stack trace may be lost71
Deeply nested if..then statements are hard to read73 - 75

org/apache/myfaces/tobago/facelets/TabChangeSourceRule.java

ViolationLine
Parameter 'attribute' is not assigned and could be declared final38
Parameter 'name' is not assigned and could be declared final38
Parameter 'metadataTarget' is not assigned and could be declared final39
These nested if statements could be combined41 - 43
These nested if statements could be combined41 - 43
Parameter 'instance' is not assigned and could be declared final56
Parameter 'ctx' is not assigned and could be declared final56

org/apache/myfaces/tobago/facelets/LoadBundleHandler.java

ViolationLine
Parameter 'faceletContext' is not assigned and could be declared final50
Parameter 'parent' is not assigned and could be declared final50
Local variable could be declared final52
Local variable could be declared final53
Local variable could be declared final54

org/apache/myfaces/tobago/facelets/SupportsMarkupRule.java

ViolationLine
Parameter 'attribute' is not assigned and could be declared final38
Parameter 'name' is not assigned and could be declared final38
Parameter 'metadataTarget' is not assigned and could be declared final39
These nested if statements could be combined41 - 43
These nested if statements could be combined41 - 43
Parameter 'instance' is not assigned and could be declared final56
Parameter 'ctx' is not assigned and could be declared final56

org/apache/myfaces/tobago/facelets/SheetStateChangeSourceRule.java

ViolationLine
Parameter 'attribute' is not assigned and could be declared final38
Parameter 'name' is not assigned and could be declared final38
Parameter 'metadataTarget' is not assigned and could be declared final39
These nested if statements could be combined41 - 43
These nested if statements could be combined41 - 43
Parameter 'instance' is not assigned and could be declared final56
Parameter 'ctx' is not assigned and could be declared final56

org/apache/myfaces/tobago/facelets/TobagoComponentHandler.java

ViolationLine
The class 'TobagoComponentHandler' has a Cyclomatic Complexity of 3 (Highest = 6).39 - 72
Parameter 'aClass' is not assigned and could be declared final45
The method 'createMetaRuleset' has a Cyclomatic Complexity of 6.45 - 63
Local variable could be declared final46
Parameter 'component' is not assigned and could be declared final64
Parameter 'context' is not assigned and could be declared final64
Parameter 'parent' is not assigned and could be declared final65

org/apache/myfaces/tobago/facelets/extension/DateExtensionHandler.java

ViolationLine
Parameter 'faceletContext' is not assigned and could be declared final49
Parameter 'parent' is not assigned and could be declared final49
Parameter 'panel' is not assigned and could be declared final49
Local variable could be declared final51
Local variable could be declared final52
Local variable could be declared final55
Parameter 'first' is not assigned and could be declared final65

org/apache/myfaces/tobago/facelets/extension/TobagoLabelExtensionHandler.java

ViolationLine
The class 'TobagoLabelExtensionHandler' has a Cyclomatic Complexity of 2 (Highest = 5).44 - 152
Private field 'labelWidthAttribute' could be made final; it is only initialized in the declaration or constructor.45
Private field 'tipAttribute' could be made final; it is only initialized in the declaration or constructor.46
Private field 'labelAttribute' could be made final; it is only initialized in the declaration or constructor.47
Parameter 'first' is not assigned and could be declared final60
Parameter 'ctx' is not assigned and could be declared final64
Parameter 'panel' is not assigned and could be declared final64
Local variable could be declared final68
Local variable could be declared final79
Parameter 'faceletContext' is not assigned and could be declared final84
Parameter 'parent' is not assigned and could be declared final84
Parameter 'panel' is not assigned and could be declared final84
Local variable could be declared final86
Local variable could be declared final87
Local variable could be declared final93
Local variable could be declared final95
Parameter 'faceletContext' is not assigned and could be declared final104
Parameter 'root' is not assigned and could be declared final104
Parameter 'panel' is not assigned and could be declared final104
Local variable could be declared final105
Local variable could be declared final106
Parameter 'faceletContext' is not assigned and could be declared final119
Parameter 'root' is not assigned and could be declared final119
Parameter 'panel' is not assigned and could be declared final119
Local variable could be declared final120
Local variable could be declared final121
Avoid if (x != y) ..; else ..;123 - 127
Parameter 'aClass' is not assigned and could be declared final133
The method 'createMetaRuleset' has a Cyclomatic Complexity of 5.133 - 151
Local variable could be declared final134

org/apache/myfaces/tobago/facelets/extension/TobagoMenuExtensionHandler.java

ViolationLine
Parameter 'faceletContext' is not assigned and could be declared final49
Parameter 'menuCommand' is not assigned and could be declared final49
Local variable could be declared final52
Parameter 'faceletContext' is not assigned and could be declared final60
Parameter 'menuCommand' is not assigned and could be declared final60
Parameter 'parent' is not assigned and could be declared final60
Local variable could be declared final62
Local variable could be declared final63
Local variable could be declared final64
Parameter 'aClass' is not assigned and could be declared final70
Local variable could be declared final71

org/apache/myfaces/tobago/facelets/SortActionSourceRule.java

ViolationLine
Parameter 'attribute' is not assigned and could be declared final38
Parameter 'name' is not assigned and could be declared final38
Parameter 'metadataTarget' is not assigned and could be declared final39
These nested if statements could be combined41 - 43
These nested if statements could be combined41 - 43
Parameter 'instance' is not assigned and could be declared final56
Parameter 'ctx' is not assigned and could be declared final56

org/apache/myfaces/tobago/facelets/StyleHandler.java

ViolationLine
The class 'StyleHandler' has a Cyclomatic Complexity of 4 (Highest = 5).40 - 72
Parameter 'faceletContext' is not assigned and could be declared final49
Parameter 'parent' is not assigned and could be declared final49
The method 'apply' has a Cyclomatic Complexity of 5.49 - 71
Local variable could be declared final53
Local variable could be declared final57
Local variable could be declared final58
Local variable could be declared final60
Local variable could be declared final63