The following document contains the results of PMD 3.7.
Violation | Line |
---|---|
Document empty method | 34 - 36 |
Parameter 'filterConfig' is not assigned and could be declared final | 34 |
Parameter 'servletRequest' is not assigned and could be declared final | 38 |
Parameter 'filterChain' is not assigned and could be declared final | 39 |
Parameter 'servletResponse' is not assigned and could be declared final | 39 |
Document empty method | 47 - 48 |
Violation | Line |
---|---|
Parameter 'faceletContext' is not assigned and could be declared final | 50 |
Parameter 'parent' is not assigned and could be declared final | 50 |
Local variable could be declared final | 54 |
Violation | Line |
---|---|
The class 'TabChangeListenerHandler' has a Cyclomatic Complexity of 6 (Highest = 7). | 44 - 102 |
Parameter 'faceletContext' is not assigned and could be declared final | 69 |
Parameter 'parent' is not assigned and could be declared final | 69 |
The method 'apply' has a Cyclomatic Complexity of 7. | 69 - 101 |
Local variable could be declared final | 74 |
Deeply nested if..then statements are hard to read | 87 - 89 |
Avoid if (x != y) ..; else ..; | 91 - 96 |
Violation | Line |
---|---|
The class 'AttributeHandler' has a Cyclomatic Complexity of 8 (Highest = 20). | 47 - 152 |
Parameter 'faceletContext' is not assigned and could be declared final | 60 |
Parameter 'parent' is not assigned and could be declared final | 60 |
The method 'apply' has a Cyclomatic Complexity of 20. | 60 - 125 |
Local variable could be declared final | 67 |
Local variable could be declared final | 85 |
Local variable could be declared final | 92 |
Local variable could be declared final | 99 - 100 |
Local variable could be declared final | 106 |
Local variable could be declared final | 112 |
Parameter 'faceletContext' is not assigned and could be declared final | 127 |
Parameter 'args' is not assigned and could be declared final | 127 |
Parameter 'returnType' is not assigned and could be declared final | 127 |
Local variable could be declared final | 133 |
No need to check for null before an instanceof | 134 |
Local variable could be declared final | 135 |
Local variable could be declared final | 140 |
Local variable could be declared final | 141 |
Local variable could be declared final | 142 |
Violation | Line |
---|---|
The class 'ScriptHandler' has a Cyclomatic Complexity of 5 (Highest = 8). | 40 - 87 |
Parameter 'faceletContext' is not assigned and could be declared final | 55 |
Parameter 'parent' is not assigned and could be declared final | 55 |
The method 'apply' has a Cyclomatic Complexity of 8. | 55 - 86 |
Local variable could be declared final | 59 |
Local variable could be declared final | 72 |
Local variable could be declared final | 73 |
Local variable could be declared final | 75 |
Local variable could be declared final | 78 |
Violation | Line |
---|---|
The class 'PageRule' has a Cyclomatic Complexity of 6 (Highest = 5). | 37 - 97 |
Parameter 'attribute' is not assigned and could be declared final | 40 |
Parameter 'name' is not assigned and could be declared final | 40 |
The method 'applyRule' has a Cyclomatic Complexity of 5. | 40 - 53 |
Parameter 'metadataTarget' is not assigned and could be declared final | 41 |
These nested if statements could be combined | 43 - 50 |
These nested if statements could be combined | 43 - 50 |
Deeply nested if..then statements are hard to read | 44 - 46 |
Deeply nested if..then statements are hard to read | 47 - 49 |
Parameter 'instance' is not assigned and could be declared final | 67 |
Parameter 'ctx' is not assigned and could be declared final | 67 |
Parameter 'instance' is not assigned and could be declared final | 79 |
Parameter 'ctx' is not assigned and could be declared final | 79 |
Local variable could be declared final | 80 |
Parameter 'instance' is not assigned and could be declared final | 92 |
Parameter 'ctx' is not assigned and could be declared final | 92 |
Local variable could be declared final | 93 |
Violation | Line |
---|---|
The class 'ConverterHandler' has a Cyclomatic Complexity of 4 (Highest = 7). | 43 - 86 |
Parameter 'faceletContext' is not assigned and could be declared final | 55 |
Parameter 'parent' is not assigned and could be declared final | 55 |
The method 'apply' has a Cyclomatic Complexity of 7. | 55 - 85 |
Local variable could be declared final | 59 |
Caught exception is rethrown, original stack trace may be lost | 71 |
Deeply nested if..then statements are hard to read | 73 - 75 |
Violation | Line |
---|---|
Parameter 'attribute' is not assigned and could be declared final | 38 |
Parameter 'name' is not assigned and could be declared final | 38 |
Parameter 'metadataTarget' is not assigned and could be declared final | 39 |
These nested if statements could be combined | 41 - 43 |
These nested if statements could be combined | 41 - 43 |
Parameter 'instance' is not assigned and could be declared final | 56 |
Parameter 'ctx' is not assigned and could be declared final | 56 |
Violation | Line |
---|---|
Parameter 'faceletContext' is not assigned and could be declared final | 50 |
Parameter 'parent' is not assigned and could be declared final | 50 |
Local variable could be declared final | 52 |
Local variable could be declared final | 53 |
Local variable could be declared final | 54 |
Violation | Line |
---|---|
Parameter 'attribute' is not assigned and could be declared final | 38 |
Parameter 'name' is not assigned and could be declared final | 38 |
Parameter 'metadataTarget' is not assigned and could be declared final | 39 |
These nested if statements could be combined | 41 - 43 |
These nested if statements could be combined | 41 - 43 |
Parameter 'instance' is not assigned and could be declared final | 56 |
Parameter 'ctx' is not assigned and could be declared final | 56 |
Violation | Line |
---|---|
Parameter 'attribute' is not assigned and could be declared final | 38 |
Parameter 'name' is not assigned and could be declared final | 38 |
Parameter 'metadataTarget' is not assigned and could be declared final | 39 |
These nested if statements could be combined | 41 - 43 |
These nested if statements could be combined | 41 - 43 |
Parameter 'instance' is not assigned and could be declared final | 56 |
Parameter 'ctx' is not assigned and could be declared final | 56 |
Violation | Line |
---|---|
The class 'TobagoComponentHandler' has a Cyclomatic Complexity of 3 (Highest = 6). | 39 - 72 |
Parameter 'aClass' is not assigned and could be declared final | 45 |
The method 'createMetaRuleset' has a Cyclomatic Complexity of 6. | 45 - 63 |
Local variable could be declared final | 46 |
Parameter 'component' is not assigned and could be declared final | 64 |
Parameter 'context' is not assigned and could be declared final | 64 |
Parameter 'parent' is not assigned and could be declared final | 65 |
Violation | Line |
---|---|
Parameter 'faceletContext' is not assigned and could be declared final | 49 |
Parameter 'parent' is not assigned and could be declared final | 49 |
Parameter 'panel' is not assigned and could be declared final | 49 |
Local variable could be declared final | 51 |
Local variable could be declared final | 52 |
Local variable could be declared final | 55 |
Parameter 'first' is not assigned and could be declared final | 65 |
Violation | Line |
---|---|
The class 'TobagoLabelExtensionHandler' has a Cyclomatic Complexity of 2 (Highest = 5). | 44 - 152 |
Private field 'labelWidthAttribute' could be made final; it is only initialized in the declaration or constructor. | 45 |
Private field 'tipAttribute' could be made final; it is only initialized in the declaration or constructor. | 46 |
Private field 'labelAttribute' could be made final; it is only initialized in the declaration or constructor. | 47 |
Parameter 'first' is not assigned and could be declared final | 60 |
Parameter 'ctx' is not assigned and could be declared final | 64 |
Parameter 'panel' is not assigned and could be declared final | 64 |
Local variable could be declared final | 68 |
Local variable could be declared final | 79 |
Parameter 'faceletContext' is not assigned and could be declared final | 84 |
Parameter 'parent' is not assigned and could be declared final | 84 |
Parameter 'panel' is not assigned and could be declared final | 84 |
Local variable could be declared final | 86 |
Local variable could be declared final | 87 |
Local variable could be declared final | 93 |
Local variable could be declared final | 95 |
Parameter 'faceletContext' is not assigned and could be declared final | 104 |
Parameter 'root' is not assigned and could be declared final | 104 |
Parameter 'panel' is not assigned and could be declared final | 104 |
Local variable could be declared final | 105 |
Local variable could be declared final | 106 |
Parameter 'faceletContext' is not assigned and could be declared final | 119 |
Parameter 'root' is not assigned and could be declared final | 119 |
Parameter 'panel' is not assigned and could be declared final | 119 |
Local variable could be declared final | 120 |
Local variable could be declared final | 121 |
Avoid if (x != y) ..; else ..; | 123 - 127 |
Parameter 'aClass' is not assigned and could be declared final | 133 |
The method 'createMetaRuleset' has a Cyclomatic Complexity of 5. | 133 - 151 |
Local variable could be declared final | 134 |
Violation | Line |
---|---|
Parameter 'faceletContext' is not assigned and could be declared final | 49 |
Parameter 'menuCommand' is not assigned and could be declared final | 49 |
Local variable could be declared final | 52 |
Parameter 'faceletContext' is not assigned and could be declared final | 60 |
Parameter 'menuCommand' is not assigned and could be declared final | 60 |
Parameter 'parent' is not assigned and could be declared final | 60 |
Local variable could be declared final | 62 |
Local variable could be declared final | 63 |
Local variable could be declared final | 64 |
Parameter 'aClass' is not assigned and could be declared final | 70 |
Local variable could be declared final | 71 |
Violation | Line |
---|---|
Parameter 'attribute' is not assigned and could be declared final | 38 |
Parameter 'name' is not assigned and could be declared final | 38 |
Parameter 'metadataTarget' is not assigned and could be declared final | 39 |
These nested if statements could be combined | 41 - 43 |
These nested if statements could be combined | 41 - 43 |
Parameter 'instance' is not assigned and could be declared final | 56 |
Parameter 'ctx' is not assigned and could be declared final | 56 |
Violation | Line |
---|---|
The class 'StyleHandler' has a Cyclomatic Complexity of 4 (Highest = 5). | 40 - 72 |
Parameter 'faceletContext' is not assigned and could be declared final | 49 |
Parameter 'parent' is not assigned and could be declared final | 49 |
The method 'apply' has a Cyclomatic Complexity of 5. | 49 - 71 |
Local variable could be declared final | 53 |
Local variable could be declared final | 57 |
Local variable could be declared final | 58 |
Local variable could be declared final | 60 |
Local variable could be declared final | 63 |