FindBugs Bug Detector Report
The following document contains the results of FindBugs Report
FindBugs Version is 1.3.9
Threshold is low
Effort is min
Files
org.apache.myfaces.extensions.validator.core.ExtValContext
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Incorrect lazy initialization of static field org.apache.myfaces.extensions.validator.core.ExtValContext.extValContext in org.apache.myfaces.extensions.validator.core.ExtValContext.getContext() | MT_CORRECTNESS | LI_LAZY_INIT_STATIC | 145-147 | Medium |
org.apache.myfaces.extensions.validator.core.ExtValContext$1
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| The class org.apache.myfaces.extensions.validator.core.ExtValContext$1 could be refactored into a named _static_ inner class | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC_ANON | 236-240 | Low |
org.apache.myfaces.extensions.validator.core.ExtValContextInvocationOrderAwareInternals
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unchecked/unconfirmed cast from org.apache.myfaces.extensions.validator.core.interceptor.PropertyValidationInterceptor to org.apache.myfaces.extensions.validator.core.ValidationModuleAware in org.apache.myfaces.extensions.validator.core.ExtValContextInvocationOrderAwareInternals.addPropertyValidationInterceptorForModules(PropertyValidationInterceptor) | STYLE | BC_UNCONFIRMED_CAST | 126 | Low |
org.apache.myfaces.extensions.validator.core.InformationProviderBean
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Method org.apache.myfaces.extensions.validator.core.InformationProviderBean.get(CustomInformation) uses the same code for two switch clauses | STYLE | DB_DUPLICATE_SWITCH_CLAUSES | 147 | Low |
org.apache.myfaces.extensions.validator.core.el.DefaultELHelper
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Use of non-localized String.toUpperCase() or String.toLowerCase | I18N | DM_CONVERT_CASE | 248 | Low |
| Method call in org.apache.myfaces.extensions.validator.core.el.DefaultELHelper.extractPropertyNameOfPropertyPath(String) passes null for nonnull parameter of org.apache.myfaces.extensions.validator.util.ReflectionUtils.tryToInvokeMethod(Object, Method) | CORRECTNESS | NP_NULL_PARAM_DEREF | 261 | Medium |
| Redundant nullcheck of result, which is known to be non-null in org.apache.myfaces.extensions.validator.core.el.DefaultELHelper.getValueBindingExpression(UIComponent, boolean) | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE | 127 | Low |
org.apache.myfaces.extensions.validator.core.el.ExtValELResolver
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Use of non-localized String.toUpperCase() or String.toLowerCase | I18N | DM_CONVERT_CASE | 116 | Low |
org.apache.myfaces.extensions.validator.core.el.FaceletsTaglibExpressionHelper
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Exception is caught when Exception is not thrown in org.apache.myfaces.extensions.validator.core.el.FaceletsTaglibExpressionHelper.tryToCreateValueBindingForFaceletsBinding(UIComponent) | STYLE | REC_CATCH_EXCEPTION | 72 | Low |
| Method org.apache.myfaces.extensions.validator.core.el.FaceletsTaglibExpressionHelper.addFurtherBindingParts(String, String[], int) concatenates strings using + in a loop | PERFORMANCE | SBSC_USE_STRINGBUFFER_CONCATENATION | 200 | Medium |
| Method org.apache.myfaces.extensions.validator.core.el.FaceletsTaglibExpressionHelper.tryToTransformToRealBinding(String, Map, Map) makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 152 | Medium |
org.apache.myfaces.extensions.validator.core.factory.AbstractNameMapperAwareFactory
| Bug | Category | Details | Line | Priority |
|---|
org.apache.myfaces.extensions.validator.core.initializer.configuration.StaticResourceBundleConfiguration
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| StaticResourceBundleConfiguration.mappings not initialized in constructor | STYLE | UWF_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR | Not available | Low |
org.apache.myfaces.extensions.validator.core.metadata.extractor.DefaultComponentMetaDataExtractorFactory
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Incorrect lazy initialization of static field org.apache.myfaces.extensions.validator.core.metadata.extractor.DefaultComponentMetaDataExtractorFactory.metaDataExtractor in org.apache.myfaces.extensions.validator.core.metadata.extractor.DefaultComponentMetaDataExtractorFactory.createWith(Map) | MT_CORRECTNESS | LI_LAZY_INIT_STATIC | 69-81 | Low |
org.apache.myfaces.extensions.validator.core.metadata.transformer.SortedNameMapperList
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.myfaces.extensions.validator.core.metadata.transformer.SortedNameMapperList doesn't override java.util.concurrent.CopyOnWriteArrayList.equals(Object) | STYLE | EQ_DOESNT_OVERRIDE_EQUALS | 40-223 | Medium |
| Class org.apache.myfaces.extensions.validator.core.metadata.transformer.SortedNameMapperList defines non-transient non-serializable instance field globalSubNameMapperList | BAD_PRACTICE | SE_BAD_FIELD | Not available | Low |
| Class org.apache.myfaces.extensions.validator.core.metadata.transformer.SortedNameMapperList defines non-transient non-serializable instance field wrapped | BAD_PRACTICE | SE_BAD_FIELD | Not available | Low |
org.apache.myfaces.extensions.validator.core.renderkit.DefaultRenderKitWrapperFactory
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Incorrect lazy initialization of static field org.apache.myfaces.extensions.validator.core.renderkit.DefaultRenderKitWrapperFactory.useGenericRenderKitWrapperFactory in org.apache.myfaces.extensions.validator.core.renderkit.DefaultRenderKitWrapperFactory.createWrapper(RenderKit) | MT_CORRECTNESS | LI_LAZY_INIT_STATIC | 43-46 | Low |
org.apache.myfaces.extensions.validator.core.renderkit.ExtValLazyRendererProxy
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Exception is caught when Exception is not thrown in org.apache.myfaces.extensions.validator.core.renderkit.ExtValLazyRendererProxy.getLazyRenderer() | STYLE | REC_CATCH_EXCEPTION | 140 | Low |
org.apache.myfaces.extensions.validator.core.renderkit.ExtValRenderKitFactory
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Inconsistent synchronization of org.apache.myfaces.extensions.validator.core.renderkit.ExtValRenderKitFactory.defaultRenderKitWrapperFactory; locked 50% of time | MT_CORRECTNESS | IS2_INCONSISTENT_SYNC | 81 | Medium |
org.apache.myfaces.extensions.validator.core.startup.ExtValLifecycleWrapper
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Inconsistent synchronization of org.apache.myfaces.extensions.validator.core.startup.ExtValLifecycleWrapper.initialized; locked 50% of time | MT_CORRECTNESS | IS2_INCONSISTENT_SYNC | 55 | Medium |
org.apache.myfaces.extensions.validator.core.storage.DefaultGroupStorage
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Should org.apache.myfaces.extensions.validator.core.storage.DefaultGroupStorage.getGroups(String, String) return a zero length array rather than null? | STYLE | PZLA_PREFER_ZERO_LENGTH_ARRAYS | 59 | Low |
org.apache.myfaces.extensions.validator.core.validation.message.resolver.AbstractValidationErrorMessageResolver
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Incorrect lazy initialization of static field org.apache.myfaces.extensions.validator.core.validation.message.resolver.AbstractValidationErrorMessageResolver.defaultBundle in org.apache.myfaces.extensions.validator.core.validation.message.resolver.AbstractValidationErrorMessageResolver.tryToUseMessageBundleConvention(String, Locale) | MT_CORRECTNESS | LI_LAZY_INIT_STATIC | 169-173 | Low |
org.apache.myfaces.extensions.validator.core.validation.parameter.DefaultValidationParameterExtractor
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Exception is caught when Exception is not thrown in org.apache.myfaces.extensions.validator.core.validation.parameter.DefaultValidationParameterExtractor.processFoundMethod(Class, Method, List, Object, Class) | STYLE | REC_CATCH_EXCEPTION | 317 | Low |
org.apache.myfaces.extensions.validator.core.validation.parameter.DefaultValidationParameterExtractorFactory
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Incorrect lazy initialization of static field org.apache.myfaces.extensions.validator.core.validation.parameter.DefaultValidationParameterExtractorFactory.validationParameterExtractor in org.apache.myfaces.extensions.validator.core.validation.parameter.DefaultValidationParameterExtractorFactory.create() | MT_CORRECTNESS | LI_LAZY_INIT_STATIC | 49-62 | Low |
org.apache.myfaces.extensions.validator.core.validation.strategy.DefaultValidationStrategyFactory
| Bug | Category | Details | Line | Priority |
|---|
org.apache.myfaces.extensions.validator.util.ClassUtils
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Exception is caught when Exception is not thrown in org.apache.myfaces.extensions.validator.util.ClassUtils.tryToInstantiateClass(Class) | STYLE | REC_CATCH_EXCEPTION | 73 | Low |
| Exception is caught when Exception is not thrown in org.apache.myfaces.extensions.validator.util.ClassUtils.tryToInstantiateClassForName(String) | STYLE | REC_CATCH_EXCEPTION | 86 | Low |
org.apache.myfaces.extensions.validator.util.ExtValAnnotationUtils
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Exception is caught when Exception is not thrown in org.apache.myfaces.extensions.validator.util.ExtValAnnotationUtils.extractValueOf(Annotation, Class) | STYLE | REC_CATCH_EXCEPTION | 179 | Low |
org.apache.myfaces.extensions.validator.util.NullValueAwareConcurrentHashMap
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.myfaces.extensions.validator.util.NullValueAwareConcurrentHashMap$DefaultNullMarker stored into non-transient field NullValueAwareConcurrentHashMap.nullMarkerValue | BAD_PRACTICE | SE_BAD_FIELD_STORE | 43 | Medium |
org.apache.myfaces.extensions.validator.util.ReflectionUtils
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Use of non-localized String.toUpperCase() or String.toLowerCase | I18N | DM_CONVERT_CASE | 198 | Low |
| Use of non-localized String.toUpperCase() or String.toLowerCase | I18N | DM_CONVERT_CASE | 265 | Low |
| Use of non-localized String.toUpperCase() or String.toLowerCase | I18N | DM_CONVERT_CASE | 340 | Low |
| org.apache.myfaces.extensions.validator.util.ReflectionUtils.invokeMethod(Object, Method, Object[]) invokes reflect.Method.setAccessible(boolean), which should be invoked from within a doPrivileged block | BAD_PRACTICE | DP_DO_INSIDE_DO_PRIVILEGED | 175 | Low |
| Exception is caught when Exception is not thrown in org.apache.myfaces.extensions.validator.util.ReflectionUtils.tryToGetFieldOfProperty(PropertyStorage, Class, String) | STYLE | REC_CATCH_EXCEPTION | 250 | Low |
| Exception is caught when Exception is not thrown in org.apache.myfaces.extensions.validator.util.ReflectionUtils.tryToInvokeMethod(Object, Method, Object[]) | STYLE | REC_CATCH_EXCEPTION | 159 | Low |
| Exception is caught when Exception is not thrown in org.apache.myfaces.extensions.validator.util.ReflectionUtils.tryToInvokeMethodOfClass(Class, Method, Object[]) | STYLE | REC_CATCH_EXCEPTION | 134 | Low |