Apache MyFaces
Foundation

FindBugs Bug Detector Report

The following document contains the results of FindBugs Report

FindBugs Version is 1.3.9

Threshold is low

Effort is min

Summary

ClassesBugsErrorsMissing Classes
2233600

Files

ClassBugs
org.apache.myfaces.extensions.validator.core.ExtValContext1
org.apache.myfaces.extensions.validator.core.ExtValContext$11
org.apache.myfaces.extensions.validator.core.ExtValContextInvocationOrderAwareInternals1
org.apache.myfaces.extensions.validator.core.InformationProviderBean1
org.apache.myfaces.extensions.validator.core.el.DefaultELHelper3
org.apache.myfaces.extensions.validator.core.el.FaceletsTaglibExpressionHelper3
org.apache.myfaces.extensions.validator.core.factory.AbstractNameMapperAwareFactory1
org.apache.myfaces.extensions.validator.core.initializer.configuration.StaticResourceBundleConfiguration1
org.apache.myfaces.extensions.validator.core.metadata.extractor.DefaultComponentMetaDataExtractorFactory1
org.apache.myfaces.extensions.validator.core.metadata.transformer.SortedNameMapperList3
org.apache.myfaces.extensions.validator.core.renderkit.DefaultRenderKitWrapperFactory1
org.apache.myfaces.extensions.validator.core.renderkit.ExtValLazyRendererProxy1
org.apache.myfaces.extensions.validator.core.renderkit.ExtValRenderKitFactory1
org.apache.myfaces.extensions.validator.core.storage.DefaultGroupStorage1
org.apache.myfaces.extensions.validator.core.validation.message.resolver.AbstractValidationErrorMessageResolver2
org.apache.myfaces.extensions.validator.core.validation.parameter.DefaultValidationParameterExtractor1
org.apache.myfaces.extensions.validator.core.validation.parameter.DefaultValidationParameterExtractorFactory1
org.apache.myfaces.extensions.validator.core.validation.strategy.DefaultValidationStrategyFactory1
org.apache.myfaces.extensions.validator.util.ClassUtils2
org.apache.myfaces.extensions.validator.util.ExtValAnnotationUtils1
org.apache.myfaces.extensions.validator.util.NullValueAwareConcurrentHashMap1
org.apache.myfaces.extensions.validator.util.ReflectionUtils7

org.apache.myfaces.extensions.validator.core.ExtValContext

BugCategoryDetailsLinePriority
Incorrect lazy initialization of static field org.apache.myfaces.extensions.validator.core.ExtValContext.extValContext in org.apache.myfaces.extensions.validator.core.ExtValContext.getContext()MT_CORRECTNESSLI_LAZY_INIT_STATIC144-146Medium

org.apache.myfaces.extensions.validator.core.ExtValContext$1

BugCategoryDetailsLinePriority
The class org.apache.myfaces.extensions.validator.core.ExtValContext$1 could be refactored into a named _static_ inner classPERFORMANCESIC_INNER_SHOULD_BE_STATIC_ANON235-239Low

org.apache.myfaces.extensions.validator.core.ExtValContextInvocationOrderAwareInternals

BugCategoryDetailsLinePriority
Unchecked/unconfirmed cast from org.apache.myfaces.extensions.validator.core.interceptor.PropertyValidationInterceptor to org.apache.myfaces.extensions.validator.core.ValidationModuleAware in org.apache.myfaces.extensions.validator.core.ExtValContextInvocationOrderAwareInternals.addPropertyValidationInterceptorForModules(PropertyValidationInterceptor)STYLEBC_UNCONFIRMED_CAST127Low

org.apache.myfaces.extensions.validator.core.InformationProviderBean

BugCategoryDetailsLinePriority
Method org.apache.myfaces.extensions.validator.core.InformationProviderBean.get(CustomInformation) uses the same code for two switch clausesSTYLEDB_DUPLICATE_SWITCH_CLAUSES148Low

org.apache.myfaces.extensions.validator.core.el.DefaultELHelper

BugCategoryDetailsLinePriority
Use of non-localized String.toUpperCase() or String.toLowerCaseI18NDM_CONVERT_CASE194Low
Method call in org.apache.myfaces.extensions.validator.core.el.DefaultELHelper.extractPropertyNameOfPropertyPath(String) passes null for nonnull parameter of org.apache.myfaces.extensions.validator.util.ReflectionUtils.tryToInvokeMethod(Object, Method)CORRECTNESSNP_NULL_PARAM_DEREF207Medium
Redundant nullcheck of result, which is known to be non-null in org.apache.myfaces.extensions.validator.core.el.DefaultELHelper.getValueBindingExpression(UIComponent, boolean)STYLERCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE110Low

org.apache.myfaces.extensions.validator.core.el.FaceletsTaglibExpressionHelper

BugCategoryDetailsLinePriority
Exception is caught when Exception is not thrown in org.apache.myfaces.extensions.validator.core.el.FaceletsTaglibExpressionHelper.tryToCreateValueBindingForFaceletsBinding(UIComponent)STYLEREC_CATCH_EXCEPTION73Low
Method org.apache.myfaces.extensions.validator.core.el.FaceletsTaglibExpressionHelper.addFurtherBindingParts(String, String[], int) concatenates strings using + in a loopPERFORMANCESBSC_USE_STRINGBUFFER_CONCATENATION201Medium
Method org.apache.myfaces.extensions.validator.core.el.FaceletsTaglibExpressionHelper.tryToTransformToRealBinding(String, Map, Map) makes inefficient use of keySet iterator instead of entrySet iteratorPERFORMANCEWMI_WRONG_MAP_ITERATOR153Medium

org.apache.myfaces.extensions.validator.core.factory.AbstractNameMapperAwareFactory

BugCategoryDetailsLinePriority

org.apache.myfaces.extensions.validator.core.initializer.configuration.StaticResourceBundleConfiguration

BugCategoryDetailsLinePriority
StaticResourceBundleConfiguration.mappings not initialized in constructorSTYLEUWF_FIELD_NOT_INITIALIZED_IN_CONSTRUCTORNot availableLow

org.apache.myfaces.extensions.validator.core.metadata.extractor.DefaultComponentMetaDataExtractorFactory

BugCategoryDetailsLinePriority
Incorrect lazy initialization of static field org.apache.myfaces.extensions.validator.core.metadata.extractor.DefaultComponentMetaDataExtractorFactory.metaDataExtractor in org.apache.myfaces.extensions.validator.core.metadata.extractor.DefaultComponentMetaDataExtractorFactory.createWith(Map)MT_CORRECTNESSLI_LAZY_INIT_STATIC70-82Low

org.apache.myfaces.extensions.validator.core.metadata.transformer.SortedNameMapperList

BugCategoryDetailsLinePriority
org.apache.myfaces.extensions.validator.core.metadata.transformer.SortedNameMapperList doesn't override java.util.concurrent.CopyOnWriteArrayList.equals(Object)STYLEEQ_DOESNT_OVERRIDE_EQUALS41-224Medium
Class org.apache.myfaces.extensions.validator.core.metadata.transformer.SortedNameMapperList defines non-transient non-serializable instance field globalSubNameMapperListBAD_PRACTICESE_BAD_FIELDNot availableLow
Class org.apache.myfaces.extensions.validator.core.metadata.transformer.SortedNameMapperList defines non-transient non-serializable instance field wrappedBAD_PRACTICESE_BAD_FIELDNot availableLow

org.apache.myfaces.extensions.validator.core.renderkit.DefaultRenderKitWrapperFactory

BugCategoryDetailsLinePriority
Incorrect lazy initialization of static field org.apache.myfaces.extensions.validator.core.renderkit.DefaultRenderKitWrapperFactory.useGenericRenderKitWrapperFactory in org.apache.myfaces.extensions.validator.core.renderkit.DefaultRenderKitWrapperFactory.createWrapper(RenderKit)MT_CORRECTNESSLI_LAZY_INIT_STATIC44-47Low

org.apache.myfaces.extensions.validator.core.renderkit.ExtValLazyRendererProxy

BugCategoryDetailsLinePriority
Exception is caught when Exception is not thrown in org.apache.myfaces.extensions.validator.core.renderkit.ExtValLazyRendererProxy.getLazyRenderer()STYLEREC_CATCH_EXCEPTION141Low

org.apache.myfaces.extensions.validator.core.renderkit.ExtValRenderKitFactory

BugCategoryDetailsLinePriority
Inconsistent synchronization of org.apache.myfaces.extensions.validator.core.renderkit.ExtValRenderKitFactory.defaultRenderKitWrapperFactory; locked 50% of timeMT_CORRECTNESSIS2_INCONSISTENT_SYNC82Medium

org.apache.myfaces.extensions.validator.core.storage.DefaultGroupStorage

BugCategoryDetailsLinePriority
Should org.apache.myfaces.extensions.validator.core.storage.DefaultGroupStorage.getGroups(String, String) return a zero length array rather than null?STYLEPZLA_PREFER_ZERO_LENGTH_ARRAYS60Low

org.apache.myfaces.extensions.validator.core.validation.message.resolver.AbstractValidationErrorMessageResolver

BugCategoryDetailsLinePriority
Incorrect lazy initialization of static field org.apache.myfaces.extensions.validator.core.validation.message.resolver.AbstractValidationErrorMessageResolver.defaultBundle in org.apache.myfaces.extensions.validator.core.validation.message.resolver.AbstractValidationErrorMessageResolver.tryToUseMessageBundleConvention(String, Locale)MT_CORRECTNESSLI_LAZY_INIT_STATIC170-174Low

org.apache.myfaces.extensions.validator.core.validation.parameter.DefaultValidationParameterExtractor

BugCategoryDetailsLinePriority
Exception is caught when Exception is not thrown in org.apache.myfaces.extensions.validator.core.validation.parameter.DefaultValidationParameterExtractor.processFoundMethod(Class, Method, List, Object, Class)STYLEREC_CATCH_EXCEPTION318Low

org.apache.myfaces.extensions.validator.core.validation.parameter.DefaultValidationParameterExtractorFactory

BugCategoryDetailsLinePriority
Incorrect lazy initialization of static field org.apache.myfaces.extensions.validator.core.validation.parameter.DefaultValidationParameterExtractorFactory.validationParameterExtractor in org.apache.myfaces.extensions.validator.core.validation.parameter.DefaultValidationParameterExtractorFactory.create()MT_CORRECTNESSLI_LAZY_INIT_STATIC50-63Low

org.apache.myfaces.extensions.validator.core.validation.strategy.DefaultValidationStrategyFactory

BugCategoryDetailsLinePriority

org.apache.myfaces.extensions.validator.util.ClassUtils

BugCategoryDetailsLinePriority
Exception is caught when Exception is not thrown in org.apache.myfaces.extensions.validator.util.ClassUtils.tryToInstantiateClass(Class)STYLEREC_CATCH_EXCEPTION74Low
Exception is caught when Exception is not thrown in org.apache.myfaces.extensions.validator.util.ClassUtils.tryToInstantiateClassForName(String)STYLEREC_CATCH_EXCEPTION87Low

org.apache.myfaces.extensions.validator.util.ExtValAnnotationUtils

BugCategoryDetailsLinePriority
Exception is caught when Exception is not thrown in org.apache.myfaces.extensions.validator.util.ExtValAnnotationUtils.extractValueOf(Annotation, Class)STYLEREC_CATCH_EXCEPTION180Low

org.apache.myfaces.extensions.validator.util.NullValueAwareConcurrentHashMap

BugCategoryDetailsLinePriority
org.apache.myfaces.extensions.validator.util.NullValueAwareConcurrentHashMap$DefaultNullMarker stored into non-transient field NullValueAwareConcurrentHashMap.nullMarkerValueBAD_PRACTICESE_BAD_FIELD_STORE44Medium

org.apache.myfaces.extensions.validator.util.ReflectionUtils

BugCategoryDetailsLinePriority
Use of non-localized String.toUpperCase() or String.toLowerCaseI18NDM_CONVERT_CASE199Low
Use of non-localized String.toUpperCase() or String.toLowerCaseI18NDM_CONVERT_CASE266Low
Use of non-localized String.toUpperCase() or String.toLowerCaseI18NDM_CONVERT_CASE341Low
org.apache.myfaces.extensions.validator.util.ReflectionUtils.invokeMethod(Object, Method, Object[]) invokes reflect.Method.setAccessible(boolean), which should be invoked from within a doPrivileged blockBAD_PRACTICEDP_DO_INSIDE_DO_PRIVILEGED176Low
Exception is caught when Exception is not thrown in org.apache.myfaces.extensions.validator.util.ReflectionUtils.tryToGetFieldOfProperty(PropertyStorage, Class, String)STYLEREC_CATCH_EXCEPTION251Low
Exception is caught when Exception is not thrown in org.apache.myfaces.extensions.validator.util.ReflectionUtils.tryToInvokeMethod(Object, Method, Object[])STYLEREC_CATCH_EXCEPTION160Low
Exception is caught when Exception is not thrown in org.apache.myfaces.extensions.validator.util.ReflectionUtils.tryToInvokeMethodOfClass(Class, Method, Object[])STYLEREC_CATCH_EXCEPTION135Low