FindBugs Bug Detector Report
The following document contains the results of FindBugs
FindBugs Version is 3.0.1
Threshold is medium
Effort is min
Files
org.apache.maven.shared.utils.Expand
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Exceptional return value of java.io.File.mkdirs() ignored in org.apache.maven.shared.utils.Expand.extractFile(File, File, InputStream, String, Date, boolean) | BAD_PRACTICE | RV_RETURN_VALUE_IGNORED_BAD_PRACTICE | 186 | Medium |
| Exceptional return value of java.io.File.setLastModified(long) ignored in org.apache.maven.shared.utils.Expand.extractFile(File, File, InputStream, String, Date, boolean) | BAD_PRACTICE | RV_RETURN_VALUE_IGNORED_BAD_PRACTICE | 209 | Medium |
org.apache.maven.shared.utils.ReaderFactory
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Found reliance on default encoding in org.apache.maven.shared.utils.ReaderFactory.newPlatformReader(File): new java.io.FileReader(File) | I18N | DM_DEFAULT_ENCODING | 154 | High |
org.apache.maven.shared.utils.WriterFactory
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Found reliance on default encoding in org.apache.maven.shared.utils.WriterFactory.newPlatformWriter(File): new java.io.FileWriter(File) | I18N | DM_DEFAULT_ENCODING | 146 | High |
| Found reliance on default encoding in org.apache.maven.shared.utils.WriterFactory.newPlatformWriter(OutputStream): new java.io.OutputStreamWriter(OutputStream) | I18N | DM_DEFAULT_ENCODING | 132 | High |
org.apache.maven.shared.utils.cli.Commandline
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.maven.shared.utils.cli.Commandline.getEnvironmentVariables() makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 256 | Medium |
org.apache.maven.shared.utils.cli.StreamFeeder
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Naked notify in org.apache.maven.shared.utils.cli.StreamFeeder.run() | MT_CORRECTNESS | NN_NAKED_NOTIFY | 77 | Medium |
org.apache.maven.shared.utils.cli.StreamPumper
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Found reliance on default encoding in new org.apache.maven.shared.utils.cli.StreamPumper(InputStream, StreamConsumer): new java.io.InputStreamReader(InputStream) | I18N | DM_DEFAULT_ENCODING | 53 | High |
| Found reliance on default encoding in new org.apache.maven.shared.utils.cli.StreamPumper(InputStream, StreamConsumer, Charset): new java.io.InputStreamReader(InputStream) | I18N | DM_DEFAULT_ENCODING | 63 | High |
org.apache.maven.shared.utils.io.DirectoryScanResult
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.maven.shared.utils.io.DirectoryScanResult.getFilesAdded() may expose internal representation by returning DirectoryScanResult.filesAdded | MALICIOUS_CODE | EI_EXPOSE_REP | 48 | Medium |
| org.apache.maven.shared.utils.io.DirectoryScanResult.getFilesRemoved() may expose internal representation by returning DirectoryScanResult.filesRemoved | MALICIOUS_CODE | EI_EXPOSE_REP | 56 | Medium |
| new org.apache.maven.shared.utils.io.DirectoryScanResult(String[], String[]) may expose internal representation by storing an externally mutable object into DirectoryScanResult.filesAdded | MALICIOUS_CODE | EI_EXPOSE_REP2 | 39 | Medium |
| new org.apache.maven.shared.utils.io.DirectoryScanResult(String[], String[]) may expose internal representation by storing an externally mutable object into DirectoryScanResult.filesRemoved | MALICIOUS_CODE | EI_EXPOSE_REP2 | 40 | Medium |
org.apache.maven.shared.utils.io.DirectoryScanner
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.maven.shared.utils.io.DirectoryScanner.DEFAULTEXCLUDES should be package protected | MALICIOUS_CODE | MS_PKGPROTECT | 118 | Medium |
org.apache.maven.shared.utils.io.FileUtils
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Found reliance on default encoding in org.apache.maven.shared.utils.io.FileUtils.copyFile(File, File, String, FileUtils$FilterWrapper[], boolean): new java.io.FileReader(File) | I18N | DM_DEFAULT_ENCODING | 1932 | High |
| Found reliance on default encoding in org.apache.maven.shared.utils.io.FileUtils.copyFile(File, File, String, FileUtils$FilterWrapper[], boolean): new java.io.FileWriter(File) | I18N | DM_DEFAULT_ENCODING | 1933 | High |
| Found reliance on default encoding in org.apache.maven.shared.utils.io.FileUtils.fileAppend(String, String, String): String.getBytes() | I18N | DM_DEFAULT_ENCODING | 358 | High |
| Found reliance on default encoding in org.apache.maven.shared.utils.io.FileUtils.fileRead(File, String): new java.io.InputStreamReader(InputStream) | I18N | DM_DEFAULT_ENCODING | 290 | High |
| Found reliance on default encoding in org.apache.maven.shared.utils.io.FileUtils.fileWrite(File, String, String): new java.io.OutputStreamWriter(OutputStream) | I18N | DM_DEFAULT_ENCODING | 418 | High |
| Found reliance on default encoding in org.apache.maven.shared.utils.io.FileUtils.fileWriteArray(File, String, String[]): new java.io.OutputStreamWriter(OutputStream) | I18N | DM_DEFAULT_ENCODING | 464 | High |
| Found reliance on default encoding in org.apache.maven.shared.utils.io.FileUtils.loadFile(File): new java.io.FileReader(File) | I18N | DM_DEFAULT_ENCODING | 1984 | High |
| org.apache.maven.shared.utils.io.FileUtils.normalize(String) may return null, but is declared @Nonnull | CORRECTNESS | NP_NONNULL_RETURN_VIOLATION | 1056 | High |
| Exceptional return value of java.io.File.mkdirs() ignored in org.apache.maven.shared.utils.io.FileUtils.copyStreamToFile(InputStream, File) | BAD_PRACTICE | RV_RETURN_VALUE_IGNORED_BAD_PRACTICE | 979 | Medium |
| Exceptional return value of java.io.File.mkdirs() ignored in org.apache.maven.shared.utils.io.FileUtils.mkdir(String) | BAD_PRACTICE | RV_RETURN_VALUE_IGNORED_BAD_PRACTICE | 615 | Medium |
| Exceptional return value of java.io.File.mkdirs() ignored in org.apache.maven.shared.utils.io.FileUtils.mkdirsFor(File) | BAD_PRACTICE | RV_RETURN_VALUE_IGNORED_BAD_PRACTICE | 862 | Medium |
org.apache.maven.shared.utils.io.IOUtil
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Found reliance on default encoding in org.apache.maven.shared.utils.io.IOUtil.copy(InputStream, Writer, int): new java.io.InputStreamReader(InputStream) | I18N | DM_DEFAULT_ENCODING | 233 | High |
| Found reliance on default encoding in org.apache.maven.shared.utils.io.IOUtil.copy(Reader, OutputStream, int): new java.io.OutputStreamWriter(OutputStream) | I18N | DM_DEFAULT_ENCODING | 409 | High |
| Found reliance on default encoding in org.apache.maven.shared.utils.io.IOUtil.copy(String, OutputStream, int): new java.io.OutputStreamWriter(OutputStream) | I18N | DM_DEFAULT_ENCODING | 512 | High |
org.apache.maven.shared.utils.io.MatchPattern
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.maven.shared.utils.io.MatchPattern.getTokenizedPathString() may expose internal representation by returning MatchPattern.tokenized | MALICIOUS_CODE | EI_EXPOSE_REP | 119 | Medium |
org.apache.maven.shared.utils.io.WalkCollector
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unread field: org.apache.maven.shared.utils.io.WalkCollector.startingDir | PERFORMANCE | URF_UNREAD_FIELD | 65 | Medium |
org.apache.maven.shared.utils.xml.XmlStreamWriter
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| The class name org.apache.maven.shared.utils.xml.XmlStreamWriter shadows the simple name of the superclass org.apache.commons.io.output.XmlStreamWriter | BAD_PRACTICE | NM_SAME_SIMPLE_NAME_AS_SUPERCLASS | 38-49 | High |