The following document contains the results of FindBugs Report
FindBugs Version is 2.0.1
Threshold is medium
Effort is min
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
exceptional return value of java.io.File.delete() ignored in org.apache.maven.shared.utils.Expand.deleteFileOrDir(File) | BAD_PRACTICE | RV_RETURN_VALUE_IGNORED_BAD_PRACTICE | 229 | Medium |
exceptional return value of java.io.File.mkdirs() ignored in org.apache.maven.shared.utils.Expand.extractFile(File, File, InputStream, String, Date, boolean) | BAD_PRACTICE | RV_RETURN_VALUE_IGNORED_BAD_PRACTICE | 184 | Medium |
exceptional return value of java.io.File.setLastModified(long) ignored in org.apache.maven.shared.utils.Expand.extractFile(File, File, InputStream, String, Date, boolean) | BAD_PRACTICE | RV_RETURN_VALUE_IGNORED_BAD_PRACTICE | 209 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Found reliance on default encoding in org.apache.maven.shared.utils.ReaderFactory.newPlatformReader(File): new java.io.FileReader(File) | I18N | DM_DEFAULT_ENCODING | 156 | High |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Found reliance on default encoding in org.apache.maven.shared.utils.WriterFactory.newPlatformWriter(File): new java.io.FileWriter(File) | I18N | DM_DEFAULT_ENCODING | 147 | High |
Found reliance on default encoding in org.apache.maven.shared.utils.WriterFactory.newPlatformWriter(OutputStream): new java.io.OutputStreamWriter(OutputStream) | I18N | DM_DEFAULT_ENCODING | 133 | High |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
org.apache.maven.shared.utils.cli.CommandLineUtils$1.call() explicitly invokes run on a thread (did you mean to start it instead?) | MT_CORRECTNESS | RU_INVOKE_RUN | 257 | High |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Found reliance on default encoding in new org.apache.maven.shared.utils.cli.StreamPumper(InputStream, PrintWriter, StreamConsumer): new java.io.InputStreamReader(InputStream) | I18N | DM_DEFAULT_ENCODING | 57 | High |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Switch statement found in org.apache.maven.shared.utils.introspection.MethodMap.getMostSpecific(List, Class[]) where default case is missing | STYLE | SF_SWITCH_NO_DEFAULT | 181-203 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
org.apache.maven.shared.utils.io.DirectoryScanResult.getFilesAdded() may expose internal representation by returning DirectoryScanResult.filesAdded | MALICIOUS_CODE | EI_EXPOSE_REP | 44 | Medium |
org.apache.maven.shared.utils.io.DirectoryScanResult.getFilesRemoved() may expose internal representation by returning DirectoryScanResult.filesRemoved | MALICIOUS_CODE | EI_EXPOSE_REP | 52 | Medium |
new org.apache.maven.shared.utils.io.DirectoryScanResult(String[], String[]) may expose internal representation by storing an externally mutable object into DirectoryScanResult.filesAdded | MALICIOUS_CODE | EI_EXPOSE_REP2 | 35 | Medium |
new org.apache.maven.shared.utils.io.DirectoryScanResult(String[], String[]) may expose internal representation by storing an externally mutable object into DirectoryScanResult.filesRemoved | MALICIOUS_CODE | EI_EXPOSE_REP2 | 36 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
org.apache.maven.shared.utils.io.DirectoryScanner.DEFAULTEXCLUDES should be package protected | MALICIOUS_CODE | MS_PKGPROTECT | 118 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Found reliance on default encoding in org.apache.maven.shared.utils.io.FileUtils.copyFile(File, File, String, FileUtils$FilterWrapper[], boolean): new java.io.FileReader(File) | I18N | DM_DEFAULT_ENCODING | 1836 | High |
Found reliance on default encoding in org.apache.maven.shared.utils.io.FileUtils.copyFile(File, File, String, FileUtils$FilterWrapper[], boolean): new java.io.FileWriter(File) | I18N | DM_DEFAULT_ENCODING | 1837 | High |
Found reliance on default encoding in org.apache.maven.shared.utils.io.FileUtils.fileAppend(String, String, String): String.getBytes() | I18N | DM_DEFAULT_ENCODING | 353 | High |
Found reliance on default encoding in org.apache.maven.shared.utils.io.FileUtils.fileRead(File, String): new java.io.InputStreamReader(InputStream) | I18N | DM_DEFAULT_ENCODING | 287 | High |
Found reliance on default encoding in org.apache.maven.shared.utils.io.FileUtils.fileWrite(File, String, String): new java.io.OutputStreamWriter(OutputStream) | I18N | DM_DEFAULT_ENCODING | 413 | High |
Found reliance on default encoding in org.apache.maven.shared.utils.io.FileUtils.fileWriteArray(File, String, String[]): new java.io.OutputStreamWriter(OutputStream) | I18N | DM_DEFAULT_ENCODING | 460 | High |
Found reliance on default encoding in org.apache.maven.shared.utils.io.FileUtils.loadFile(File): new java.io.FileReader(File) | I18N | DM_DEFAULT_ENCODING | 1887 | High |
org.apache.maven.shared.utils.io.FileUtils.deleteFile(File) forces garbage collection; extremely dubious except in benchmarking code | PERFORMANCE | DM_GC | 1176 | High |
exceptional return value of java.io.File.mkdirs() ignored in org.apache.maven.shared.utils.io.FileUtils.copyStreamToFile(InputStream, File) | BAD_PRACTICE | RV_RETURN_VALUE_IGNORED_BAD_PRACTICE | 951 | Medium |
exceptional return value of java.io.File.delete() ignored in org.apache.maven.shared.utils.io.FileUtils.fileDelete(String) | BAD_PRACTICE | RV_RETURN_VALUE_IGNORED_BAD_PRACTICE | 487 | Medium |
exceptional return value of java.io.File.mkdirs() ignored in org.apache.maven.shared.utils.io.FileUtils.mkdir(String) | BAD_PRACTICE | RV_RETURN_VALUE_IGNORED_BAD_PRACTICE | 608 | Medium |
exceptional return value of java.io.File.mkdirs() ignored in org.apache.maven.shared.utils.io.FileUtils.mkdirsFor(File) | BAD_PRACTICE | RV_RETURN_VALUE_IGNORED_BAD_PRACTICE | 844 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Found reliance on default encoding in org.apache.maven.shared.utils.io.IOUtil.copy(InputStream, Writer, int): new java.io.InputStreamReader(InputStream) | I18N | DM_DEFAULT_ENCODING | 217 | High |
Found reliance on default encoding in org.apache.maven.shared.utils.io.IOUtil.copy(Reader, OutputStream, int): new java.io.OutputStreamWriter(OutputStream) | I18N | DM_DEFAULT_ENCODING | 360 | High |
Found reliance on default encoding in org.apache.maven.shared.utils.io.IOUtil.copy(String, OutputStream, int): new java.io.OutputStreamWriter(OutputStream) | I18N | DM_DEFAULT_ENCODING | 445 | High |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
org.apache.maven.shared.utils.io.MatchPattern.getTokenizedPathString() may expose internal representation by returning MatchPattern.tokenized | MALICIOUS_CODE | EI_EXPOSE_REP | 104 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Unread field: org.apache.maven.shared.utils.io.WalkCollector.startingDir | PERFORMANCE | URF_UNREAD_FIELD | 57 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
The class name org.apache.maven.shared.utils.xml.XmlStreamWriter shadows the simple name of the superclass org.apache.commons.io.output.XmlStreamWriter | BAD_PRACTICE | NM_SAME_SIMPLE_NAME_AS_SUPERCLASS | 35-42 | High |