FindBugs Bug Detector Report

The following document contains the results of FindBugs

FindBugs Version is 3.0.1

Threshold is medium

Effort is min

Summary

Classes Bugs Errors Missing Classes
37 11 0 0

Files

Class Bugs
org.apache.maven.scm.provider.hg.HgConfig 1
org.apache.maven.scm.provider.hg.HgScmProvider 2
org.apache.maven.scm.provider.hg.HgUtils$HgRevNoConsumer 1
org.apache.maven.scm.provider.hg.command.HgConsumer 1
org.apache.maven.scm.provider.hg.command.add.HgAddCommand 1
org.apache.maven.scm.provider.hg.command.changelog.HgChangeLogConsumer 2
org.apache.maven.scm.provider.hg.command.diff.HgDiffConsumer 1
org.apache.maven.scm.provider.hg.command.inventory.HgChangeSet 1
org.apache.maven.scm.provider.hg.command.update.HgUpdateCommand 1

org.apache.maven.scm.provider.hg.HgConfig

Bug Category Details Line Priority
org.apache.maven.scm.provider.hg.HgConfig.compareVersion(String, String) concatenates strings using + in a loop PERFORMANCE SBSC_USE_STRINGBUFFER_CONCATENATION 120 Medium

org.apache.maven.scm.provider.hg.HgScmProvider

Bug Category Details Line Priority
Dead store to e in org.apache.maven.scm.provider.hg.HgScmProvider.parseScmUrl(String) STYLE DLS_DEAD_LOCAL_STORE 142 High
Possible null pointer dereference of path in org.apache.maven.scm.provider.hg.HgScmProvider.makeProviderScmRepository(File) CORRECTNESS NP_NULL_ON_SOME_PATH 164 Medium

org.apache.maven.scm.provider.hg.HgUtils$HgRevNoConsumer

Bug Category Details Line Priority
Boxing/unboxing to parse a primitive org.apache.maven.scm.provider.hg.HgUtils$HgRevNoConsumer.doConsume(ScmFileStatus, String) PERFORMANCE DM_BOXED_PRIMITIVE_FOR_PARSING 252 High

org.apache.maven.scm.provider.hg.command.HgConsumer

Bug Category Details Line Priority
org.apache.maven.scm.provider.hg.command.HgConsumer.processInputForKnownMessages(String) makes inefficient use of keySet iterator instead of entrySet iterator PERFORMANCE WMI_WRONG_MAP_ITERATOR 176 Medium

org.apache.maven.scm.provider.hg.command.add.HgAddCommand

Bug Category Details Line Priority
Possible null pointer dereference in org.apache.maven.scm.provider.hg.command.add.HgAddCommand.executeAddCommand(ScmProviderRepository, ScmFileSet, String, boolean) due to return value of called method STYLE NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE 66 Medium

org.apache.maven.scm.provider.hg.command.changelog.HgChangeLogConsumer

Bug Category Details Line Priority
Unread field: org.apache.maven.scm.provider.hg.command.changelog.HgChangeLogConsumer.currentBranch PERFORMANCE URF_UNREAD_FIELD 116 Medium
Unread field: org.apache.maven.scm.provider.hg.command.changelog.HgChangeLogConsumer.currentTag PERFORMANCE URF_UNREAD_FIELD 132 Medium

org.apache.maven.scm.provider.hg.command.diff.HgDiffConsumer

Bug Category Details Line Priority
Unread field: org.apache.maven.scm.provider.hg.command.diff.HgDiffConsumer.workingDirectory PERFORMANCE URF_UNREAD_FIELD 84 Medium

org.apache.maven.scm.provider.hg.command.inventory.HgChangeSet

Bug Category Details Line Priority
org.apache.maven.scm.provider.hg.command.inventory.HgChangeSet doesn't override org.apache.maven.scm.ChangeSet.equals(Object) STYLE EQ_DOESNT_OVERRIDE_EQUALS 1 Medium

org.apache.maven.scm.provider.hg.command.update.HgUpdateCommand

Bug Category Details Line Priority
Useless object stored in variable changes of method org.apache.maven.scm.provider.hg.command.update.HgUpdateCommand.executeUpdateCommand(ScmProviderRepository, ScmFileSet, ScmVersion) STYLE UC_USELESS_OBJECT 96 Medium