FindBugs Bug Detector Report

The following document contains the results of FindBugs

FindBugs Version is 2.0.3

Threshold is medium

Effort is min

Summary

Classes Bugs Errors Missing Classes
101 31 0 0

Files

Class Bugs
org.apache.maven.plugin.assembly.archive.archiver.AssemblyProxyArchiver 2
org.apache.maven.plugin.assembly.archive.archiver.PrefixedArchivedFileSet 1
org.apache.maven.plugin.assembly.archive.phase.AssemblyArchiverPhaseComparator 2
org.apache.maven.plugin.assembly.archive.phase.RepositoryAssemblyPhase 1
org.apache.maven.plugin.assembly.archive.task.AddArtifactTask 1
org.apache.maven.plugin.assembly.filter.SimpleAggregatingDescriptorHandler 3
org.apache.maven.plugin.assembly.format.ReaderFormatter$1 1
org.apache.maven.plugin.assembly.format.ReflectionProperties 1
org.apache.maven.plugin.assembly.io.DefaultAssemblyReader 1
org.apache.maven.plugin.assembly.model.io.xpp3.AssemblyXpp3Reader 4
org.apache.maven.plugin.assembly.model.io.xpp3.ComponentXpp3Reader 4
org.apache.maven.plugin.assembly.mojos.AbstractAssemblyMojo 5
org.apache.maven.plugin.assembly.mojos.UnpackMojo 1
org.apache.maven.plugin.assembly.utils.AssemblyFileUtils 1
org.apache.maven.plugin.assembly.utils.LineEndingsUtils 2

org.apache.maven.plugin.assembly.archive.archiver.AssemblyProxyArchiver

Bug Category Details Line Priority
Possible null pointer dereference in org.apache.maven.plugin.assembly.archive.archiver.AssemblyProxyArchiver.doAddFileSet(FileSet) due to return value of called method STYLE NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE 717 Medium
Possible null pointer dereference in org.apache.maven.plugin.assembly.archive.archiver.AssemblyProxyArchiver.doAddFileSet(FileSet) due to return value of called method STYLE NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE 731 Medium

org.apache.maven.plugin.assembly.archive.archiver.PrefixedArchivedFileSet

Bug Category Details Line Priority
Possible null pointer dereference in org.apache.maven.plugin.assembly.archive.archiver.PrefixedArchivedFileSet.getPrefix() due to return value of called method STYLE NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE 101 Medium

org.apache.maven.plugin.assembly.archive.phase.AssemblyArchiverPhaseComparator

Bug Category Details Line Priority
org.apache.maven.plugin.assembly.archive.phase.AssemblyArchiverPhaseComparator.compare(AssemblyArchiverPhase, AssemblyArchiverPhase) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) instead PERFORMANCE DM_NUMBER_CTOR 46 Medium
org.apache.maven.plugin.assembly.archive.phase.AssemblyArchiverPhaseComparator implements Comparator but not Serializable BAD_PRACTICE SE_COMPARATOR_SHOULD_BE_SERIALIZABLE 27-46 Medium

org.apache.maven.plugin.assembly.archive.phase.RepositoryAssemblyPhase

Bug Category Details Line Priority
Exceptional return value of java.io.File.mkdirs() ignored in org.apache.maven.plugin.assembly.archive.phase.RepositoryAssemblyPhase.execute(Assembly, Archiver, AssemblerConfigurationSource) BAD_PRACTICE RV_RETURN_VALUE_IGNORED_BAD_PRACTICE 91 Medium

org.apache.maven.plugin.assembly.archive.task.AddArtifactTask

Bug Category Details Line Priority
org.apache.maven.plugin.assembly.archive.task.AddArtifactTask.DEFAULT_INCLUDES_ARRAY should be package protected MALICIOUS_CODE MS_PKGPROTECT 52 Medium

org.apache.maven.plugin.assembly.filter.SimpleAggregatingDescriptorHandler

Bug Category Details Line Priority
Found reliance on default encoding in org.apache.maven.plugin.assembly.filter.SimpleAggregatingDescriptorHandler.readProperties(FileInfo): new java.io.InputStreamReader(InputStream) I18N DM_DEFAULT_ENCODING 194 High
Found reliance on default encoding in org.apache.maven.plugin.assembly.filter.SimpleAggregatingDescriptorHandler.writePropertiesFile(): new java.io.OutputStreamWriter(OutputStream) I18N DM_DEFAULT_ENCODING 113 High
Unread field: org.apache.maven.plugin.assembly.filter.SimpleAggregatingDescriptorHandler.commentChars; should this field be static? PERFORMANCE SS_SHOULD_BE_STATIC 61 Medium

org.apache.maven.plugin.assembly.format.ReaderFormatter$1

Bug Category Details Line Priority
Found reliance on default encoding in org.apache.maven.plugin.assembly.format.ReaderFormatter$1.transform(PlexusIoResource, InputStream): new java.io.InputStreamReader(InputStream) I18N DM_DEFAULT_ENCODING 140 High

org.apache.maven.plugin.assembly.format.ReflectionProperties

Bug Category Details Line Priority
org.apache.maven.plugin.assembly.format.ReflectionProperties doesn't override java.util.Hashtable.equals(Object) STYLE EQ_DOESNT_OVERRIDE_EQUALS 736-765 Medium
Class org.apache.maven.plugin.assembly.format.ReflectionProperties defines non-transient non-serializable instance field project BAD_PRACTICE SE_BAD_FIELD Not available Medium

org.apache.maven.plugin.assembly.io.DefaultAssemblyReader

Bug Category Details Line Priority
Found reliance on default encoding in org.apache.maven.plugin.assembly.io.DefaultAssemblyReader.mergeComponentsWithMainAssembly(Assembly, File, AssemblerConfigurationSource, ComponentXpp3Reader$ContentTransformer): new java.io.InputStreamReader(InputStream) I18N DM_DEFAULT_ENCODING 455 High

org.apache.maven.plugin.assembly.model.io.xpp3.AssemblyXpp3Reader

Bug Category Details Line Priority
Boxing/unboxing to parse a primitive org.apache.maven.plugin.assembly.model.io.xpp3.AssemblyXpp3Reader.getIntegerValue(String, String, XmlPullParser, boolean) PERFORMANCE DM_BOXED_PRIMITIVE_FOR_PARSING 400 High
Boxing/unboxing to parse a primitive org.apache.maven.plugin.assembly.model.io.xpp3.AssemblyXpp3Reader.getLongValue(String, String, XmlPullParser, boolean) PERFORMANCE DM_BOXED_PRIMITIVE_FOR_PARSING 430 High
Private method org.apache.maven.plugin.assembly.model.io.xpp3.AssemblyXpp3Reader.getBooleanValue(String, String, XmlPullParser) is never called PERFORMANCE UPM_UNCALLED_PRIVATE_METHOD 185 Medium
Private method org.apache.maven.plugin.assembly.model.io.xpp3.AssemblyXpp3Reader.getDateValue(String, String, XmlPullParser) is never called PERFORMANCE UPM_UNCALLED_PRIVATE_METHOD 273 Medium

org.apache.maven.plugin.assembly.model.io.xpp3.ComponentXpp3Reader

Bug Category Details Line Priority
Boxing/unboxing to parse a primitive org.apache.maven.plugin.assembly.model.io.xpp3.ComponentXpp3Reader.getIntegerValue(String, String, XmlPullParser, boolean) PERFORMANCE DM_BOXED_PRIMITIVE_FOR_PARSING 400 High
Boxing/unboxing to parse a primitive org.apache.maven.plugin.assembly.model.io.xpp3.ComponentXpp3Reader.getLongValue(String, String, XmlPullParser, boolean) PERFORMANCE DM_BOXED_PRIMITIVE_FOR_PARSING 430 High
Private method org.apache.maven.plugin.assembly.model.io.xpp3.ComponentXpp3Reader.getBooleanValue(String, String, XmlPullParser) is never called PERFORMANCE UPM_UNCALLED_PRIVATE_METHOD 185 Medium
Private method org.apache.maven.plugin.assembly.model.io.xpp3.ComponentXpp3Reader.getDateValue(String, String, XmlPullParser) is never called PERFORMANCE UPM_UNCALLED_PRIVATE_METHOD 273 Medium

org.apache.maven.plugin.assembly.mojos.AbstractAssemblyMojo

Bug Category Details Line Priority
org.apache.maven.plugin.assembly.mojos.AbstractAssemblyMojo.getDescriptorReferences() may expose internal representation by returning AbstractAssemblyMojo.descriptorRefs MALICIOUS_CODE EI_EXPOSE_REP 670 Medium
org.apache.maven.plugin.assembly.mojos.AbstractAssemblyMojo.getDescriptors() may expose internal representation by returning AbstractAssemblyMojo.descriptors MALICIOUS_CODE EI_EXPOSE_REP 680 Medium
org.apache.maven.plugin.assembly.mojos.AbstractAssemblyMojo.setDescriptorRefs(String[]) may expose internal representation by storing an externally mutable object into AbstractAssemblyMojo.descriptorRefs MALICIOUS_CODE EI_EXPOSE_REP2 819 Medium
org.apache.maven.plugin.assembly.mojos.AbstractAssemblyMojo.setDescriptors(String[]) may expose internal representation by storing an externally mutable object into AbstractAssemblyMojo.descriptors MALICIOUS_CODE EI_EXPOSE_REP2 824 Medium
Unread field: org.apache.maven.plugin.assembly.mojos.AbstractAssemblyMojo.classifier PERFORMANCE URF_UNREAD_FIELD 792 Medium

org.apache.maven.plugin.assembly.mojos.UnpackMojo

Bug Category Details Line Priority
Exceptional return value of java.io.File.mkdirs() ignored in org.apache.maven.plugin.assembly.mojos.UnpackMojo.execute() BAD_PRACTICE RV_RETURN_VALUE_IGNORED_BAD_PRACTICE 98 Medium

org.apache.maven.plugin.assembly.utils.AssemblyFileUtils

Bug Category Details Line Priority
Exceptional return value of java.io.File.mkdirs() ignored in org.apache.maven.plugin.assembly.utils.AssemblyFileUtils.verifyTempDirectoryAvailability(File) BAD_PRACTICE RV_RETURN_VALUE_IGNORED_BAD_PRACTICE 89 Medium

org.apache.maven.plugin.assembly.utils.LineEndingsUtils

Bug Category Details Line Priority
Found reliance on default encoding in org.apache.maven.plugin.assembly.utils.LineEndingsUtils.convertLineEndings(File, File, LineEndings, Boolean, String): new java.io.InputStreamReader(InputStream) I18N DM_DEFAULT_ENCODING 115 High
Found reliance on default encoding in org.apache.maven.plugin.assembly.utils.LineEndingsUtils.convertLineEndings(File, File, LineEndings, Boolean, String): new java.io.OutputStreamWriter(OutputStream) I18N DM_DEFAULT_ENCODING 116 High