/[Apache-SVN]
ViewVC logotype

Revision 796805


Jump to revision: Previous Next
Author: kocolosk
Date: Wed Jul 22 17:34:14 2009 UTC (14 years, 9 months ago)
Changed paths: 2
Log Message:
various bugfixes and improvements for view compaction

View compaction was broken after the switch to signature-based index
files, but we don't have tests for it yet so we didn't notice.  I also
committed a few changes that should make compaction faster and more
robust:

* commit the header immediately after compaction finishes.  We used
  to wait 1 seconds, but if the server restarted in that second the
  index would be reset.

* unlink from old index file at the end. Prevents process crashes
  that could couch_view (and with the delayed commit would sometimes
  cause index resets).
  
* don't wait for running view updates to finish before replacing old
  view index file.  If an update is running, restart it and point it to
  the new view group.  This alleviates the situation where the view
  compaction goes into a busy wait, printing "still behind main file"
  1000s of times to the log, and generally makes compaction finish more
  quickly.
  
* better logging


Changed paths

Path Details
Directorycouchdb/trunk/src/couchdb/couch_view_group.erl modified , text changed
Directorycouchdb/trunk/src/couchdb/couch_view_updater.erl modified , text changed

infrastructure at apache.org
ViewVC Help
Powered by ViewVC 1.1.26