The following document contains the listing of user tags found in the code. Below is the summary of the occurrences per tag.
| Tag Class | Total number of occurrences | Tag strings used by tag class |
|---|---|---|
| @todo | 3 | @todo |
| TODO | 54 | TODO |
Each tag is detailed below:
Number of occurrences found in the code: 3
| org.apache.maven.continuum.execution.maven.m2.DefaultMavenBuilderHelper | Line |
|---|---|
| [BP] this might not be required if there is a better way to pass them in. It doesn't feel quite right. | 708 |
| [JC] we should at least provide a mapping of protocol-to-proxy for the wagons, shouldn't we? | 710 |
| org.apache.maven.continuum.initialization.DefaultContinuumInitializer | Line |
| use this, reintroduce default project group | 48 |
Number of occurrences found in the code: 54
| org.apache.continuum.buildmanager.ParallelBuildsManagerTest | Line |
|---|---|
| test scenario when there are no longer build queues configured aside from the one removed? - the behaviour should be that the default build queue will be used! | 667 |
| org.apache.maven.continuum.DefaultContinuum | Line |
| Remove this method | 531 |
| Remove this method | 540 |
| Remove this method | 761 |
| Remove this method | 787 |
| As all projects are built in the same queue for a project group, it would be better to get them by project group and add them in queues in parallel to save few seconds | 899 |
| Must be done by build definition | 1136 |
| Shouldn't be used now with the previous call of buildResultDao.getBuildResultsForProjectWithDetails | 1160 |
| Remove this method when it won't be used | 1222 |
| Validate all the projects before saving them ---------------------------------------------------------------------- | 1676 |
| Remove all projects from queues, stop scheduler and wait the end of current builds so build results will be ok | 2712 |
| org.apache.maven.continuum.buildcontroller.DefaultBuildController | Line |
| clean this up. We catch the original exception from the action, and then update the buildresult for it - we need to because of the specialized error message for SCM. If updating the buildresult fails, log the previous error and throw the new one. If updating the buildresult succeeds, throw the original exception. The build result should NOT be updated again - a TaskExecutionException is final, no further action should be taken upon it. | 419 |
| org.apache.maven.continuum.builddefinition.DefaultBuildDefinitionService | Line |
| in the same db transaction ? | 475 |
| org.apache.maven.continuum.core.action.AddAssignableRolesAction | Line |
| make the resource the name of the project group and hide the id from the user | 58 |
| org.apache.maven.continuum.core.action.CheckoutProjectContinuumAction | Line |
| is it more appropriate to return this in the converted result so that it can be presented to the user? | 126 |
| this is not making it back into a result of any kind - log it at least. Same is probably the case for ScmException | 156 |
| do we want this here, or should it be to the logs? | 177 |
| what throwables do we really get here that we can cope with? | 178 |
| migrate to the SvnCommandLineUtils version (preferably properly encapsulated in the provider) | 243 |
| org.apache.maven.continuum.core.action.CleanWorkingDirectoryAction | Line |
| this with a configuration option somewhere ? | 63 |
| org.apache.maven.continuum.core.action.ExecuteBuilderContinuumAction | Line |
| Move as a plugin | 208 |
| org.apache.maven.continuum.core.action.UpdateWorkingDirectoryFromScmContinuumAction | Line |
| not sure why this is different to the context, but it all needs to change | 119 |
| this is not making it back into a result of any kind - log it at least. Same is probably the case for ScmException | 158 |
| author, etc. | 281 |
| revision? | 288 |
| migrate to the SvnCommandLineUtils version (preferably properly encapsulated in the provider) | 298 |
| org.apache.maven.continuum.core.action.ValidateProject | Line |
| Enable assertStringNotEmpty( project.getPath(), "path" ); assertStringNotEmpty( project.getGroupId(), "group id" ); assertStringNotEmpty( project.getArtifactId(), "artifact id" ); | 89 |
| validate that the SCM provider id | 99 |
| org.apache.maven.continuum.core.action.ValidateProjectGroup | Line |
| assert that the name is unique | 40 |
| org.apache.maven.continuum.execution.ContinuumBuildExecutorTest | Line |
| Auto-generated method stub | 135 |
| Auto-generated method stub | 142 |
| Auto-generated method stub | 149 |
| org.apache.maven.continuum.execution.maven.m2.DefaultMavenBuilderHelper | Line |
| Remove this: scm url shouldn't be null there | 160 |
| This seems like code that is shared with DefaultMaven, so it should be moved to the project builder perhaps | 378 |
| catch all exceptions is bad | 446 |
| org.apache.maven.continuum.execution.maven.m2.MavenTwoBuildExecutor | Line |
| this is currently quite lame | 227 |
| org.apache.maven.continuum.execution.shell.ShellBuildExecutor | Line |
| this should be validated earlier? | 72 |
| org.apache.maven.continuum.notification.DefaultContinuumNotificationDispatcher | Line |
| remove re-reading? Here we need to get all the project details | 120 |
| org.apache.maven.continuum.notification.mail.FormatterTool | Line |
| Add i18n | 42 |
| fix this | 75 |
| org.apache.maven.continuum.notification.mail.MailContinuumNotifier | Line |
| Make the build host a part of the build | 361 |
| only in case of a java project ? | 379 |
| put other profile env var could be a security if they provide passwords ? | 391 |
| put other profile env var could be a security if they provide passwords ? | 458 |
| set a proper name | 710 |
| Add a default domain so mail address won't be required | 750 |
| set a proper name | 758 |
| use configuration file instead of to load it fron component configuration | 775 |
| set a proper name | 776 |
| set a proper name | 866 |
| use configuration file instead of to load it fron component configuration | 878 |
| set a proper name | 879 |
| org.apache.maven.continuum.project.builder.AbstractContinuumProjectBuilder | Line |
| put this values to a configuration way ??? | 84 |
| org.apache.maven.continuum.scm.queue.PrepareBuildProjectsTaskExecutor | Line |
| Centralize the error handling from the SCM related actions. ContinuumScmResult should return a ContinuumScmResult from all methods, even in a case of failure. ---------------------------------------------------------------------- | 143 |