Checkstyle Results
The following document contains the results of Checkstyle.
Files
Rules
Rules | Violations | Severity |
---|---|---|
JavadocPackage
| 0 | Error |
NewlineAtEndOfFile | 3 | Error |
Translation | 0 | Error |
FileLength | 0 | Error |
FileTabCharacter
| 0 | Error |
RegexpSingleline
| 11 | Error |
JavadocMethod | 70 | Error |
JavadocType | 3 | Error |
JavadocVariable | 30 | Error |
JavadocStyle | 3 | Error |
ConstantName | 8 | Error |
LocalFinalVariableName | 1 | Error |
LocalVariableName | 0 | Error |
MemberName | 0 | Error |
MethodName | 0 | Error |
PackageName | 0 | Error |
ParameterName | 0 | Error |
StaticVariableName | 0 | Error |
TypeName | 0 | Error |
AvoidStarImport | 0 | Error |
IllegalImport | 1 | Error |
RedundantImport | 0 | Error |
UnusedImports | 0 | Error |
LineLength | 63 | Error |
MethodLength | 0 | Error |
ParameterNumber | 0 | Error |
EmptyForIteratorPad | 0 | Error |
MethodParamPad | 0 | Error |
NoWhitespaceAfter | 1 | Error |
NoWhitespaceBefore | 0 | Error |
OperatorWrap | 5 | Error |
ParenPad | 13 | Error |
TypecastParenPad | 0 | Error |
WhitespaceAfter | 1 | Error |
WhitespaceAround | 12 | Error |
ModifierOrder | 3 | Error |
RedundantModifier | 0 | Error |
AvoidNestedBlocks | 0 | Error |
EmptyBlock | 1 | Error |
LeftCurly | 0 | Error |
NeedBraces | 18 | Error |
RightCurly | 0 | Error |
AvoidInlineConditionals | 4 | Error |
DoubleCheckedLocking | 0 | Error |
EmptyStatement | 0 | Error |
EqualsHashCode | 0 | Error |
HiddenField | 11 | Error |
IllegalInstantiation | 0 | Error |
InnerAssignment | 0 | Error |
MagicNumber | 24 | Error |
MissingSwitchDefault | 0 | Error |
RedundantThrows | 0 | Error |
SimplifyBooleanExpression | 0 | Error |
SimplifyBooleanReturn | 0 | Error |
DesignForExtension | 15 | Error |
FinalClass | 1 | Error |
HideUtilityClassConstructor | 1 | Error |
InterfaceIsType | 0 | Error |
VisibilityModifier | 0 | Error |
ArrayTypeStyle | 0 | Error |
FinalParameters | 92 | Error |
TodoComment | 0 | Error |
UpperEll | 0 | Error |
Details
org/apache/any23/servlet/RedirectServlet.java
Violation | Message | Line |
---|---|---|
Line has trailing spaces. | 29 | |
Line has trailing spaces. | 33 | |
Line is longer than 80 characters. | 34 | |
Method 'doPost' is not designed for extension - needs to be abstract, final or empty. | 34 | |
Missing a Javadoc comment. | 34 | |
Parameter request should be final. | 34 | |
Parameter response should be final. | 34 | |
Line is longer than 80 characters. | 39 | |
Method 'doGet' is not designed for extension - needs to be abstract, final or empty. | 39 | |
Missing a Javadoc comment. | 39 | |
Parameter request should be final. | 39 | |
Parameter response should be final. | 39 | |
Line is longer than 80 characters. | 46 | |
Line is longer than 80 characters. | 52 | |
'+' should be on a new line. | 57 | |
'+' should be on a new line. | 58 | |
Avoid inline conditionals. | 59 |
org/apache/any23/servlet/Servlet.java
Violation | Message | Line |
---|---|---|
File does not end with a newline. | 0 | |
Missing a Javadoc comment. | 50 | |
Missing a Javadoc comment. | 52 | |
Missing a Javadoc comment. | 55 | |
'static' modifier out of order with the JLS suggestions. | 55 | |
Name 'schemeRegex' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. | 55 | |
Method 'doGet' is not designed for extension - needs to be abstract, final or empty. | 58 | |
Line is longer than 80 characters. | 59 | |
Parameter req should be final. | 59 | |
Parameter resp should be final. | 59 | |
Line is longer than 80 characters. | 65 | |
'406' is a magic number. | 65 | |
Line is longer than 80 characters. | 70 | |
'404' is a magic number. | 70 | |
Line is longer than 80 characters. | 74 | |
Method 'doPost' is not designed for extension - needs to be abstract, final or empty. | 77 | |
Line is longer than 80 characters. | 78 | |
Parameter req should be final. | 78 | |
Parameter resp should be final. | 78 | |
Line is longer than 80 characters. | 83 | |
'400' is a magic number. | 83 | |
Line is longer than 80 characters. | 89 | |
'406' is a magic number. | 89 | |
Line is longer than 80 characters. | 93 | |
Line is longer than 80 characters. | 95 | |
Line is longer than 80 characters. | 96 | |
Line is longer than 80 characters. | 100 | |
'400' is a magic number. | 100 | |
Line is longer than 80 characters. | 104 | |
Line is longer than 80 characters. | 107 | |
Line is longer than 80 characters. | 109 | |
Line is longer than 80 characters. | 129 | |
Missing a Javadoc comment. | 129 | |
Parameter request should be final. | 129 | |
Line is longer than 80 characters. | 131 | |
Line is longer than 80 characters. | 134 | |
Missing a Javadoc comment. | 156 | |
Parameter request should be final. | 156 | |
'if' construct must use '{}'s. | 157 | |
'3' is a magic number. | 158 | |
Missing a Javadoc comment. | 169 | |
Parameter request should be final. | 169 | |
'if' construct must use '{}'s. | 170 | |
'3' is a magic number. | 171 | |
'3' is a magic number. | 172 | |
Missing a Javadoc comment. | 198 | |
Parameter uri should be final. | 198 | |
Missing a Javadoc comment. | 202 | |
'static' modifier out of order with the JLS suggestions. | 202 | |
Name 'schemeAndSingleSlashRegex' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. | 202 | |
Missing a Javadoc comment. | 205 | |
Parameter uri should be final. | 205 | |
Missing a Javadoc comment. | 209 | |
Parameter req should be final. | 209 | |
'if' construct must use '{}'s. | 210 | |
'if' construct must use '{}'s. | 211 | |
'if' construct must use '{}'s. | 215 | |
Line is longer than 80 characters. | 219 | |
Missing a Javadoc comment. | 219 | |
Parameter responder should be final. | 219 | |
Parameter uri should be final. | 219 | |
Parameter report should be final. | 219 | |
Line is longer than 80 characters. | 225 | |
'400' is a magic number. | 227 | |
Line is longer than 80 characters. | 232 | |
Method 'createHTTPDocumentSource' is not designed for extension - needs to be abstract, final or empty. | 232 | |
Missing a Javadoc comment. | 232 | |
Parameter httpClient should be final. | 232 | |
Parameter uri should be final. | 232 | |
Missing a Javadoc comment. | 237 | |
Parameter s should be final. | 237 | |
Line is longer than 80 characters. | 240 | |
Missing a Javadoc comment. | 249 | |
Parameter request should be final. | 249 | |
Name 'PARAMETER' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 250 | |
'if' construct must use '{}'s. | 252 | |
'if' is not followed by whitespace. | 252 | |
'if' construct must use '{}'s. | 253 | |
'if' is not followed by whitespace. | 253 | |
'if' construct must use '{}'s. | 254 | |
Line is longer than 80 characters. | 254 | |
'if' is not followed by whitespace. | 254 | |
'if' construct must use '{}'s. | 255 | |
Line is longer than 80 characters. | 255 | |
'if' is not followed by whitespace. | 255 | |
Line is longer than 80 characters. | 257 | |
Line has trailing spaces. | 260 | |
Line is longer than 80 characters. | 261 | |
Missing a Javadoc comment. | 261 | |
Parameter request should be final. | 261 | |
Missing a Javadoc comment. | 266 | |
Parameter request should be final. | 266 | |
Missing a Javadoc comment. | 270 | |
Parameter request should be final. | 270 |
org/apache/any23/servlet/WebResponder.java
Violation | Message | Line |
---|---|---|
Import from illegal package - sun.security.validator.ValidatorException. | 35 | |
Line is longer than 80 characters. | 52 | |
Missing a Javadoc comment. | 52 | |
Name 'writerRegistry' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. | 52 | |
Missing a Javadoc comment. | 89 | |
Parameter any23servlet should be final. | 89 | |
'any23servlet' hides a field. | 89 | |
Parameter response should be final. | 89 | |
'response' hides a field. | 89 | |
Missing a Javadoc comment. | 96 | |
Missing a Javadoc comment. | 100 | |
Parameter in should be final. | 101 | |
Parameter eps should be final. | 102 | |
Parameter format should be final. | 103 | |
Parameter report should be final. | 104 | |
Parameter annotate should be final. | 104 | |
'if' construct must use '{}'s. | 106 | |
'if' construct must use '{}'s. | 107 | |
'!' is followed by whitespace. | 112 | |
')' is preceded with whitespace. | 112 | |
'415' is a magic number. | 114 | |
Line is longer than 80 characters. | 124 | |
'502' is a magic number. | 127 | |
'502' is a magic number. | 131 | |
'502' is a magic number. | 136 | |
'500' is a magic number. | 140 | |
Line is longer than 80 characters. | 145 | |
'501' is a magic number. | 148 | |
'200' is a magic number. | 158 | |
'if' is not followed by whitespace. | 169 | |
Line is longer than 80 characters. | 175 | |
Line is longer than 80 characters. | 184 | |
Missing a Javadoc comment. | 184 | |
Parameter code should be final. | 184 | |
Parameter msg should be final. | 184 | |
Parameter report should be final. | 184 | |
Line has trailing spaces. | 187 | |
Missing a Javadoc comment. | 188 | |
Parameter ps should be final. | 188 | |
Line is longer than 80 characters. | 192 | |
Missing a Javadoc comment. | 192 | |
Parameter rth should be final. | 192 | |
Parameter vr should be final. | 192 | |
Parameter data should be final. | 192 | |
Parameter ps should be final. | 192 | |
Missing a Javadoc comment. | 200 | |
Parameter rth should be final. | 200 | |
Parameter ps should be final. | 200 | |
Line is longer than 80 characters. | 210 | |
Missing a Javadoc comment. | 210 | |
Parameter msg should be final. | 210 | |
Parameter e should be final. | 210 | |
Parameter vr should be final. | 210 | |
Parameter ps should be final. | 210 | |
Line is longer than 80 characters. | 211 | |
Avoid inline conditionals. | 213 | |
'if' is not followed by whitespace. | 215 | |
Missing a Javadoc comment. | 232 | |
Parameter data should be final. | 232 | |
Parameter ps should be final. | 232 | |
Line is longer than 80 characters. | 245 | |
Missing a Javadoc comment. | 245 | |
Parameter code should be final. | 245 | |
Parameter msg should be final. | 245 | |
Parameter e should be final. | 245 | |
Parameter vr should be final. | 245 | |
Parameter report should be final. | 245 | |
Line is longer than 80 characters. | 260 | |
Line is longer than 80 characters. | 262 | |
Line is longer than 80 characters. | 267 | |
Missing a Javadoc comment. | 267 | |
Parameter format should be final. | 267 | |
Parameter report should be final. | 267 | |
Parameter annotate should be final. | 267 | |
'400' is a magic number. | 271 | |
Line is longer than 80 characters. | 272 | |
'(' is followed by whitespace. | 279 | |
')' is preceded with whitespace. | 279 | |
Line is longer than 80 characters. | 289 | |
Missing a Javadoc comment. | 289 | |
Parameter format should be final. | 289 | |
Parameter annotate should be final. | 289 | |
Line is longer than 80 characters. | 291 | |
Line is longer than 80 characters. | 297 | |
Line is longer than 80 characters. | 299 | |
'if' is not followed by whitespace. | 299 | |
'if' is not followed by whitespace. | 301 | |
'if' is not followed by whitespace. | 303 | |
Line is longer than 80 characters. | 308 |
org/apache/any23/servlet/conneg/Any23Negotiator.java
Violation | Message | Line |
---|---|---|
Utility classes should not have a public or default constructor. | 23 | |
Missing a Javadoc comment. | 25 | |
'static' modifier out of order with the JLS suggestions. | 25 | |
Name 'any23negotiator' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. | 25 | |
')' is preceded with whitespace. | 31 | |
')' is preceded with whitespace. | 32 | |
')' is preceded with whitespace. | 33 | |
')' is preceded with whitespace. | 36 | |
')' is preceded with whitespace. | 37 | |
')' is preceded with whitespace. | 40 | |
')' is preceded with whitespace. | 41 | |
')' is preceded with whitespace. | 43 | |
')' is preceded with whitespace. | 44 | |
')' is preceded with whitespace. | 45 | |
Missing a Javadoc comment. | 50 |
org/apache/any23/servlet/conneg/ContentTypeNegotiator.java
Violation | Message | Line |
---|---|---|
File does not end with a newline. | 0 | |
Missing a Javadoc comment. | 32 | |
Line is longer than 80 characters. | 34 | |
Missing a Javadoc comment. | 34 | |
Line has trailing spaces. | 35 | |
Line is longer than 80 characters. | 36 | |
Missing a Javadoc comment. | 36 | |
Missing a Javadoc comment. | 38 | |
'{' is not preceded with whitespace. | 38 | |
'{' is not followed by whitespace. | 38 | |
'}' is not preceded with whitespace. | 38 | |
Line has trailing spaces. | 43 | |
Method 'getBestMatch' is not designed for extension - needs to be abstract, final or empty. | 47 | |
Parameter accept should be final. | 47 | |
Expected @param tag for 'accept'. | 47 | |
Method 'getBestMatch' is not designed for extension - needs to be abstract, final or empty. | 60 | |
Parameter accept should be final. | 60 | |
Expected @param tag for 'accept'. | 60 | |
Parameter userAgent should be final. | 60 | |
Expected @param tag for 'userAgent'. | 60 | |
Method 'addVariant' is not designed for extension - needs to be abstract, final or empty. | 75 | |
Missing a Javadoc comment. | 75 | |
Parameter mediaType should be final. | 75 | |
Method 'setDefaultAccept' is not designed for extension - needs to be abstract, final or empty. | 86 | |
Parameter accept should be final. | 86 | |
Expected @param tag for 'accept'. | 86 | |
Line is longer than 80 characters. | 95 | |
Line is longer than 80 characters. | 97 | |
Line is longer than 80 characters. | 98 | |
Method 'addUserAgentOverride' is not designed for extension - needs to be abstract, final or empty. | 101 | |
Parameter userAgentString should be final. | 102 | |
Parameter originalAcceptHeader should be final. | 103 | |
Parameter newAcceptHeader should be final. | 104 | |
Line is longer than 80 characters. | 107 | |
Missing a Javadoc comment. | 111 | |
Parameter accept should be final. | 111 | |
Missing a Javadoc comment. | 122 | |
Missing a Javadoc comment. | 124 | |
Missing a Javadoc comment. | 125 | |
Missing a Javadoc comment. | 126 | |
Missing a Javadoc comment. | 128 | |
Parameter mediaType should be final. | 128 | |
Method 'addAliasMediaType' is not designed for extension - needs to be abstract, final or empty. | 132 | |
Missing a Javadoc comment. | 132 | |
Parameter mediaType should be final. | 132 | |
Method 'makeDefault' is not designed for extension - needs to be abstract, final or empty. | 137 | |
Missing a Javadoc comment. | 137 | |
Method 'getMediaType' is not designed for extension - needs to be abstract, final or empty. | 141 | |
Missing a Javadoc comment. | 141 | |
Method 'isDefault' is not designed for extension - needs to be abstract, final or empty. | 145 | |
Missing a Javadoc comment. | 145 | |
Method 'getAliases' is not designed for extension - needs to be abstract, final or empty. | 149 | |
Missing a Javadoc comment. | 149 | |
Missing a Javadoc comment. | 154 | |
Missing a Javadoc comment. | 156 | |
Missing a Javadoc comment. | 157 | |
Missing a Javadoc comment. | 158 | |
Missing a Javadoc comment. | 159 | |
Missing a Javadoc comment. | 160 | |
Missing a Javadoc comment. | 162 | |
Parameter ranges should be final. | 162 | |
'ranges' hides a field. | 162 | |
Missing a Javadoc comment. | 166 | |
Line is longer than 80 characters. | 174 | |
Line is longer than 80 characters. | 180 | |
Avoid inline conditionals. | 180 | |
Line is longer than 80 characters. | 183 | |
Missing a Javadoc comment. | 183 | |
Parameter variant should be final. | 183 | |
Parameter isAliasFor should be final. | 183 | |
'if' construct must use '{}'s. | 184 | |
Missing a Javadoc comment. | 192 | |
Parameter variant should be final. | 192 | |
Missing a Javadoc comment. | 196 | |
Parameter variant should be final. | 196 | |
'0.00001' is a magic number. | 199 | |
Line has trailing spaces. | 202 | |
Missing a Javadoc comment. | 205 | |
Missing a Javadoc comment. | 207 | |
Missing a Javadoc comment. | 208 | |
Missing a Javadoc comment. | 209 | |
Line is longer than 80 characters. | 211 | |
Missing a Javadoc comment. | 211 | |
Parameter userAgentPattern should be final. | 211 | |
'userAgentPattern' hides a field. | 211 | |
Parameter original should be final. | 211 | |
'original' hides a field. | 211 | |
Parameter replacement should be final. | 211 | |
'replacement' hides a field. | 211 | |
Missing a Javadoc comment. | 217 | |
Parameter acceptHeader should be final. | 217 | |
Missing a Javadoc comment. | 221 | |
Parameter acceptHeader should be final. | 221 | |
Parameter userAgentHeader should be final. | 221 | |
Missing a Javadoc comment. | 227 | |
Line has trailing spaces. | 231 |
org/apache/any23/servlet/conneg/MediaRangeSpec.java
Violation | Message | Line |
---|---|---|
File does not end with a newline. | 0 | |
Line has trailing spaces. | 30 | |
Class MediaRangeSpec should be declared as final. | 32 | |
Missing a Javadoc comment. | 34 | |
Name 'tokenPattern' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. | 34 | |
Missing a Javadoc comment. | 36 | |
Name 'parameterPattern' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. | 36 | |
Missing a Javadoc comment. | 39 | |
Name 'mediaRangePattern' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. | 39 | |
Missing a Javadoc comment. | 41 | |
Name 'qValuePattern' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. | 41 | |
Missing a Javadoc comment. | 43 | |
Missing a Javadoc comment. | 45 | |
Missing a Javadoc comment. | 47 | |
Missing a Javadoc comment. | 49 | |
Missing a Javadoc comment. | 51 | |
Line has trailing spaces. | 52 | |
Missing a Javadoc comment. | 53 | |
Line has trailing spaces. | 54 | |
Line is longer than 80 characters. | 59 | |
Line is longer than 80 characters. | 62 | |
'+' should be on a new line. | 71 | |
'+' should be on a new line. | 72 | |
'+' should be on a new line. | 73 | |
Line is longer than 80 characters. | 83 | |
Expected an @return tag. | 85 | |
Parameter mediaType should be final. | 85 | |
Expected @param tag for 'mediaType'. | 85 | |
Line is longer than 80 characters. | 94 | |
Expected an @return tag. | 97 | |
Parameter mediaRange should be final. | 97 | |
Expected @param tag for 'mediaRange'. | 97 | |
'3' is a magic number. | 104 | |
'7' is a magic number. | 105 | |
Line is longer than 80 characters. | 114 | |
'3' is a magic number. | 114 | |
Avoid inline conditionals. | 114 | |
'3' is a magic number. | 114 | |
Must have at least one statement. | 122 | |
Line is longer than 80 characters. | 126 | |
First sentence should end with a period. | 129 | |
Parameter s should be final. | 134 | |
Expected @param tag for 's'. | 134 | |
Missing a Javadoc comment. | 143 | |
Parameter s should be final. | 143 | |
Missing a Javadoc comment. | 147 | |
Parameter s should be final. | 147 | |
Missing a Javadoc comment. | 151 | |
Parameter type should be final. | 152 | |
'type' hides a field. | 152 | |
Parameter subtype should be final. | 153 | |
'subtype' hides a field. | 153 | |
Parameter parameterNames should be final. | 154 | |
'parameterNames' hides a field. | 154 | |
Parameter parameterValues should be final. | 154 | |
'parameterValues' hides a field. | 154 | |
Parameter quality should be final. | 155 | |
'quality' hides a field. | 155 | |
Missing a Javadoc comment. | 165 | |
Missing a Javadoc comment. | 186 | |
Missing a Javadoc comment. | 190 | |
Missing a Javadoc comment. | 194 | |
Missing a Javadoc comment. | 198 | |
Missing a Javadoc comment. | 202 | |
Parameter parameterName should be final. | 202 | |
Missing a Javadoc comment. | 211 | |
Missing a Javadoc comment. | 215 | |
Missing a Javadoc comment. | 219 | |
Missing a Javadoc comment. | 223 | |
Parameter range should be final. | 223 | |
'if' construct must use '{}'s. | 224 | |
'if' construct must use '{}'s. | 225 | |
'if' construct must use '{}'s. | 226 | |
'if' construct must use '{}'s. | 227 | |
'if' construct must use '{}'s. | 228 | |
'3' is a magic number. | 228 | |
'3' is a magic number. | 229 | |
'if' construct must use '{}'s. | 233 | |
Missing a Javadoc comment. | 239 | |
Parameter mediaRanges should be final. | 239 | |
Missing a Javadoc comment. | 253 |
org/apache/any23/servlet/conneg/package-info.java
Violation | Message | Line |
---|---|---|
First sentence should end with a period. | 18 |
org/apache/any23/servlet/package-info.java
Violation | Message | Line |
---|---|---|
First sentence should end with a period. | 18 |