/[Apache-SVN]
ViewVC logotype

Revision 1891721


Jump to revision: Previous Next
Author: ylavic
Date: Thu Jul 22 15:33:19 2021 UTC (2 years, 9 months ago)
Changed paths: 1
Log Message:
core: don't close the socket when failing in ap_start_lingering_close().

* server/connection.c (ap_start_lingering_close): Don't apr_socket_close().

* server/connection.c (ap_lingering_close): Do apr_socket_close() on
  ap_start_lingering_close() failure.

On failure ap_start_lingering_close() did not consistently close the socket,
so the caller had to call apr_socket_close() too with possible/unreliable
EBADF.  The only upstream callers of ap_start_lingering_close() are MPM event
and ap_start_lingering_close(), but any third-party user has this issue so the
change should't break anyone.

Follow up to r1891716.
Github: #208


Changed paths

Path Details
Directoryhttpd/httpd/trunk/server/connection.c modified , text changed

infrastructure at apache.org
ViewVC Help
Powered by ViewVC 1.1.26