/[Apache-SVN]
ViewVC logotype

Revision 1691489


Jump to revision: Previous Next
Author: violetagg
Date: Fri Jul 17 07:02:58 2015 UTC (8 years, 9 months ago)
Changed paths: 8
Log Message:
Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=55317
Merged revisions 1526730, 1538833, 1539180, 1691487 from tomcat/trunk:
- Facilitate weaving by allowing ClassFileTransformer to be added to WebppClassLoader. Patch be Nick Williams
- Rename. Loader is a poor choice as there is a separate Loader component
- Review of r1539036 by Nick Williams.
copyWithoutTransformers(), as defined in the interface InstrumentableClassLoader, returns a ClassLoader. The start() method is not defined in ClassLoader, it is specific to WebappClassLoader. Furthermore, code calling copyWithoutTransformers() won't have access to WebappClassLoader to call start() reflectively if a SecurityManager is enabled.
So, the copyWithoutTransformers() method needs to call start() before it returns the copied class loader. Otherwise, it will be useless to JPA providers and the like.
- Corrected the Tomcat 7 version where this interface was introduced for the first time

Changed paths

Path Details
Directorytomcat/tc7.0.x/trunk/ modified , props changed
Directorytomcat/tc7.0.x/trunk/java/org/apache/catalina/loader/LocalStrings.properties modified , text changed
Directorytomcat/tc7.0.x/trunk/java/org/apache/catalina/loader/WebappClassLoader.java modified , text changed
Directorytomcat/tc7.0.x/trunk/java/org/apache/tomcat/InstrumentableClassLoader.java
(Copied from tomcat/trunk/java/org/apache/tomcat/InstrumentableClassLoader.java, r1526730)
added , text changed
Directorytomcat/tc7.0.x/trunk/test/org/apache/catalina/loader/TestWebappClassLoaderWeaving.java
(Copied from tomcat/trunk/test/org/apache/catalina/loader/TestWebappClassLoaderWeaving.java, r1526730)
added
Directorytomcat/tc7.0.x/trunk/test/org/apache/catalina/loader/TesterNeverWeavedClass.java
(Copied from tomcat/trunk/test/org/apache/catalina/loader/TesterNeverWeavedClass.java, r1526730)
added
Directorytomcat/tc7.0.x/trunk/test/org/apache/catalina/loader/TesterUnweavedClass.java
(Copied from tomcat/trunk/test/org/apache/catalina/loader/TesterUnweavedClass.java, r1526730)
added
Directorytomcat/tc7.0.x/trunk/webapps/docs/changelog.xml modified , text changed

infrastructure at apache.org
ViewVC Help
Powered by ViewVC 1.1.26