/[Apache-SVN]
ViewVC logotype

Revision 1619418


Jump to revision: Previous Next
Author: stsp
Date: Thu Aug 21 14:51:35 2014 UTC (10 years, 4 months ago)
Changed paths: 5
Log Message:
Fix misreporting of tree conflict victim's node kind, in particular
in cases where the victim is an obstruction.

* subversion/libsvn_wc/conflicts.c
  (read_tree_conflict_desc): The local node kind cannot be derived from the
   incoming src-left or src-right node kind as was done here. For example,
   local unversioned files were labeled as 'local dir' if they obstructed
   an incoming directory addition. If the conflict reason is an obstruction
   we must check the on-disk state of the node and use it to describe the
   victim's node kind. Missing nodes obviously have node type 'none' but
   they were described as 'file'.

* subversion/svn/cl-conflicts.c
  (local_reason_str, incoming_action_str): Describe symlinks as files.
   Handle 'none' and 'unknown' type nodes.

* subversion/tests/cmdline/switch_tests.py
  (forced_switch_failures): This test had node kinds swapped around. Fix it.

* subversion/tests/cmdline/tree_conflict_tests.py
  (actual_only_node_behaviour): Output for 'none' type nodes has changed.
   Adjust expected output accordingly.

* subversion/tests/libsvn_wc/conflict-data-test.c
  (test_read_write_tree_conflicts): Create on-disk files and directories
   in the test working copy since they are now required for proper node
   kind detection. Previously, this test was using wc-db data only.


Changed paths

Path Details
Directorysubversion/trunk/subversion/libsvn_wc/conflicts.c modified , text changed
Directorysubversion/trunk/subversion/svn/cl-conflicts.c modified , text changed
Directorysubversion/trunk/subversion/tests/cmdline/switch_tests.py modified , text changed
Directorysubversion/trunk/subversion/tests/cmdline/tree_conflict_tests.py modified , text changed
Directorysubversion/trunk/subversion/tests/libsvn_wc/conflict-data-test.c modified , text changed

infrastructure at apache.org
ViewVC Help
Powered by ViewVC 1.1.26