/[Apache-SVN]
ViewVC logotype

Revision 1593015


Jump to revision: Previous Next
Author: stefan2
Date: Wed May 7 13:43:55 2014 UTC (10 years, 7 months ago)
Changed paths: 2
Log Message:
[Reverted in r1620930]

Follow-up to r1591919: Fix fs tests on Windows and non-threaded platforms
by always using our svn_mutex__t and thus being able to detect recursive
locking attempts.

For non-threaded platforms, always using svn_mutex__t adds almost zero
overhead to the FS file locking that we need to do anyways.  On Windows,
the overhead slightly larger but all the APR functions that svn_mutex__*
calls have very efficient implementations on Windows.  So here, the relative
overhead is minimal as well.

OTOH, all our tested platforms will detect incorrect / non-portable lock
usage.

* subversion/libsvn_fs_fs/fs.h
  (SVN_FS_FS__USE_LOCK_MUTEX): Drop. 

* subversion/libsvn_fs_fs/fs.c
  (fs_serialized_init): We always use our mutex structure.

Changed paths

Path Details
Directorysubversion/trunk/subversion/libsvn_fs_fs/fs.c modified , text changed
Directorysubversion/trunk/subversion/libsvn_fs_fs/fs.h modified , text changed

infrastructure at apache.org
ViewVC Help
Powered by ViewVC 1.1.26