Revision 1502964

On the fsfs-improvements branch:  Move more of the commonly used file and
path utilities from fs_fs.* to utils.*.  Again, we add the svn_fs_fs__
prefix to everything in utils.h.

Also make all path getters that didn't do so before return a const char*
instead of an svn_error_t *.

* subversion/libsvn_fs_fs/util.h
  (SVN_FS_FS__RECOVERABLE_RETRY_COUNT): declare private API constant
  (svn_fs_fs__is_packed_revprop,
   svn_fs_fs__path_rev_shard,
   svn_fs_fs__path_rev,
   svn_fs_fs__path_revprop_generation,
   svn_fs_fs__path_revprops_pack_shard,
   svn_fs_fs__path_revprops_shard,
   svn_fs_fs__path_revprops,
   svn_fs_fs__path_rev_absolute,
   svn_fs_fs__check_file_buffer_numeric,
   svn_fs_fs__update_min_unpacked_rev,
   svn_fs_fs__try_stringbuf_from_file,
   svn_fs_fs__read_content,
   svn_fs_fs__move_into_place): declare private API taken from fs_fs.*
  (svn_fs_fs__path_rev_absolute): ditto; change return type

* subversion/libsvn_fs_fs/util.c
  (svn_fs_fs__is_packed_revprop,
   svn_fs_fs__path_rev_shard,
   svn_fs_fs__path_rev,
   svn_fs_fs__path_revprop_generation,
   svn_fs_fs__path_revprops_pack_shard,
   svn_fs_fs__path_revprops_shard,
   svn_fs_fs__path_revprops,
   svn_fs_fs__path_rev_absolute,
   svn_fs_fs__check_file_buffer_numeric,
   svn_fs_fs__update_min_unpacked_rev,
   svn_fs_fs__try_stringbuf_from_file,
   svn_fs_fs__read_content,
   svn_fs_fs__move_into_place): rename; code taken from fs_fs.c
  (svn_fs_fs__path_rev_absolute): ditto; change return type

* subversion/libsvn_fs_fs/fs_fs.h
  (svn_fs_fs__path_rev_absolute): remove here, moved to utils.h

* subversion/libsvn_fs_fs/fs_fs.c
  (RECOVERABLE_RETRY_COUNT): renamed and moved to utils.h
  (is_packed_revprop,
   path_revprop_generation,
   path_rev_shard,
   path_rev,
   svn_fs_fs__path_rev_absolute,
   path_revprops_shard,
   path_revprops_pack_shard,
   path_revprops,
   check_file_buffer_numeric,
   update_min_unpacked_rev,
   try_stringbuf_from_file,
   read_content,
   move_into_place): renamed and moved to utils.c
  (with_some_lock_file,
   check_format_file_buffer_numeric,
   svn_fs_fs__open,
   get_youngest,
   open_pack_or_rev_file,
   read_revprop_generation_file,
   write_revprop_generation_file,
   read_non_packed_revprop,
   get_revprop_packname,
   read_pack_revprop,
   get_revision_proplist,
   write_non_packed_revprop,
   set_revision_proplist,
   get_and_increment_txn_key_body,
   get_next_revision_ids,
   commit_body,
   write_revision_zero,
   svn_fs_fs__create,
   packed_revprop_available,
   recover_body,
   hotcopy_update_current,
   hotcopy_body,
   hotcopy_create_empty_dest): update callers
  (get_root_changes_offset): update docstring

* subversion/libsvn_fs_fs/lock.c
  (delete_lock, 
   lock_body): update callers

* subversion/libsvn_fs_fs/pack.c
  (pack_body): update docstring