/[Apache-SVN]
ViewVC logotype

Revision 1502305


Jump to revision: Previous Next
Author: danielsh
Date: Thu Jul 11 18:08:23 2013 UTC (11 years, 5 months ago)
Changed paths: 5
Log Message:
Use svn_pool_create() instead of apr_pool_create().

Presently, this means that if an apr_pool_create() fails, abort_fn() will be
called.  None of those plafces check for NULL results from the allocator,
so the net effect is changing a NULL dereference to calling our pool.c
function abort_on_pool_failure() (which is marginally better).

* subversion/bindings/swig/python/libsvn_swig_py/swigutil_py.c
  (svn_swig_py_release_py_lock):
* subversion/libsvn_subr/error.c
  (make_error_internal, svn_error_dup, svn_handle_error2):
* subversion/libsvn_subr/nls.c
  (svn_nls_init):
* subversion/mod_dav_svn/mod_dav_svn.c
  (merge_xml_in_filter): 
    s/apr_pool_create/svn_pool_create/

* subversion/bindings/cxxhl/src/exception.cpp
  (Error::compile_messages):
    Same change, but was reverted in r1502345.

Changed paths

Path Details
Directorysubversion/trunk/subversion/bindings/cxxhl/src/exception.cpp modified , text changed
Directorysubversion/trunk/subversion/bindings/swig/python/libsvn_swig_py/swigutil_py.c modified , text changed
Directorysubversion/trunk/subversion/libsvn_subr/error.c modified , text changed
Directorysubversion/trunk/subversion/libsvn_subr/nls.c modified , text changed
Directorysubversion/trunk/subversion/mod_dav_svn/mod_dav_svn.c modified , text changed

infrastructure at apache.org
ViewVC Help
Powered by ViewVC 1.1.26